[RESOLVED] Please help - Debugging this code

Bbob

These codes are from my login.php - it used to work before but I think my registration script somehow screwed by login.php

<?php

//Start connect to DB

mysql_connect("localhost", "root", "")or die("cannot connect"); 
mysql_select_db("hp")or die("cannot select DB");
//End connect to DB


session_start();

$dbusername=$_POST['dbusername']; 
$dbpassword=$_POST['dbpassword'];

$sql= mysql_query("SELECT * FROM login WHERE username='$dbusername' AND password='$dbpassword'");

$count=mysql_num_rows($sql);


if ($count == 1) 
{
	$_SESSION['dbusername'] = dbusername;

while ($row = mysql_fetch_assoc($result))
{
	$usertype = $row['type'];

	if ($usertype==user)
	{
		header("location:user_myaccount.php");
	}

	else
	{
		header("location:admin_main.php");
	}
}
}

else 
	{
	echo "Wrong Username or Password";
	}
?>

I really cant find whats wrong with it.

I get this error
Warning: mysql_fetch_assoc(): supplied argument is not a valid MySQL result resource in C:\wamp\www\hp\checklogin.php on line 24

but Im pretty sure there's nothing wrong with that line

Bbob

Manage to fixed it. Sorry for the false alarm

nevvermind

Yes, you were using $result instead of $sql, but make a habit in telling us how you've solved your problems.

It's just great when you have op's skull-aching problem, and at the end he's bursting with joy and fluffy and pinkish confetti cuz he's worked it out somehow, and there you are - dumb-staring at the screen, after hours of trying to get that damned code together, swearing, stabbing, throwing the mouse at the cat and the laptop at your mother, wondering what the heck he has done, having that feeling of sand in your eyes and your urinary meatus, a reaction to the sheer noxious, narcissistic manner in which that heartless, baby-eating, self-centered, triple-horned, negative-empathy op posted on the forums.

But, hey, we're glad you're glad.

(this is a joke, with a drop of acid truth in it. so don't flame it. i'm actually in a good mood. I also like potato chips)

Bbob

nevvermind;10960244 wrote:
Yes, you were using $result instead of $sql, but make a habit in telling us how you've solved your problems.

It's just great when you have op's skull-aching problem, and at the end he's bursting with joy and fluffy and pinkish confetti cuz he's worked it out somehow, and there you are - dumb-staring at the screen, after hours of trying to get that damned code together, swearing, stabbing, throwing the mouse at the cat and the laptop at your mother, wondering what the heck he has done, having that feeling of sand in your eyes and your urinary meatus, a reaction to the sheer noxious, narcissistic manner in which that heartless, baby-eating, self-centered, triple-horned, negative-empathy op posted on the forums.

But, hey, we're glad you're glad.

(this is a joke, with a drop of acid truth in it. so don't flame it. i'm actually in a good mood. I also like potato chips)

😃

Its just that it took me 1 whole day to code the login script + table. I panic when I tried to connect it to the registration script I made today and both didnt work

bradgrafelman

Also note that user-supplied data should never be placed directly into a SQL query string, else your code will be vulnerable to SQL injection attacks and/or just plain SQL errors. Instead, you must first sanitize it with a function such as [man]mysql_real_escape_string/man (for string data).