mysqli query setup

jgetner

im trying to make a function that splits up the process of making a query and use the information received from the function to build a working INSERT INTO query.

currently im getting this error

Unknown column 'josh' in 'field list'

and the function code..

public static function insert($name , $columns , $values)
	{
	    $sql ="INSERT INTO $name ($columns) VALUES ( $values )";


	self::$insertinto = mysqli_query(self::$connect , $sql ) or die(mysqli_error(self::$connect));

	mysqli_real_escape_string(self::$connect , self::$querytable);

    return self::$insertinto;
}

Bilbozilla

What are the names of your fields? It appears you are requesting that one is named 'josh', but this looks more like it belongs in a field named 'firstname' or something like that.

Your $name variable is the name of the table, and then your $columns should be defined as the the (firstname, lastname, address, zip) or whatever it is you want entered. Your $values variable should have 'Josh' in it.

I think that's what you're asking.

jgetner

if i understand you right yes.

the function works like this

insert('tablename' , 'fieldnames' , 'Values');

i inserted

insert('user' , 'names' , 'josh');

witch it should enter josh into the users table in the names field but i get that error

Bilbozilla

What's your SQL statement look like?

run an echo statement to display your SQL statement

echo $query;

jgetner

this is the SQL statment.

INSERT INTO users (names) VALUES ( josh )Unknown column 'josh' in 'field list'

Bilbozilla

jgetner;10960372 wrote:
$sql ="INSERT INTO $name ($columns) VALUES ( $values )";

all tables and columns are confirmed and set.

your sql statement should output

INSERT INTO user (name) VALUES ('josh')

Make sure you have the quotation marks around the $values variable.

Not
$sql ="INSERT INTO $name ($columns) VALUES ( $values )";

but
$sql ="INSERT INTO $name ($columns) VALUES ( '$values' )";

jgetner

worked great thank you.

gotta love the small stuff....