[RESOLVED] Multi-Dim Array Output Error

rwhite35

Hi,

I have a class that outputs drop down menu options. The sub menu is calling a 3D array where one layer is a sub menus id, labels and links. The problem I'm having is the output to the browser is wack. The feature is partially working and repeating itself. Somehow, I've messed up the iterations. Any thoughts are appreciated:

Here is the site (in progress)
http://www.ohiostrophyquestoutfitters.com/aboutus.php

Here is the class script:

//drop menus, inherits properties and methods from mainnav
class dropnav extends mainnav 
{
	//the arrary
	public $sublinks = array(array(array('id'=>'About','sublabel'=>'Page1-About','sublink'=>'page1.html'),
		array('id'=>'About','sublabel'=>'Page2-About','sublink'=>'page2.html'),
		array('id'=>'About','sublabel'=>'Page3-About','sublink'=>'page3.html'),
		),
		array(array('id'=>'Packages','sublabel'=>'Page4-Package','sublink'=>'page4.html'),
		array('id'=>'Packages','sublabel'=>'Page5-Package','sublink'=>'page5.html'),
		array('id'=>'Packages','sublabel'=>'Page6-Package','sublink'=>'Page6.html'),
		),
	);

public function subnavigate()
{
	$this->subnavigateMenu($this->sublinks);
}

public function subnavigateMenu($sublinks)
{
	//make available outside this function.
	global $label, $url;

	//Start outer loop, should loop once for each layer
	$cycle_layer=count($sublinks);
	//layers outer loop
	for ($i=0; $i < $cycle_layer; $i++){
		//row outerloop
		for ($e=0; $e < $cycle_layer; $e++){
		//assign the layer id for the div id.
		$subid=$sublinks[$i][$e]['id'];

	//Output open div tag with layer id
	printf ("<div id=\"dropmenu\"><ul id=\"%s\">", $subid);

	//iterate through menu links
	$subarr_size=count($sublinks);
	for ($layer=$i; $layer < $subarr_size; $layer++){
		for ($row = $e; $row < $subarr_size; $row++){
			$label = $sublinks[$layer][$row]['sublabel'];
			$url = $sublinks[$layer][$row]['sublink'];

	//call the function with variable page label and link attributes.    
	$this->subnavigateLink($label, $url);
	}//close row loop
	}//close layer loop
	echo "</div>";
	}//close layer outer loop
	}//close row outerloop

 }//closed function

//function for building menu labels and links.
public function subnavigateLink($label,$url,$active=true)
{	
	if ($active) {
		printf ("<a href=\"%s\" target=\"_self\">", $url);
		echo $label;
		echo '</a>',"\n\r";
	}
}
}

Thanks in advance
rwhite35

dagon

use the boards php tags to make your posted code readable.
indent to make it easier to read and debug
use foreach() instead of for() when looping an array

rwhite35

Thanks Dagon,

Using the foreach loop gets me closer to where I need to be. The issue now seems to be the first row of the first array layer and the last row of the second layer are displaying. The rest is being skipped. I need two loops, one for the outer limit which creates the div tag with unique id (stored in the array) and a second inner loop that propagates the a tag and link label. The out loop would loop once for each array layer where the inner loop would loop until the condition is met, namely, the end of the layers content.

Alternatively, I could create a separate array for each drop down menu, but why take the easy way out, right.

Here is the revised looping code.

public function subnavigateMenu($sublinks)
	{
		global $label2, $url;

	//Start outer loop, should loop once for each layer
	//to assign the UL id to each layer.
	$cycle_layer=count($sublinks);
	$i=0;
		foreach ($sublinks as $k=>$v) {
			if ($i<=$cycle_layer){
		       printf ("<div id=\"dropmenu\"><ul id=\"%s\">", $v[$i]['id']);
		}
		$i++;

	//Start inner loop, should iterate through all rows
	reset($sublinks);
	$counter=count($sublinks);
	$e=0;
		foreach ($sublinks as $k2=>$v2) {
			if ($e<=$counter){
			$label2=$v2[$e]['sublabel'];
		}
		$this->subnavigateLink($label2, $url);
		$e++;
		}//closes foreach 2

		echo "</div>";
	}//close div loop
}//closed function

Thanks in advance,

rwhite35

I got the solution to work. The issue was where the anchor tags output was placed in the outside the function (in a separate function design for the output). By placing a foreach for the <A HREF> tag inside the the same loop as the <DIV>, the functioned works as expected. It builds a menus with menu options pulled from a multidimensional (3D - layers, rows and columns) array. Here is the correct code:

//navigation for drop menus, inherits properties and methods from mainnav
class dropnav extends mainnav
{
        //class attributes
        public $sublinks = array(array(array('id'=>'About','sublabel'=>'Page1-About','sublink'=>'page1.html'),
                array('id'=>'About','sublabel'=>'Page2-About','sublink'=>'page2.html'),
                array('id'=>'About','sublabel'=>'Page3-About','sublink'=>'page3.html'),
                ),
                array(array('id'=>'Packages','sublabel'=>'Page4-Package','sublink'=>'page4.html'),
                array('id'=>'Packages','sublabel'=>'Page5-Package','sublink'=>'page5.html'),
                array('id'=>'Packages','sublabel'=>'Page6-Package','sublink'=>'Page6.html'),
                ),
        );

    public function subnavigate()
    {
            $this->subnavigateMenu($this->sublinks);
    }

    //Build the dropdown menus
    public function subnavigateMenu($sublinks)
    {

            //Start outer loop, should loop once for each layer
            //outer loop is a numbered index, use conditional loop
            //output the div tag and assign the ul tag id to the div.
            $cycle_layer=count($sublinks); //count the layers to iterate
            $i=0;
                    foreach ($sublinks as $k=>$v) {
                            if ($i<=$cycle_layer){
                                    printf ("<div class=\"dropmenudiv\"><ul id=\"%s\">", $v[$i]['id']);
                            }//closes the if statement

              //Start the inner loop
              //output each anchor tag and text link
                 foreach ($v as $k2=>$v2){
                    printf ("<a href=\"%s\" target=\"_self\">%s</a><br />", $v2['sublink'], $v2['sublabel']);
                    }//closes the inner loop

                    //close the div tag and loop
                    echo "</div><br />";
               }//close div loop
            //increment over the next layer of the 3 dimensional array
            $i++;

    }//closed function

Good'on ya mate,
rwhite35