Help with a large amount of $_POST Variables

Aden_Fraser

So currently I'm having to use this block of uglyness since I can't get extract() to work with my $POST variables (since they have hyphens in them eg $POST['property-zip'])

I was hoping someone could either explain how extract() deals with illegal characters or has a shorter and more efficient way of defining the following:

$first_s_name = $_POST['first-s-name'];
		$second_s_name = $_POST['second-s-name'];
		$p_residence = $_POST['p_residence'];
		$affidavit_address = $_POST['affidavit-address'];
		$p_english = $_POST['p_english'];
		$first_borrower_social = $_POST['first-borrower-social'];
		$second_borrower_social = $_POST['second-borrower-social'];
		$first_lender_name = $_POST['first-lender-name'];
		$first_lender_loannum = $_POST['first-lender-loannum'];
		$second_lender_name = $_POST['second-lender-name'];
		$second_lender_loannum = $_POST['second-lender-loannum'];
		$short_sale_property_address1 = $_POST['short-sale-property-address1'];
		$short_sale_property_address2 = $_POST['short-sale-property-address2'];
		$borrower_name = $_POST['borrower-name'];
		$borrower_address = $_POST['borrower-address'];
		$borrower_number = $_POST['borrower-number'];
		$beneficiary_address = $_POST['beneficiary-address'];
		$trustee_address = $_POST['trustee-address'];
		$property_apn = $_POST['property-apn'];
		$property_trust_name = $_POST['property-trust-name'];
		$property_city = $_POST['property-city'];
		$property_county = $_POST['property-county'];
		$property_zip = $_POST['property-zip'];

nevvermind

Dunno about extract (yet!). Try this (note the variable... variable):

foreach($_POST as $k => $v) {
  $$k = $v;
}

NogDog

One alternative, of course, is simply to use the $_POST elements and not duplicate them to scalar variables. It might even make your code slightly more efficient since you aren't going to the trouble of duplicating the contents in another, separate set of variables. 🙂

But if you feel you really need to, then the code above might work, if you first do a str_replace() on the key ($k) to replace the hyphens with underscores, and then do the assignment to the variable variable.

dagon

or you could just change the form elements names.

Aden_Fraser

Am using the following:

		foreach($_POST as $k => $v) {
			$k = str_replace("-","_",$k);
			$$k = $v;
		}

Thanks 😃

NogDog

dagon;10961679 wrote:
or you could just change the form elements names.

Well, there's always that, but that's not as much fun. :p I was sort of assuming there was some reason that couldn't be done; but you know what happens when you assume.... :rolleyes:

On a more serious not, if you're going to use extract, consider using the optional prefix argument and/or EXTR_SKIP for the optional extract-type argument, so that a malicious user cannot overwrite any of your variables that should not be. Or at least make sure the extract() is done before any other variables are defined/set.