PHP and CSS ...

battleaxe

Hello,

I've been trying to build some php pages, and everything has been working ok so far. However, now that I'm trying to style them, I can't seem to make the css work with the php. For exemple, this is part of a newsletter script.

CSS Page

<!---

body {
margin-left: 0px;
margin-top: 0px;
font-family:Georgia, "Times New Roman", Times, serif;
color; #000000;
font-size: 12px
}

.bg {
	font-family: Georgia, "Times New Roman", Times, serif;
	font-size: 14px;
	background-attachment: fixed;
	background-image: url(http://www.guildsandgangs.pt/newsletter/bg2.jpg);
	background-repeat: no-repeat;
	background-position: left top;
}

PHP Page:

<link rel="stylesheet" href="admin/style.css" type="text/css">

<?php
include "admin/connect.php";
?>

<?php
print "<table width='292' height='97' border='0' cellpadding='0' cellspacing='0' class='bg'>";
print "<tr>";
print "<td>";
print "<form action='$yourfilepath/sub.php' method='post'>";
print "E-mail: <input type='text' name='email' size='30'><br>";
print "<input type='radio' name='choice' value='sub'>&nbsp;Subscribe&nbsp;&nbsp;&nbsp;&nbsp;";
print "<input type='radio' name='choice' value='unsub'>&nbsp;Unsubscribe<br>";
print "<input type='submit' name='submit' value='submit'></form>";
print "</td>";
print "</tr>";
print "</table>";
?>

The css doesn't work...
I also tried doing


<?php
include "admin/style.css";
?>

but it didn't work either..

Can someone help me please???

Krik

The "<!---" at the beginning of your CSS file may be causing the trouble. Do note that HTML tags do not work inside a CSS file and "<!---" is an opening HTML comment tag

If you need to have comments in the CSS file do it like so

 /* your comment */

Also note you do not need to comment out your CSS when it is in its own file.

And really you don't have to comment out CSS at all even in an HTML file, like you had to in the old days of HTML. If anyone is still using a browser that doesn't support the <style> tag I say tough :glare: they can just put up with the extra junk on the screen. Maybe they will think to up date their browser to IE 2 (or maybe 3), whichever it was that they introduced HTML 4 in.

Ok that's a bit harsh, and way off topic, but out of date browser versions do irritate me something fierce. 😃

bradgrafelman

Thread moved to ClientSide Technologies forums, since CSS has nothing to do with PHP (you're just dealing with plain HTML in the end).

nevvermind

That page is almost full html! So embed PHP in HTML, not the other way around.
Keep in mind that any page that has PHP in it, should have the ".php" extension or whatever you've set up your server to parse as PHP (php3, inc etc.), otherwise it wont work.

The table tag has no "height" attribute - set its height via CSS.

<?php
include "admin/connect.php";

// do stuff here with the database or whatever

?>

<link rel="stylesheet" href="admin/style.css" type="text/css">

<table width="292" border="0" cellpadding="0" cellspacing="0" class="bg">
    <tr>
        <td>
            <form action="<?php echo "$yourfilepath/sub.php" ?>" method="post">
                E-mail: <input type="text" name="email" size="30"><br>
                <input type="radio" name="choice" value="sub">&nbsp;Subscribe&nbsp;&nbsp;&nbsp;&nbsp
                <input type="radio" name="choice" value="unsub">&nbsp;Unsubscribe<br>
                <input type="submit" name="submit" value="submit">
            </form>
        </td>
    </tr>
</table>

The CSS ideally should look like this:

body {
    margin-left: 0px;
    margin-top: 0px;
    font-family: Georgia, "Times New Roman", Times, serif;
    color: #000000;
    font-size: 12px;
}

.bg {
    font-size: 14px;
    background-attachment: fixed;
    background-image: url(http://www.guildsandgangs.pt/newsletter/bg2.jpg);
    background-repeat: no-repeat;
    background-position: left top;
}

You had a syntax error at "color; #000000;". Guess why.
The "font-family: Georgia, "Times New Roman", Times, serif;" in "bg" class was inherited from "body", so I've discarded it. Also, the URL to your background image is hardly a good idea.

If this doesn't work either, maybe your path to the css is incorrect. If your php file is in the same folder as the CSS, the href should be just "style.css". The same goes to your "include" path in the PHP code.

Use an IDE (dreamweaver, pdt, netbeans, Eclipse etc.) or an advanced text editor (like notepad++). With those you can easily spot syntax errors.