[RESOLVED] Where to insert the SLEEP() funktion?, thanks

[Gmans]

Hi
When the payment from a payment gateway is successfull, I go to this code belowe. But the SQL database has not being updated whit a 1 for paid, before the script i over. Where to insert th sleep funktion to have time to let the database update so the script can se that the user has a 1 for payment before it goes further?

thanks.

/////////////////////////////////////////////////////////////
// Payment success or manual payment
/////////////////////////////////////////////////////////////
if ($step=="signup5") {

$status = $_GET ["status"];
//print_r ($_POST);

//Success
if ($status=="T") {

	$user = $_POST["item_number"];
	db_connect ($cfg["db_server"], $cfg["db_user"], $cfg["db_pass"], $cfg["db_database"]);
	$sql = "select * from users where user='$user'";
	$now =  strtotime(date("d/m/Y H:i:s"));
	$result = db_query ($sql);
	while ($row=mysql_fetch_object($result)) {
		$billing = $row->billing;
		$expire = date("d/m/Y H:i:sa",$row->expire);
	}

	//Active the user after paying sucessfully.



	$sql = "update users set billing = '1' where user='".$_SESSION["cur_user"]."'";
	[COLOR="Red"]sleep(10);[/COLOR]
	mysql_query($sql);
	mysql_close();


	if ($billing=="1") {
		echo "Your paiment is sucessfull $expire <br />";
		echo "<a href=index.php?page=signup6>continue</a>";	
	} else {
		echo "not payed yet<br />";
		echo "<a href='index.php?page=signup6'>continue</a>. and login.";	
	}	
}

//Failure
if ($status=="F") {

	$retry = $_POST ["retry_at"];
	echo "Paiment failed.";
}

}

[anoopmail]

another option would be show a screen to the user which redirects to another success or failure screen after 10 seconds using meta refresh tags.

[johanafm]

Why the conversion from timestamp time() to a string representing a date, and then from date string to timestamp?

#$now =  strtotime(date("d/m/Y H:i:s"));
$now = time();			# same thing...

Why the while loop? If you get more than one row, $billing will contain the value of the last row only... And I'm guessing you should never get more than one row due to the where clause

Gmans;10962519 wrote:

		$result = db_query ($sql);
		while ($row=mysql_fetch_object($result)) {
			$billing = $row->billing;
			$expire = date("d/m/Y H:i:sa",$row->expire);
		}

... so I'd rather use this if you want to make really double sure that you only got one row.

if ( ($num_rows = mysql_num_rows($result)) == 0) {
# no user found
}
elseif ($num_rows > 1) {
# bad
}
else {
# no need for while loop
$row = mysql_fetch...
}

Else, why not trust the db (if your where clause is checking against a field set as primary key or one that is otherwise having the unique constraint) and just check that you got your one user, which makes for simpler php code.

if ($row = mysql_fetch...) {
# you got your one row
}
else {
# no user found
}

This is done AFTER you query the database (the initial SELECT). Doesn't matter how long you wait to do it, it will always be done after you query the database initially. And there really is no reason to wait. Remove the sleep.

Gmans;10962519 wrote:

		$sql = "update users set billing = '1' where user='".$_SESSION["cur_user"]."'";
		mysql_query($sql);

If you simply checked if your update query was successful, you KNOW that billing = 1 in the db

$sql = "update users set billing = '1' where user='".$_SESSION["cur_user"]."'";
if ($result = mysql_query($sql)) {
# success - billing really was set to 1 (for zero, one or several rows)
# to find out how many rows were affected...
$updated_rows = mysql_num_rows($result); # should be 1
}
else {
# your query failed for some reason
}

But, looking at your script, if I interpret the intention correctly, you allready know wether to update billing=1 or not, so why not turn the things around for simplicity

# 1. update ... set billing=1 where
# 2. select ... where ...

# 3. now you have up to date data for the user, including the new billing information.

And finally, why pass an integer value as a string literal? I hope the table field is of a discrete type, i.e. integer of some (small) size, or boolean

Gmans;10962519 wrote:

$sql = "... billing = '1' ..."; 

$sql = "... billing = 1 ...";

[Gmans]

Thanks for all the good ideas.
But first I would like to see my script work before I do the changes. I have this problem that the "1" is correct set in the database (billing), but it will never go to the first if ($billing=="1") statement, it alway goes to the "else". This is my first problem. Do you know why it cannot see that the "1" is set in the database. It was therefor I cameup with the idea to insert the sleep funktion because maybe the database was to slow to update.
Please come with some solutions, and I will be very happy. Thanks from Denmark

[anoopmail]

answer is simple. You've pulled out billed value from the database, hold it on a variable, then executing the UPDATE query. So the value hold by the variable remains the same irrespetive of what you do on the db. You could move the SELECT query to a line after the UPDATE query would make things right.

[Gmans]

Hi This is a very good idea I like to follow. I have tried to put in a variable but it stil not funtion. Mayby you can change this code to the correct?

if ($status=="T") {

	$user = $_POST["item_number"];
	db_connect ($cfg["db_server"], $cfg["db_user"], $cfg["db_pass"], $cfg["db_database"]);
	$sql = "select * from users where user='$user'";
	$now =  strtotime(date("d/m/Y H:i:s"));
	$result = db_query ($sql);
	while ($row=mysql_fetch_object($result)) {
		$billing = $row->billing;
		$expire = date("d/m/Y H:i:sa",$row->expire);
	}

	//Active the user after paying sucessfully.
	$sql = "update users set billing = '1' where user='".$_SESSION["cur_user"]."'";

	mysql_query($sql);
	mysql_close();

}

[COLOR="Red"]$billing2 = billing;[/COLOR]	if ($billing2=="1") {
		echo "OK payment done <br />";
		echo "<a href=index.php?page=signup6>Go on</a>";	
	} else {
		echo "Please wait. Payment not done yet.....<br />";
		}	


//Failure
if ($status=="F") {

	$retry = $_POST ["retry_at"];
	echo "Betaling fejlet, vil fors&#248;ge efter $retry.  Derefter skal du pr&#248;ve at logge ind med dit brugernavn og kodeord.";
}

}

[anoopmail]

copying the variable to another does not make any change. Try this.

$sql = "update users set billing = '1' where user='".$_SESSION["cur_user"]."'";
mysql_query($sql);
$billed = mysql_affected_rows() == 1 ;
mysql_close() ;
if ($billed){
. . . 

[Gmans]

Hi anoopmail
You are the best. Its working. Greetings from Denmark :-)