Dynamic URL

[laanes]

When I enter the URL http://www.lock-tech.co.uk/groups.php into the browser then the new generated URL displays rootURL + rootURL/filename.php like so:

http://www.lock-tech.co.uk/index.php?myURL=http://www.lock-tech.co.uk/groups.php

and outputs these errors:

Notice: Undefined variable: getVars in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 15

Notice: Undefined index: vat in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 39

Notice: Undefined index: action in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 62

Notice: Undefined index: UPDATE_x in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 62

Notice: Undefined index: DELETE_x in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 62

Notice: Undefined index: page in /home/swansea3/public_html/lock-tech.co.uk/groups.php on line 6

Notice: Undefined index: prodg in /home/swansea3/public_html/lock-tech.co.uk/groups.php on line 11

Notice: Undefined index: prodg in /home/swansea3/public_html/lock-tech.co.uk/groups.php on line 16

The block of code that generates the URL's looks like this:

$URLvars=substr($_SERVER["PHP_SELF"], strrpos($_SERVER["PHP_SELF"],"/")+1);
$vatLink=$URLvars;
$thisPageURL=$_SERVER["PHP_SELF"];
if(strpos($thisPageURL, "secure/locktech/")!==false)$thisPageURL=substr($_SERVER["PHP_SELF"], 16);
$prodLink="http://www.lock-tech.co.uk/".$thisPageURL;

And when I click on the product groups link on the index page the URL does not change at all, just displays the root URL and the following errors:

Notice: Undefined index: vat in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 39

Notice: Undefined index: action in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 62

Notice: Undefined index: UPDATE_x in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 62

Notice: Undefined index: DELETE_x in /home/swansea3/public_html/lock-tech.co.uk/scrptz/sessions.php on line 62

Notice: Undefined index: page in /home/swansea3/public_html/lock-tech.co.uk/groups.php on line 6

Does anyone know what might be the issue?

[NogDog]

The warnings are the result of the code trying to access array elements that do not exist. Without knowing what those lines of code actually look like, it's hard to say exactly why. (Is it the $POST array, $GET, $_SESSION, etc.?) There's also not enough info to know if those errors have anything to do with the functionality problems you describe, or if they are a separate issue.

[laanes]

NogDog;10962551 wrote:

The warnings are the result of the code trying to access array elements that do not exist. Without knowing what those lines of code actually look like, it's hard to say exactly why. (Is it the $POST array, $GET, $_SESSION, etc.?) There's also not enough info to know if those errors have anything to do with the functionality problems you describe, or if they are a separate issue.

sessions.php:

<?php
$GLOBALS['now']=gmdate('D, d M Y H:i:s').' GMT';
header('Expires: '.$GLOBALS['now']); // rfc2616 - Section 14.21
header('Last-Modified: '.$GLOBALS['now']);
header('Cache-Control: no-store, no-cache, must-revalidate, pre-check=0, post-check=0, max-age=0'); // HTTP/1.1
header('Pragma: no-cache'); // HTTP/1.0

// Clean all GET vars and stick them into an array
foreach($HTTP_GET_VARS as $varName=>$value)$getVars[$varName]=trim(clean($value, 60));

// Clean all POST vars and stick them into an array
foreach($HTTP_POST_VARS as $varName=>$value)$postVars[$varName]=trim(clean($value, 60));

// Start session if none active
if(!$getVars["uid"])startSession();

// Read session vars
readSessionVars($getVars["uid"]);

// Start a new session if the previous one has timed out
if((time()-$sessions["theTime"])>1800)
{
//	destroySession($sessions["ID"]);
	$notify=" onload=\"alert('Your session has timed out!');\"";
	startSession();
	readSessionVars($getVars["uid"]);
}
else
{
	unset($notify);
	// Update session time
	updateSession($sessions["ID"], "theTime", time());
}

// Get discount level from session
$discLevel=$discArray[$sessions["discount"]];

// Update VAT session var if necessary
if($getVars["vat"])updateSession($sessions["ID"], "vat", $getVars["vat"]);

// Generate links for navigation, VAT and bookmarking
$URLvars=substr($_SERVER["PHP_SELF"], strrpos($_SERVER["PHP_SELF"],"/")+1);
$vatLink=$URLvars;
$thisPageURL=$_SERVER["PHP_SELF"];
if(strpos($thisPageURL, "secure/locktech/")!==false)$thisPageURL=substr($_SERVER["PHP_SELF"], 16);
$prodLink="http://www.lock-tech.co.uk".$thisPageURL;

// Put all GET vars into vars for navigation, VAT and direct link
$varDiv="?";
foreach($getVars as $varName=>$value)
{
	if($varName!="vat" && $varName!="SCode" && $varName!="qty" && $varName!="price" && $varName!="action" && $varName!="UPDATE_x" && $varName!="UPDATE_y" && $varName!="DELETE_x" && $varName!="DELETE_y")
	{
		if($varName!="uid" && $varName!="goto")$prodLink.=$varDiv.$varName."=".$value; 	// Direct link
		if($varName!="logError")$vatLink.=$varDiv.$varName."=".$value;					// VAT
		if($varName!="page" && $varName!="index")$URLvars.=$varDiv.$varName."=".$value; // NAV
		$varDiv="&amp;";
	}
}

// If any action is performed
if($getVars["action"] || $getVars["UPDATE_x"] || $getVars["DELETE_x"])
{
	if($getVars["UPDATE_x"] && !$getVars["action"])$getVars["action"]="UPDATE";
	if($getVars["DELETE_x"] && !$getVars["action"])$getVars["action"]="DELETE";

switch($getVars["action"])
{
	case "ADD":
	if($getVars["qty"]>0)addtoBasket($getVars["SCode"], $getVars["qty"], $getVars["price"]);
	break;

	case "UPDATE":
	updateProd(0, $getVars["SCode"], $getVars["qty"], false);
	break;

	case "DELETE":
	delProd($getVars["SCode"]);
	break;

	case "KILL":
	killBasket();
}
}
updateShipping($sessions["shippingID"]);
?>

[laanes]

NogDog;10962551 wrote:

The warnings are the result of the code trying to access array elements that do not exist. Without knowing what those lines of code actually look like, it's hard to say exactly why. (Is it the $POST array, $GET, $_SESSION, etc.?) There's also not enough info to know if those errors have anything to do with the functionality problems you describe, or if they are a separate issue.

groups.php:

<?php
ini_set('error_reporting', E_ALL); 
include 'scrptz/functions.php';

// Page vars
$thisPage=$getVars["page"];
if($thisPage<1)$thisPage=1;
$firstGroup=($thisPage*16)-16;

// Get group details and stick them into an array
$qMain="SELECT * FROM PGroups WHERE PG = '".$getVars["prodg"]."'";
$result=mysql_query($qMain) or die(mysql_error());
$groupDetails=mysql_fetch_array($result);

// Get all sub groups in current product group
$qMain="SELECT * FROM SubG WHERE ProdG = '".$getVars["prodg"]."'";
$result=mysql_query($qMain) or die(mysql_error());

// Stick sub groups in a 2D associative array
$j=0;
while ($row=mysql_fetch_array($result))
{
	foreach($row as $i=>$data)$array[$j][$i]=$data;
	$j++;
}

// Calculate vars for navigation
$totalGroups=$j;
$totalPages=ceil($totalGroups/16);

// Set page title (for bookmark)
$pageTitle=$groupDetails["GPname"];

// Set top title
if($totalGroups>0){$topTitle="VIEW PRODUCTS";}else{$topTitle="ERROR";}
?>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="scrptz/styles.css" rel="stylesheet" type="text/css">
<script language="JavaScript" type="text/javascript">var theID="<?php echo $getVars['uid']; ?>";</script>
<script language="JavaScript" src="scrptz/content.js" type="text/javascript"></script>
<script language="JavaScript" src="scrptz/menu.js" type="text/javascript"></script>
<script language="JavaScript" src="scrptz/scripts.js" type="text/javascript"></script>
</head>
<body background="imgz/bg.gif" leftmargin="0" topmargin="0" marginheight="0" marginwidth="0"<?php echo $notify ?>>
<?php include("top.php"); ?>
<table width="952" height="509" border="0" cellpadding="0" cellspacing="0" class="maintext">
<?php if($sessions['accCode']){?><form action="http://www.lock-tech.co.uk/index.php" method="post" name="logout" target="_parent"><input name="account" type="hidden" value="<?php echo $sessions['accCode']; ?>"><input name="killSession" type="hidden" value="<?php echo $getVars['uid']; ?>"></form><?php }?>
  <tr> 
    <td width="1" rowspan="5" bgcolor="#000000"></td>
    <td height="21" background="imgz/topbar.gif" bgcolor="#14359E">&nbsp;</td>
    <td height="21" colspan="5" valign="middle" background="imgz/topbar.gif" bgcolor="#14359E" class="mainyellow"><?php include("scrptz/dd_menu.php"); ?></td>
    <td height="21" background="imgz/topbar.gif" bgcolor="#14359E">&nbsp;</td>
    <td width="1" rowspan="5" bgcolor="#000000"></td>
  </tr>
  <tr> 
    <td width="5" rowspan="3">&nbsp;</td>
    <td width="306" height="30" valign="bottom" class="title2"><?php echo $groupDetails["GPname"] ?></td>
    <td width="11" rowspan="3"><img src="imgz/maindiv.gif" width="11" height="466"></td>
    <td width="306" height="30" align="center" valign="bottom" class="title2"><?php if($totalGroups>0){?><a href="g_view.php?pgroup=<?php echo $groupDetails["PG"] ?>&amp;uid=<?php echo $getVars['uid']; ?>" class="link4" onmouseover="window.status='View List of all Products in <?php echo $groupDetails["GPname"] ?>'; return true">VIEW ALL</a> | <a href="g_browse.php?pgroup=<?php echo $groupDetails["PG"] ?>&amp;uid=<?php echo $getVars['uid']; ?>" class="link4" onmouseover="window.status='Browse all Products in <?php echo $groupDetails["GPname"] ?>'; return true">BROWSE ALL</a><?php }?></td>
    <td width="11" rowspan="3"><img src="imgz/maindiv.gif" width="11" height="466"></td>
    <td width="306" height="30" align="center" valign="bottom">&nbsp;</td>
    <td width="5" rowspan="3">&nbsp;</td>
  </tr>
  <tr> 
    <td height="20" valign="top" class="mainbold"></td>
    <td width="306" rowspan="2" valign="top" class="maintext">
      <?php for($i=$firstGroup; $i<($firstGroup+8) && $i<$totalGroups; $i++){?>
      <a href="sub.php?PSubG=<?php echo $array[$i]["SPG"] ?>&amp;uid=<?php echo $getVars['uid']; ?>" class="link1" onmouseover="window.status='View Products in <?php echo $array[$i]["SPGname"] ?>'; return true"><?php echo $array[$i]["SPGname"] ?></a><br>
			<?php
			// Get all subsubs in current sub group
			$qMain="SELECT * FROM SubSubG WHERE SPG = '".$array[$i]["SPG"]."'";
			$result=mysql_query($qMain) or die(mysql_error());

		// Print subsubs
		while ($row=mysql_fetch_array($result))
		{
		?>
			[<a href="subsub.php?PSubSubG=<?php echo $row["SSPG"]?>&amp;uid=<?php echo $getVars['uid']; ?>" class="link3" onmouseover="window.status='View Products in <?php echo $row["SSPGName"]?>'; return true"><?php echo $row["SSPGName"]?></a>]&nbsp;
		<?php
		}
		?>
		<br><br>
		<?php }?></td>
<td width="306" rowspan="2" valign="top" class="maintext">
  <?php for($i=$firstGroup+8; $i<($firstGroup+16) && $i<$totalGroups; $i++){
  ?>
  <a href="sub.php?PSubG=<?php echo $array[$i]["SPG"] ?>&amp;uid=<?php echo $getVars['uid']; ?>" class="link1" onmouseover="window.status='View Products in <?php echo $array[$i]["SPGname"] ?>'; return true"><?php echo $array[$i]["SPGname"] ?></a><br>
		<?php
		// Get all subsubs in current sub group
		$qMain="SELECT * FROM SubSubG WHERE SPG = '".$array[$i]["SPG"]."'";
		$result=mysql_query($qMain) or die(mysql_error());

		// Print subsubs
		while ($row=mysql_fetch_array($result))
		{
		?>
			[<a href="subsub.php?PSubSubG=<?php echo $row["SSPG"]?>&amp;uid=<?php echo $getVars['uid']; ?>" class="link3" onmouseover="window.status='View Products in <?php echo $row["SSPGName"]?>'; return true"><?php echo $row["SSPGName"]?></a>]&nbsp;
		<?php
		}
		?>
		<br><br>
		<?php }?></td>
  </tr>
  <tr> 
    <td height="416" valign="top" class="mainbold">

<?php if($totalGroups>0)

{

?>

<img src="grp_pics/<?php echo $groupDetails["PG"] ?>.jpg" alt="Group Picture" galleryimg="no"><br><img src="imgz/pixel.gif" width="306" height="5"><br> 

<?php echo $groupDetails["GPText"] ?><?php  }

else
{
?>	

	<p class="noresult">No Products Found.</p><p class="mainbold">Sorry, but there are no products in this section at the moment. The products are constantly being updated, however. Please try again later or <a href="mailto:[e-mail]" class="link1" onmouseover="window.status='Send us an Email.'; return true">contact us</a>.</p><?php }?></td>
  </tr>
  <tr> 
    <td width="5" height="22" background="imgz/btmbar.gif" bgcolor="#14359E">&nbsp;</td>
    <td width="306" height="22" align="center" valign="top" background="imgz/btmbar.gif" bgcolor="#14359E"><a href="javascript:history.back()" onmouseover="prev_btn.src='imgz/prev2.gif';window.status='Previous Page'; return true" onmouseout="prev_btn.src='imgz/prev.gif'"><img name="prev_btn" src="imgz/prev.gif" width="124" height="16" border="0"></a></td>
    <td width="11" height="22" bgcolor="#14359E"><img src="imgz/btmdiv.gif" width="11" height="22"></td>
    <td width="306" height="22" align="center" background="imgz/btmbar.gif" bgcolor="#14359E" class="nav"><? include 'scrptz/nav.php' ?></td>
    <td width="11" height="22" bgcolor="#14359E"><img src="imgz/btmdiv.gif" width="11" height="22"></td>
    <td width="306" height="22" align="center" valign="top" background="imgz/btmbar.gif" bgcolor="#14359E"><a href="javascript:directLink('<?php echo $prodLink; ?>','<? echo $pageTitle ?>')" onmouseover="link_btn.src='imgz/link2.gif'; window.status='Direct Link to This Page'; return true" onmouseout="link_btn.src='imgz/link.gif'"><img name="link_btn" src="imgz/link.gif" alt="" width="182" height="16" border="0"></a></td>
    <td width="5" height="22" background="imgz/btmbar.gif" bgcolor="#14359E">&nbsp;</td>
  </tr>
</table>
</body>
</html>

[NogDog]

First thing that jumps out at me is that you are using the old and now-deprecated $HTTP_GET_VARS and $HTTP_POST_VARS arrays. If you are using anything remotely current in terms of PHP version, you should instead be using $GET and $POST. I might start with that update and see if it helps any.

Also, in general, when depending on get/post inputs, it's a good idea to check if they exist before assuming they do.

if(isset($getVars["uid"] && !$getVars["uid"])startSession();
// or simply
if(empty($getVars["uid"]) startSession();

This will avoid notice-level warnings if it is not set, though it won't fix any logic errors. 🙂

[laanes]

NogDog;10962597 wrote:

First thing that jumps out at me is that you are using the old and now-deprecated $HTTP_GET_VARS and $HTTP_POST_VARS arrays. If you are using anything remotely current in terms of PHP version, you should instead be using $GET and $POST. I might start with that update and see if it helps any.

Also, in general, when depending on get/post inputs, it's a good idea to check if they exist before assuming they do.

if(isset($getVars["uid"] && !$getVars["uid"])startSession();
// or simply
if(empty($getVars["uid"]) startSession();

This will avoid notice-level warnings if it is not set, though it won't fix any logic errors. 🙂

After performing these changes it outputs the following error message:

Parse error: syntax error, unexpected T_STRING in /home/swansea3/public_html/lock-tech.co.uk/home/scrptz/sessions.php on line 15

Line 15:

if(empty($getVars["uid"]) startSession(); 

[NogDog]

Sorry: left out the closing ")" for the empty() function. (I do that a lot if I'm not using a "smart" editor. 🙂 )

if(empty($getVars["uid"])) 

[laanes]

NogDog;10962603 wrote:

Sorry: left out the closing ")" for the empty() function. (I do that a lot if I'm not using a "smart" editor. 🙂 )

if(empty($getVars["uid"])) 

That was the trick indeed, got rid of that last error now but the old ones are back:

Notice: Undefined index: vat in /home/swansea3/public_html/lock-tech.co.uk/home/scrptz/sessions.php on line 39

Notice: Undefined index: action in /home/swansea3/public_html/lock-tech.co.uk/home/scrptz/sessions.php on line 62

Notice: Undefined index: UPDATE_x in /home/swansea3/public_html/lock-tech.co.uk/home/scrptz/sessions.php on line 62

Notice: Undefined index: DELETE_x in /home/swansea3/public_html/lock-tech.co.uk/home/scrptz/sessions.php on line 62

Notice: Undefined index: page in /home/swansea3/public_html/lock-tech.co.uk/home/groups.php on line 6

[NogDog]

Most likely you need to repeat the same pattern in each of those locations if the only goal is to get rid of the warnings. HOWEVER, you then need to ask yourself, why are all those indexes undefined in the first place? Where are they supposed to be coming from, and why aren't they set?

[laanes]

NogDog;10962606 wrote:

Most likely you need to repeat the same pattern in each of those locations if the only goal is to get rid of the warnings. HOWEVER, you then need to ask yourself, why are all those indexes undefined in the first place? Where are they supposed to be coming from, and why aren't they set?

Ok, I will look through the files again and try to find aswers to those questions.

[laanes]

NogDog;10962606 wrote:

Most likely you need to repeat the same pattern in each of those locations if the only goal is to get rid of the warnings. HOWEVER, you then need to ask yourself, why are all those indexes undefined in the first place? Where are they supposed to be coming from, and why aren't they set?

While looking into files i found this URL quite a few times actually. I am not sure what those links are for, is it some kind of way to validate SSL maybe?

if($sessions["accCode"])
{
	$acLink="https://fusion.bpweb.net/secure/locktech/account.php?uid=".$getVars['uid'];
	$checkLink="https://fusion.bpweb.net/secure/locktech/checkout.php?uid=".$getVars['uid'];
}
else
{
	$acLink="/login.php?uid=".$getVars['uid'];
	$checkLink="/login.php?goto=https://fusion.bpweb.net/secure/locktech/checkout.php&uid=".$getVars['uid'];
}

I don't think these are even valid links any more if they ever used to be.