[RESOLVED] Making 6 column html table from 2 database fields

[kiwibrit]

$query = "SELECT thumb, popup FROM Web_images WHERE brand= '$brand' ORDER BY id" ;
$result = mysql_query($query) or die ("Error in query: $query. " .
mysql_error());
// count number of rows in database
$row_count = mysql_num_rows($result);
echo "<table>\n";
while($row = mysql_fetch_array($result)){
echo "<tr><td>". $row['thumb']." ".$row['popup']."</td></tr>\n";
}
echo "</table>\n";
?>

produces a one-column html table like this:

<table>
<tr><td>Timage1 Pimage1</td></tr>
<tr><td>Timage2 Pimage2</td></tr>
<tr><td>Timage3 Pimage3</td></tr>
<tr><td>Timage4 Pimage4</td></tr>
<tr><td>Timage5 Pimage5</td></tr>
<tr><td>Timage6 Pimage6</td></tr>
etc
</table>

But I need to have 6 columns, not one - so that I get this result:

<tr>
<td>Timage1 Pimage1</td>
<td>Timage2 Pimage2</td>
<td>Timage3 Pimage3</td>
<td>Timage4 Pimage4</td>
<td>Timage5 Pimage5</td>
<td>Timage6 Pimage6</td>
</tr>
<tr>
<td>Timage7 Pimage7</td>
etc

As I see it the cells need to be called up in blocks of six - with each <td> having a successive pair of database cells. So far my attempts have resulted blocks of six with the same pair, rather than successive pair of images. Can anybody help?

[cretaceous]

add a counter - e.g. $i

$query = "SELECT thumb, popup FROM Web_images WHERE brand= '$brand' ORDER BY id" ;
$result = mysql_query($query) or die ("Error in query: $query. " .
mysql_error());

// count number of rows in database
$row_count = mysql_num_rows($result);
echo "<table>\n<tr>\n";
while($row = mysql_fetch_array($result)){
if ($i && $i%6==0 )echo"</tr>\n<tr>\n";
echo "<td>". $row['thumb']." ".$row['popup']."</td>\n";
$i++;
}
echo "</tr></table>\n";
?>

you'll need to try it - I think that will do it
if your last row is less than 6 items it will not have a matching number of the 6 "<td>"s -so it might not html validate

[kiwibrit]

Thanks, that works. I couldn't figure the conditional logic applied to the counter - very neat answer. I am looking at resolving the last line problem by checking to see if I have arrived at the last line - by seeing if the counter has arrived at $rowcount. If I have then checking to see if $row_count%6 !=0. If it is, then writing the row so that it has the number of <td>&nbsp;</td> required from

$remainder=$row_count%6;
$extracells=6-$remainder;

Still have to figure the logic required . As ever, every answer brings another challenge 😉

[cretaceous]

you have it figured out now?

the extra bit looks correct if you then do

for ($xc=0;$xc<$extracells ;$xc++){
echo "<td>&nbsp;</td>";
}

or you could do
echo "<td colspan='$extracells'>&nbsp;</td>";

[kiwibrit]

No I hadn't figured out then - Mrs kiwibrit thinks I spend far too much non-work time in front of my work computer - and I probably would have been lynched had I stayed on!

$remainder=$row_count%6;
$extracells=6-$remainder;
//no of extra cells required to make up last row
echo "<table>\n<tr>\n";
while($row = mysql_fetch_array($result))
{ 		
	if ($i && $i%6==0 )
	echo "</tr>\n<tr>\n";								
	echo "<td>". $row['thumb']." ".$row['popup']."</td>\n";
	$i++;
}
if ($extracells >0) 
echo "<td colspan=".$extracells.">&nbsp;</td>;\n";
echo "</tr>\n</table>\n";

sorts it - thanks very much