[RESOLVED] SQL syntax problem

[JeremyTiki]

Hey everyone I've got a problem with my sql, I cant quite see what it is, maybe someone here will have better luck

$insert_sql = "INSERT INTO topics VALUES '','$username','$contact','$date','normal','$forum_in','0','0'";
    mysql_query($insert_sql);
if (!mysql_query($insert_sql))
  {
  die('Error: ' . mysql_error());
  }

The variables are not really required for this but they are clearly defined earlier in the code I checked that already. But whenever I run the code through I get this error...

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''','name,'[e-mail]','2010-09-05 5:23:56','normal','1','0','0'' at line 1

Any ideas?

[nevvermind]

Link. Just an example on how to use it:

INSERT INTO topics (username, adress, date) VALUES ( '$username', '$contact', '$date' )

Just use the columns you're working on.

[bradgrafelman]

Also note that your code snippet executes the same INSERT query twice, so you're most likely going to end up with duplicate data.

[nevvermind]

bradgrafelman;10962711 wrote:

Also note that your code snippet executes the same INSERT query twice, so you're most likely going to end up with duplicate data.

Where exactly is he doing that in his code?

[JeremyTiki]

nevvermind;10962710 wrote:

Link. Just an example on how to use it:

INSERT INTO topics (username, adress, date) VALUES ( '$username', '$contact', '$date' )

Just use the columns you're working on.

That isnt necissarily true the only time you need to include your columns like that is if your inserting values out of order or skipping columns.
But thanks for your reply!

[JeremyTiki]

bradgrafelman;10962711 wrote:

Also note that your code snippet executes the same INSERT query twice, so you're most likely going to end up with duplicate data.

The code isnt running twice;

First there is a variable with my sql stored inside of it.
Next is the mysql_query function that actually runs the code.
Then there is an IF statement that asks finds out if the mysql_query was successful in running, if it was the code continues, if not the mysql_error function runs.

There is no place in the code where it runs twice

[bradgrafelman]

JeremyTiki wrote:

That isnt necissarily true the only time you need to include your columns like that is if your inserting values out of order or skipping columns.

While that is true, I believe it's commonly considered a bad practice to omit the columns simply because it's not very flexible. What if you alter the table structure? Or what if you're reading over the code later on and come across that INSERT statement - how do you know which column is which?

JeremyTiki wrote:

Next is the mysql_query function that actually runs the code.
Then there is an IF statement that asks finds out if the mysql_query was successful in running

No; mysql_query() is executed twice. The if() statement conditional is evaluated separately - PHP doesn't automagically assume you simply wanted to know what the value returned from the last call to mysql_query() was. If that is what you want, then either remove the first call to mysql_query(), or store its returned value into a variable and use that variable in the if() statement instead.

[nevvermind]

JeremyTiki;10962722 wrote:

That isnt necissarily true the only time you need to include your columns like that is if your inserting values out of order or skipping columns.
But thanks for your reply!

Ah, but you see, if you know that, you should already have known the answer to your own question. 🆒

If you're done, select "Thread Resolved" from "Thread Tools" up above.

PS: Just in case you were skeptic about bradgrafelman's statement (I was, although his 14,484 posts said something about his favorite past-time activity 😉):

<?php
$x = array();

function gimme() {
    global $x;
    $x[] = 'One query?';
    return true;
}

gimme();

if (!gimme()) {
    echo 'hooray!';
}

var_dump($x);
?>

And $x variable looks like:

array
  0 => string 'One query?' (length=10)
  1 => string 'One query?' (length=10)

[JeremyTiki]

Still no luck, I changed the code as you two suggested

   $insert_sql = "INSERT INTO topics(id,username,contact,topic,timestamp,topic_type,forum_id,view,reply) VALUES '','$username','$contact','$post','$date','normal','$forum_in','0','0'";
   $insert_query =  mysql_query($insert_sql);
  if (!$insert_query)
  {
  die('Error: ' . mysql_error());
  }
 else {


echo"<p>Your post has been successful!  <br />
    <a href='index1.php?id=$id'>>>Back<<</a>";
  }

But I still get this error when I attempt to run it

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''','name','contact','Topic post','2010-09-05 19:55:38','normal','1'' at line 1

[bradgrafelman]

You're missing the parenthesis around the VALUES section still - see nevvermind's post above for an example.

[JeremyTiki]

bradgrafelman;10962741 wrote:

You're missing the parenthesis around the VALUES section still - see nevvermind's post above for an example.

That did it! Thanks a bunch guys =]