How to find out why the images are not showing up?

[laanes]

Hi,

On a website, there are products nicely listed with name, description, product code, price and a thumbnail etc.

Now, if you click on a picture thumbnail, a new page called prodwin.php in a new window opens with the product code and for some reason, there is a "no picture available" alt image for every product. The line of code in it:

<td colspan="2"><?php if(file_exists("../pics_p/".$HTTP_GET_VARS["PCode"].".jpg")){?><img src="../pics_p/<?php echo $HTTP_GET_VARS["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no"><?php }else{?><img src="../imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no"><?php }?></td>

On the other hand, when you click on the product name, it loads a different page called g_browse.php and the product image is nicely there. The line of code in it:

<td height="366" colspan="2" valign="top"><?php if(file_exists("pics_p/".$array[$getVars["index"]]["PCode"].".jpg")){?><img src="pics_p/<?php echo $array[$getVars["index"]]["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no"><?php }else{?><img src="imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no"><?php }?></td>

$HTTP_GET_VARS["PCode"].".jpg"

- Product code + .jpg will give the image name in pics_p folder.

a JavaScript block which might also be relavant:

function prodWindow(SCode, PCode, PDescription, thePrice)
{
	var xPos=(screen.availWidth/2)-490;
	var yPos=(screen.availHeight/2)-116;
	var s=",top="+yPos+",left="+xPos;
	var win=open("scrptz/prodwin.php?SCode="+SCode+"&PCode="+PCode+"&PDescription="+PDescription+"&thePrice="+thePrice,'product', "toolbar=no,location=no,directories=no,status=no,menubar=no,resizable=no,copyhistory=no,scrollbars=no,height=414,width=316"+s);
	win.focus();
}

Hope someone spots the problem.

Regards,
laanes

[bradgrafelman]

One problem I notice is your use of one of the deprecated $HTTP*VARS variables. This has been deprecated for some time now and even disabled by default in most recent versions of PHP. You should be using $_GET instead.

[laanes]

bradgrafelman;10962776 wrote:

One problem I notice is your use of one of the deprecated $HTTP*VARS variables. This has been deprecated for some time now and even disabled by default in most recent versions of PHP. You should be using $_GET instead.

Thanks mate for the tip, changed the variable names around.

Still a mystery why the images are not there.

Regards,
laanes

[dagon]

you could provide the site url, it may help

[laanes]

dagon;10962812 wrote:

you could provide the site url, it may help

http://www.lock-tech.co.uk/

Hope this is helpful.

[nevvermind]

I'm assuming prodwin.php and g_browse.php are in the same folder.

Is this working for you? (I've also changed the conditional syntax; I fancy this)

<td colspan="2">
    <?php if (file_exists("pics_p/" . $_GET["PCode"] . ".jpg")): ?>
        <img src="pics_p/<?php echo $_GET["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

[laanes]

nevvermind;10962821 wrote:

I'm assuming prodwin.php and g_browse.php are in the same folder.

Is this working for you? (I've also changed the conditional syntax; I fancy this)

<td colspan="2">
    <?php if (file_exists("pics_p/" . $_GET["PCode"] . ".jpg")): ?>
        <img src="pics_p/<?php echo $_GET["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

File locations:

/public_html/lock-tech.co.uk/g_browse.php

/public_html/lock-tech.co.uk/scrptz/prodwin.php

Thank you for the code mate, looks cleaner and more easily readable now.

Images still do not show up in prodwin.php

Is it because it is not in the root folder?

Regards,
laanes

[nevvermind]

Right. This guy said something like:

Be aware: If you pass a relative path to file_exists, it will return false unless the path happens to be relative to the "current PHP dir" (see chdir() ).

You could use this:

<td colspan="2">
    <?php if (file_exists($_SERVER["DOCUMENT_ROOT"] . "/pics_p/" . $_GET["PCode"] . ".jpg")): ?>
        <img src="../pics_p/<?php echo $_GET["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="../imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

If this doesn't work, see what $_SERVER["DOCUMENT_ROOT"] returns and modify the path accordingly.

It must be a more elegant way of doing this, like defining a path to pics folder to a variable and use that everywhere in your page. Let's wait and see what the other say. All-in-all, file_exists has problems with relative paths, so give it absolute paths. Keep the relative path to the src attribute of your images.

[laanes]

nevvermind;10962827 wrote:

Right. This guy said something like:

You could use this:

<td colspan="2">
    <?php if (file_exists($_SERVER["DOCUMENT_ROOT"] . "/pics_p/" . $_GET["PCode"] . ".jpg")): ?>
        <img src="../pics_p/<?php echo $_GET["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="../imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

If this doesn't work, see what $_SERVER["DOCUMENT_ROOT"] returns and modify the path accordingly.

It must be a more elegant way of doing this, like defining a path to pics folder to a variable and use that everywhere in your page. Let's wait and see what the other say. All-in-all, file_exists has problems with relative paths, so give it absolute paths. Keep the relative path to the src attribute of your images.

http://www.lock-tech.co.uk/documentroot.php

This file gave me the result - /home/swansea3/public_html/lock-tech.co.uk

I have then tried like so:

<td colspan="2">
    <?php if (file_exists($_SERVER["DOCUMENT_ROOT"] . "lock-tech.co.uk/pics_p/" . $_GET["PCode"] . ".jpg")): ?>
        <img src="../pics_p/<?php echo $_GET["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="../imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

and like so:

<td colspan="2">
    <?php if (file_exists($_SERVER["DOCUMENT_ROOT"] . "/home/swansea3/public_html/lock-tech.co.uk/pics_p/" . $_GET["PCode"] . ".jpg")): ?>
        <img src="../pics_p/<?php echo $_GET["PCode"] ?>.jpg" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="../imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

Still - No Picture Available

So do you suggest that $_SERVER["DOCUMENT_ROOT"] . "/pics_p/" should be stored in $picturepath

and ["PCode"] . ".jpg" should be stored in $picturename

and the line would be then..

<?php if (file_exists($picturepath . $_GET($picturename))): ?>

and then it would possibly work?

Regards,
laanes

[nevvermind]

echo $_SERVER["DOCUMENT_ROOT"] . "/home/swansea3/public_html/lock-tech.co.uk/pics";
// this echoes: "/home/swansea3/public_html/lock-tech.co.uk/home/swansea3/public_html/lock-tech.co.uk/pics", doesn't it?

echo $_SERVER["DOCUMENT_ROOT"] . "lock-tech.co.uk/pics_p/";
//this echoes "/home/swansea3/public_html/lock-tech.co.uklock-tech.co.uk/pics_p/"

// not the kind of links you wanted, right?

I'm assuming this:

/public_html/lock-tech.co.uk/imgz/
/public_html/lock-tech.co.uk/pics_p/
/public_html/lock-tech.co.uk/g_browse.php
/public_html/lock-tech.co.uk/scrptz/prodwin.php

Just to be clear, this is for prodwin.php:

<?php 
$picture_path = $_SERVER["DOCUMENT_ROOT"] . "/pics_p/";
$picture_name = $_GET["PCode"] . ".jpg";
?>

<td colspan="2">
    <?php if (file_exists($picture_path . $picture_name)): ?>
        <img src="../pics_p/<?php echo $picture_name; ?>" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="../imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

If this doesn't work, besides me feeling stumped, you should check the name files, the $_GET value that is returned, check your credit card, weather forecast, but check something.

[laanes]

nevvermind;10962835 wrote:

echo $_SERVER["DOCUMENT_ROOT"] . "/home/swansea3/public_html/lock-tech.co.uk/pics";
// this echoes: "/home/swansea3/public_html/lock-tech.co.uk/home/swansea3/public_html/lock-tech.co.uk/pics", doesn't it?

echo $_SERVER["DOCUMENT_ROOT"] . "lock-tech.co.uk/pics_p/";
//this echoes "/home/swansea3/public_html/lock-tech.co.uklock-tech.co.uk/pics_p/"

// not the kind of links you wanted, right?

I'm assuming this:

/public_html/lock-tech.co.uk/imgz/
/public_html/lock-tech.co.uk/pics_p/
/public_html/lock-tech.co.uk/g_browse.php
/public_html/lock-tech.co.uk/scrptz/prodwin.php

Just to be clear, this is for prodwin.php:

<?php 
$picture_path = $_SERVER["DOCUMENT_ROOT"] . "/pics_p/";
$picture_name = $_GET["PCode"] . ".jpg";
?>

<td colspan="2">
    <?php if (file_exists($picture_path . $picture_name)): ?>
        <img src="../pics_p/<?php echo $picture_name; ?>" alt="Product Picture" galleryimg="no">
    <?php else: ?>
        <img src="../imgz/nopic.jpg" alt="No Picture Available" width="306" height="200" galleryimg="no">                                

    <?php endif; ?>
</td>

If this doesn't work, besides me feeling stumped, you should check the name files, the $_GET value that is returned, check your credit card, weather forecast, but check something.

I checked the path and name like so:

$picture_path = $_SERVER["DOCUMENT_ROOT"] . "/pics_p/";
$picture_name = $_GET["PCode"] . ".jpg";


echo $picture_path . "<br>" . $picture_name;

this returns

/home/swansea3/public_html/lock-tech.co.uk/pics_p/

.jpg

Weather is 17 degrees and cloudy 🙂

[nevvermind]

I don't think you fully grasp the GET http method.
When you submit a html form via GET method, then you'll have a non-empty $_GET variable. Read this.

That being said, you must test the $_GET variable in a php page that is actually given information via that method.

--------some_page.html-------------
<form action="page.php" method="GET">
  <input type="text" name="username" />
  <input type="submit" value="Submit this!" />
</form>

******
Some user writes his username in the text input and presses the submit button.
That info is transported to your "action" page: page.php.
Thus, you $_GET variable gets populated.
******

------------ page.php----------------
echo $_GET["username"]; // outputs whatever the user wrote in your html page

Make sure your $_GET["PCode"] gets populated.
BTW, don't quote my entire posts. There's no need.