which.Continue.onclick=function(){..} not working

[varai]

Hello

When the user clicks the example link, the ph_example_win pops up. After that, when the user clicks the Continue button, the popup window should close and go to the next page.

My problem is, the popup window is appearing but it doesn't close when the user clicks Continue. Does anyone know what mistake I'm making?

ph_example_win is the popup window that appears when the example link is clicked.

document.getElementById('ph_no_example_link').onclick=
ph_example_win=window.open('phone_example.html','mywin','location=no width=200 height=160 left=200 top=200 screenX=200 screenY=200');

which.Continue.onclick=
function()
{if (ph_example_win.closed==false) ph_example_win.close();};

is not working. By the way, the above code is inside another javascript function.

However, The following works fine:

which.Continue.onclick = alert("Hello World");

Your help is much appreciated
thank you.

[johanafm]

You have to assign a function reference. You can't assign a function call. Or rather, if you do, the function is executed and the returned result is set as the onclick event handler. Not entirely sure what you wanted to achieve, but this code lets the same button alternate between opening and closing a window

function foo(o) {
	var w = window.open('uri', 'name', "options");
	o.onclick = function() { bar(o, w); };
}
function bar(o, w) {
	if (w) {
		w.close();
	}
	o.onclick = function() { foo(o); };
}

<input type="button" onclick="foo(this);" value="Do stuff" />

[varai]

Thanks a lot johanafm! Yes, your solution worked out great! 🙂