oop fileupload

jgetner

i need some help with my file uploads class. The file goes through but doesn't get uploaded to my uploads directory.

upload.class.php

<?php

ini_set('post_max_size' , '550m');
ini_set('upload_max_filesize' , '550m');
ini_set('file_uploads' , '1');


class upload
{
    const MAX_SIZE ="150000";

private static $file_name;

private static $file_type;

private static $file_size;

private static $file_tmp;

private static $file_errors;

private static $directory;

private static $allowed_types=array("application/arj",
                           "application/excel",
                           "application/gnutar",
                           "application/mspowerpoint",
                           "application/msword",
                           "application/octet-stream",
                           "application/onenote",
                           "application/pdf",
                           "application/plain",
                           "application/postscript",
                           "application/powerpoint",
                           "application/rar",
                           "application/rtf",
                           "application/vnd.ms-excel",
                           "application/vnd.ms-excel.addin.macroEnabled.12",
                           "application/vnd.ms-excel.sheet.binary.macroEnabled.12",
                           "application/vnd.ms-excel.sheet.macroEnabled.12",
                           "application/vnd.ms-excel.template.macroEnabled.12",
                           "application/vnd.ms-office",
                           "application/vnd.ms-officetheme",
                           "application/vnd.ms-powerpoint",
                           "application/vnd.ms-powerpoint.addin.macroEnabled.12",
                           "application/vnd.ms-powerpoint.presentation.macroEnabled.12",
                           "application/vnd.ms-powerpoint.slide.macroEnabled.12",
                           "application/vnd.ms-powerpoint.slideshow.macroEnabled.12",
                           "application/vnd.ms-powerpoint.template.macroEnabled.12",
                           "application/vnd.ms-word",
                           "application/vnd.ms-word.document.macroEnabled.12",
                           "application/vnd.ms-word.template.macroEnabled.12",
                           "application/vnd.oasis.opendocument.chart",
                           "application/vnd.oasis.opendocument.database",
                           "application/vnd.oasis.opendocument.formula",
                           "application/vnd.oasis.opendocument.graphics",
                           "application/vnd.oasis.opendocument.graphics-template",
                           "application/vnd.oasis.opendocument.image",
                           "application/vnd.oasis.opendocument.presentation",
                           "application/vnd.oasis.opendocument.presentation-template",
                           "application/vnd.oasis.opendocument.spreadsheet",
                           "application/vnd.oasis.opendocument.spreadsheet-template",
                           "application/vnd.oasis.opendocument.text",
                           "application/vnd.oasis.opendocument.text-master",
                           "application/vnd.oasis.opendocument.text-template",
                           "application/vnd.oasis.opendocument.text-web",
                           "application/vnd.openofficeorg.extension",
                           "application/vnd.openxmlformats-officedocument.presentationml.presentation",
                           "application/vnd.openxmlformats-officedocument.presentationml.slide",
                           "application/vnd.openxmlformats-officedocument.presentationml.slideshow",
                           "application/vnd.openxmlformats-officedocument.presentationml.template",
                           "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet",
                           "application/vnd.openxmlformats-officedocument.spreadsheetml.template",
                           "application/vnd.openxmlformats-officedocument.wordprocessingml.document",
                           "application/vnd.openxmlformats-officedocument.wordprocessingml.document",
                           "application/vnd.openxmlformats-officedocument.wordprocessingml.template",
                           "application/vocaltec-media-file",
                           "application/wordperfect",
                           "application/x-bittorrent",
                           "application/x-bzip",
                           "application/x-bzip2",
                           "application/x-compressed",
                           "application/x-excel",
                           "application/x-gzip",
                           "application/x-latex",
                           "application/x-midi",
                           "application/xml",
                           "application/x-msexcel",
                           "application/x-rar-compressed",
                           "application/x-rtf",
                           "application/x-shockwave-flash",
                           "application/x-sit",
                           "application/x-stuffit",
                           "application/x-troff-msvideo",
                           "application/x-zip",
                           "application/x-zip-compressed",
                           "application/zip",
                           "audio/*",
                           "image/jpg",
						   "image/jpeg",
						   "image/png",
						   "image/gif",
                           "multipart/x-gzip",
                           "multipart/x-zip",
                           "text/plain",
                           "text/rtf",
                           "text/richtext",
                           "text/xml",
                           "video/*");


public static function upload_file($filenames)
{
	if($_FILES['userfile']['error']==0)
	{
		self::$file_name = $filenames;
	}

	return self::$file_name;
}

public static function is_allowed_type($filetypes)
{
    echo $filetypes;

	if($_FILES['userfile']['error']== 0 && in_array($filetypes , self::$allowed_types))
	{
		self::$file_type = $filetypes;
	}

	else
	{
		throw new Exception('File Type Is Not An Allowed Type Please Only Upload Files that are Allowed Types');
	}

	return self::$file_type;
}

public static function is_allowed_size($filesizes)
{
	if($filesizes < self::MAX_SIZE)
	{
		self::$file_size = $filesizes;
	}

	elseif($filesizes > self::MAX_SIZE )
	{
		throw new Exception('Fatal Error Filesize is to large');
	}

	return self::$file_size;
}

public static function upload_dir($destination)
{
	if($destination == 'defualt' && file_exists('uploads'))
	{
		self::$directory = '/uploads';
	}

	elseif($destination != 'defualt' && file_exists($destination))
	{
		self::$directory = $destination;
	}

	elseif($destination !='defualt' && !file_exists($destination))
	{
		throw new Exception('Fatal Upload Error Directory Does not Exsist');
	}

	return self::$directory;
}

public static function upload_error($fileerror)
{
	if($_FILES['userfile']['error'] != 0)
	{
		trigger_error('Fatal File Upload Error Type:'. print_r($_FILES['error']));
	}
}

public static function file_uploaded($filetmpname)
{
	if(is_uploaded_file($filetmpname))
	{
		self::$file_tmp = $filetmpname;
		move_uploaded_file(self::$file_name , self::$directory);
	}

	return self::$file_tmp;
}



}

functions

include('upload.class.php');

$upload = new upload;

$upload->upload_file($_FILES['userfile']['name']);
$upload->is_allowed_type($_FILES['userfile']['type']);
$upload->is_allowed_size($_FILES['userfile']['size']);
$upload->upload_error($_FILES['userfile']['error']);
$upload->upload_dir('defualt');
$upload->file_uploaded($_FILES['userfile']['tmp_name']);

dagon

check what move_uploaded_file() returns it is probably a directory\permission error. I always specify full server path rather than relative it reduces the changes of stuffing it up.

jgetner

bool(false) if i did it right? var_dump? never dumped a function always used a custom conditional.

also the uploads directory is in the same dierctory as the upload and functions.
also i'am on windows so permissions should not be a concern.

dagon

well it failed, upload path correct? permissions correct?

jgetner

i will check it with the absolute path? i'am on windows so permissions should not be a concern.

Failed With absolute path aswell?

jgetner

problem resolved.

forgot 2 things on move_uploaded_file() first i had the file name where the tmp_name goes and also forgot to place the filename inside the uplaods directory.

bartzz

I don't think that you can change

ini_set('post_max_size' , '550m');
ini_set('upload_max_filesize' , '550m');
ini_set('file_uploads' , '1');

Trough ini_set but i am for 100% sure you can change post_max_size trough ini_set()

bradgrafelman

bartzz;10963638 wrote:
I don't think that you can change

ini_set('post_max_size' , '550m');
ini_set('upload_max_filesize' , '550m');
ini_set('file_uploads' , '1');

Trough ini_set but i am for 100% sure you can change post_max_size trough ini_set()

None of those three directives can be changed using ini_set() - they must be changed before the script is executed (e.g. via a .htaccess or php.ini file) as noted in the appendix: [man]ini.list[/man].

bartzz

Just like as i thought... If your post_max_size is for example 64 M and you post 65 M file it will ignore it and even if you try to echo $_FILES["name"]["yourfile"] it will return nothing...

jgetner

Hmm i did not know that thanks guys i spent all yesterday looking how to change and my best guess was set it in ini.

i will try the .htaccess method.

also how the hell do you allow .zip and .rar files to upload?

using the php zip functions?

bartzz

Well... You don't really have to use that HUGE array.. use this..

if (in_array(strtolower(substr($_FILES["file"]["yourfile"], -4, 4)), array(".zip", ".rar")) && ($_FILES["file"]["yourfile"] < YOUR__LIMIT_IN_BYTES_HERE))

I use:

if (in_array(strtolower(substr($_FILES["file"]["name"], -4, 4)), array(".zip", ".rar")) && ($_FILES["file"]["size"] < 99999999))

  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
    }
  else
    {
	if (file_exists("upload/" . $_FILES["file"]["name"]))
      {
      echo $_FILES["file"]["name"] . " already exists. ";
      }
    else
      {
      move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $uniqid_once . "_" . $_FILES["file"]["name"]);
      }
    }
  }

Works fine for me 🙂