Mail Function Issues

[mbonbon]

Hi All,

I'm just starting out with PHP so this is all a little confusing still. I'm trying to make a mail form, and have gone through several issues, mostly getting the emails to send, but they finally are sending, but now they are blank, or rather the input values are missing.

I'm using Godaddy as a host and a Linux server, I figured I'd add that.

This is the HTML code:

<h1>Contact</h1>
   <form action="sendmail.php" method="post">
Your Name:<br  />
<input type="text" name="name" /><br /><br  />
Your E-mail Address:<br  />
<input type="text" name="email" /><br /><br  />
Your Phone Number:<br  />
<input type="text" name="phone" /><br /><br  />
Message:<br />
<textarea class="message"></textarea><br />
<br /><br  />
<input type="submit" value="Send">
<input type="reset" value="Reset">

</form>
         

This is the original php I used:

<?php
  $email = $_REQUEST['email'] ;
  $message = $_REQUEST['message'] ;
  $name = $_REQUEST['name'] ;
  $phone = $_REQUEST['phone'] ;
  $totalmessage = "
		Name:		$name  \n
		Phone:		$phone  \n
		Message:	$message \n";

  mail( "[e-mail]", "Contact Drew Message", $totalmessage, "From: $email"  );
  header( "Location: http://www.dhlevinson.com/thankyou.html" )
 ?>

I was consistently getting blank emails or well they would actually say:
Name:
Phone:
Message:

but without any of the values.

I had originally thought that this was a php issue, but then I added this check (see code below) and now when I fill out the form to test I'm getting the contact (the page that the form is one) page over and over again, which I'm guessing means that the values aren't registering when I put them in.

Here is the revised php code:

<?php
  $email = $_REQUEST["email"] ;
  $message = $_REQUEST["message"] ;
  $name = $_REQUEST["name"] ;
  $phone = $_REQUEST["phone"] ;
  $totalmessage = "
                Name: $name\n 
                Phone: $phone\n
		Message: $message \n";

if (!isset($_REQUEST["email"])) {
    header( "Location: http://dhlevinson.com/contact.html" );
  }
  elseif (empty($email) || empty($message)) {
    header( "Location: http://dhlevinson.com/error.html" );
  }
  else {
  mail( "[e-mail]", "Contact Drew Message", $totalmessage, "From: $email"  );

  header( "Location: http://www.dhlevinson.com/thankyou.html" );
}
 ?>

I'm not even sure this is a php issue, it might be an issue with the html of the form, but I figured I'd give this thread a shot as I'm completely stumped with this.

Thank you in advance to anyone who replies!

[NogDog]

I would suggest turning on all error messages at the start of the form-handler script to help locate the problem:

<?php
ini_set('display_errors', 1); // set to 0 for production version
error_reporting(E_ALL);
/* ...rest of script... */
?>

Also, since your form is using the POST method, I'd suggest using $POST instead of $REQUEST, as it's normally best to use the more specific array when there is not reason to use the less specific one. For debugging, you can test to see what values were received from the form via:

<?php
echo "<pre>" . print_r($_POST, true) . "</pre>";

[mbonbon]

Thank you, NogDog I did as you suggested and now I'm getting the following:

Notice: Undefined index: email in /home/content/d/h/l/dhlevinson/html/sendmail.php on line 5

Notice: Undefined index: message in /home/content/d/h/l/dhlevinson/html/sendmail.php on line 6

Notice: Undefined index: name in /home/content/d/h/l/dhlevinson/html/sendmail.php on line 7

Notice: Undefined index: phone in /home/content/d/h/l/dhlevinson/html/sendmail.php on line 8

I just looked and I'm using all the right names from the form. Is there something wrong with the way I'm defining them?