Upload and Thumbnail (thumbnail script issues)

[Jane_Smith]

Hi,

I am trying to do a script to upload a photo, save the original and create a thumbnail. The upload original works correctly it is just the thumbnail that doesn't.

I have included in here comments of what I think I am doing to maybe help understand where I am going wrong.

<?php
	$con = mysql_connect("localhost","user","password");
	if (!$con){
		die('Could not connect: ' . mysql_error());
		}

mysql_select_db("mydb", $con);

function findexts ($filename){
$filename= strtolower($filename);
$exts = split("[/\\.]",$filename);
$n = count($exts)-1;
$exts = $exts[$n];
return $exts;
}
$ext = findexts ($_FILES['file']['name']);
$ran = rand() . rand();
$ran2 = $ran.".";

if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
&& ($_FILES["file"]["size"] < 2500000))	{
	if ($_FILES["file"]["error"]>0)	{
		echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
		}
	else {
		//echo "Upload: " . $_FILES["file"]["name"] . "<br />";
		//echo "Type: " . $_FILES["file"]["type"] . "<br />";
		//echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
		//echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

	if (file_exists("upload/" . $_FILES["file"]["name"])){
		echo $_FILES["file"]["name"] . " already exists. ";
		}
	else {
		move_uploaded_file($_FILES["file"]["tmp_name"],
		"upload/" . $ran2.$ext);
		echo "Stored in: " . "upload/" . $ran2.$ext;
		$target = "upload/$ran2$ext";
		}
	}
}
else {
	echo "The file you are trying to load is invalid, please check it is under 2.5Mb and has a JPEG, PJPEG or GIF extension";
	}

//make a copy of the image to another name
copy("$target","$image");
//create a temporary file with this data
$handle = $image;
//get the contents of this file
$filestring = file_get_contents($thumbfile);

//create a new image pallette from the string
$imageTmp=imageCreateFromString($filestring);

//resize the image pallette
function resizeImage ($imageTmp,500,500){
list($width,$height) = getimagesize($imageTmp);
	$xscale=$width/$toWidth;
	$yscale=$height/$toHeight;

if($yscale>$xscale){
	$new_width = round($width * (1/$yscale));
	$new_height = round($height * (1/$yscale));
}else{
	$new_width = round($width * (1/$xscale));
	$new_height = round($height * (1/$xscale));
}

//create a true color image ie a complete image with above parameters
	$imageResized = imageCreateTrueColor($imageTmp,$new_width, $new_height);
($imageResized, $imageTmp, 0,0, 0, 0, $new_width, $new_height, $width, $height);


//change this back into a readable file and save in directory
			fwrite($imageResized,"thumbs/".$ran2ext);
			echo "Stored in: " . "thumbs/" . $ran2.$extthumb;


?>

[NogDog]

First thing I saw that looks suspicious is:

$filestring = file_get_contents($thumbfile); 

I don't see where $thumbfile is defined/set. In any case, all this file copying and getting seems a bit unnecessary, as you can load an image directly from the source file via the applicable imagecreatefromimage_type functions. What I normally do is get the image type via getimagesize(), then use that in a switch, something like:

$attrs = @getimagesize($imgFile);
$src = false;
if($attrs !== false) {
   switch($attrs[2]) {
      case IMAGETYPE_JPEG:
         $src = @imagecreatefromjpeg($imgFile);
         break;
      case IMAGETYPE_PNG:
         $src = @imagecreatefrompng($imgFile);
         break;
      case IMAGETYPE_GIF:
         $src = @imagecreatefromgif($imgFile);
         break;
      default:
         // whatever you want to do if invalid image type
   }
}
if($src === false) {
   // unable to read/parse image file
}

[Jane_Smith]

You are right it should be $image not $thumbfile.

How does your code fit in with copying and resizing? Sorry I am quite new to this and don't automatically understand what all the code is doing.

[NogDog]

Jane Smith;10965732 wrote:

You are right it should be $image not $thumbfile.

How does your code fit in with copying and resizing? Sorry I am quite new to this and don't automatically understand what all the code is doing.

Here's the entire function where I was using that code:

/**
* Resize image to specific dimension, cropping as needed
* @return resource Resized image resource, or boolean false on failure
* @param string $imgFile Path to image to be resized
* @param int $width
* @param int $height
* @param string $error Error message
*/
function resize($imgFile, $width, $height, &$error = null)
{
   $attrs = @getimagesize($imgFile);
   if($attrs == false)
   {
      $error = "Uploaded file does not appear to be an image.";
      return false;
   }
   if($attrs[0] * $attrs[1] > 3000000)
   {
      $error = "Max pixels allowed is 3,000,000. Your {$attrs[0]} x " .
               "{$attrs[1]} image has " . $attrs[0] * $attrs[1] . " pixels.";
      return false;
   }
   $ratio = (($attrs[0] / $attrs[1]) < ($width / $height)) ?
            $width / $attrs[0] : $height / $attrs[1];
   $x = max(0, round($attrs[0] / 2 - ($width / 2) / $ratio));
   $y = max(0, round($attrs[1] / 2 - ($height / 2) / $ratio));
   switch($attrs[2]) {
      case IMAGETYPE_JPEG:
         $src = @imagecreatefromjpeg($imgFile);
         break;
      case IMAGETYPE_PNG:
         $src = @imagecreatefrompng($imgFile);
         break;
      case IMAGETYPE_GIF:
         $src = @imagecreatefromgif($imgFile);
         break;
      default:
         $error = "File is not a JPEG, PNG, or GIF image";
         return false;
   }
   if($src == false)
   {
      $error = "An error occurred processing the file, it may have been corrupted.";
      return false;
   }
   $resized = imagecreatetruecolor($width, $height);
   $result = imagecopyresampled($resized, $src, 0, 0, $x, $y, $width, $height,
             round($width / $ratio, 0), round($height / $ratio));
   if($result == false)
   {
      $error = "Error trying to resize and crop image.";
      return false;
   }
   else
   {
      return $resized;
   }
}

You might need to change the logic for the resizing, but it should give you some idea. Basic usage would be:

$imageResized = resize($_FILES["file"]["tmp_name"], $width, $height, $error);
if($resizedImage == false) {
   echo $error; // or whatever you want to do
} else {
   fwrite($imageResized,"thumbs/".$ran2ext);
}