Getting last subcategory in category

mattastic

Hi Folks,

I'm trying to output my query results.

<h2>catname</h2>
<ul>
<li>productTypeName</li> etc etc
</ul>

But I cant find the last of the productTypeName for each cat to close the list.

Can anyone please help?

I have some code below:

 
$query="SELECT *
FROM productCat
INNER JOIN productType ON productCat.productCattype = productType.productTypeId ORDER BY catid";
    $result = mysql_query($query);

<?php
while($row = mysql_fetch_array($result)){


if ($cur_catid != $row['productTypeId']){ //first record in this category
echo "<h2>" . $row['productTypeName'] . "</h2><ul>";
}
echo "" .  $row['CatName']  . "</li>";




$cur_catid = $row['productTypeId'];

if ($cur_catid != $row['productTypeId']){ //try to find last in list to close tag
echo "</ul>";
}



}
?>

cretaceous

for a start you are not outputting the <li> starting tag

echo "<li>" . $row['CatName'] . "</li>";

and why bother looking for the last item?
just echo </ul> after your while statement completes - (i.e just below the last closing curly bracket)

mattastic

Thanks for your reply

do you mean like this:

 <?php
while($row = mysql_fetch_array($result)){


if ($cur_catid != $row['productTypeId']){ //first record in this category
echo "<h2>" . $row['productTypeName'] . "</h2><ul>";
}



echo "<li>" .  $row['CatName']  . "</li>";


}

echo "</ul>";


?>

Still not quite right, it generates this:

<h2></h2>
<ul>
<li></li>
<li></li>
<li></li>
<li></li>
<li></li>
<li></li>
<li></li>
<li></li>
<li></li>
<h2></h2>
<ul>
<li></li>
<li></li>
<li></li>
<li></li>
<li></li>
<h2></h2>
<ul>
<li></li>
<li></li>
<h2></h2>
<ul>
  <li></li>
  <li></li>
  <li></li>
  <li></li>
</ul>

Thanks again

cretaceous

ok sorry about that last note - you must have another loop somewhere - better show all your code

cretaceous

actually I am correct - you need to follow what I said -
you have removed this line:

$cur_catid = $row['productTypeId'];

put it back where it was !

mattastic

Thanks very much for your reply, really appreciate it.

However I'm a bit lost now.

I think I'm doing what you said right, here is my code:


 <?php
while($row = mysql_fetch_array($result)){


if ($cur_catid != $row['productTypeId']){ //first record in this category
echo "<h2>" . $row['productTypeName'] . "</h2><ul>";
}

echo "<li>" .  $row['CatName']  . "</li>";

$cur_catid = $row['productTypeId']; //I've put this back



}

echo "</ul>";   // echo just below the last closing curly bracket?!


?>

It does'nt seem to close of each UL tag still,

Really sorry for not understanding properly, thanks again for your reply

cretaceous

should be ok now... can you say what is wrong or show something?

you should be seeing this structure:

<h2>prodname</h2>
<ul>
  <li>catname1</li>
  <li>catname2</li>
  <li>catname3</li>
  <li>catname4</li>
</ul>

do you have other lists being generated on the page at the same time?

mattastic

Thanks for your reply.

This is my fault I didn't explain myself properly.

I have 4 lists in total I would like to loop through the below recordset, for each productTypeName, I ould like to display the catgory, so it should look like:

<h2>Aluminium<h2>
<ul>
<li>angels</li>
etc etc
</ul>
<h2>Stainless Steel<h2>
<ul>
<li>Flat Bar</li>
etc etc
</ul>

catID     CatName     catImage     productCatType     productTypeId     productTypeName
1     Angles           1     1     Aluminium
2     Flat Bar           1     1     Aluminium
3     Round Bar           1     1     Aluminium
4     Square Bar           1     1     Aluminium
5     Box Section           1     1     Aluminium
6     Channel           1     1     Aluminium
7     Chequer Plate     5 Bar Chequer Plate.jpg     1     1     Aluminium
8     Round Tube           1     1     Aluminium
9     Square Tube           1     1     Aluminium
10     Flat Bar           4     4     Stainless Steel
11     Round Bar           4     4     Stainless Steel
12     Square Bar           4     4     Stainless Steel
13     Polished Sheet           4     4     Stainless Steel
14     Plain Sheet           4     4     Stainless Steel
15     Acetal Round Bar           3     3     Plastic
16     End Caps for Tubes           3     3     Plastic
17     Flat Bar           2     2     Brass
18     Round Bar           2     2     Brass
19     Square Bar           2     2     Brass
20     Sheet           2     2     Brass

cretaceous

I think you need to do
unset ($cur_catid) ;
after each list has finished

otherwise the second and later lists are never showing a heading or a <ul> opening tag

try

echo "</ul>";  // leave this as it is
//and right after that add
unset($cur_catid);