Cascading Dropdown / Sticky Textbox

zooropa

Dear All,
Here is my latest woeful effort : )

I have 3 dependent dropdowns (continent / country / city)
If I select a continent, relevant countries are displayed in the country dropdown
If I select a country, relevant cities are displayed in the city dropdown
I also have a 'sticky' text box

All well and good!

My problems are twofold

(1) If I decide to change the continent selection, the country dropdown defaults to its "select country" value (which i want) but the city dropdown does not (but i want it to)

(2) I want the textbox to be empty and the dropdowns to revert to their default values "select continent", "select country" and "select city" when the Submit button is clicked but not when the autosubmit() function is called when dropdown values are selected / changed. I just don't know how to achieve this.

If you're guessing that my HTML, Javascript and PHP skills are ropey, you guessed right. Thankfully I have you guys to help but i'm keen and learning all the time.

<html>
<body >
<?php
require_once('mysqli_connect.php');

$country = $city = $continent = null; //declare vars

if(isset($_GET["continent"]) && is_numeric($_GET["continent"]))
{
    $continent = $_GET["continent"];
}

if(isset($_GET["country"]) && is_numeric($_GET["country"]))
{
    $country = $_GET["country"];
}

if(isset($_GET["city"]) && is_numeric($_GET["city"]))
{
    $city = $_GET["city"];
}


?>

<script language="JavaScript">

function autoSubmit()
{
    var formObject = document.forms['theForm'];
    formObject.submit();
}

</script>


<form name="theForm" method="get" action="start_fdd_lot.php">


<input type="text" name="some_text" value="<?php if (isset($_REQUEST['some_text'])) echo $_REQUEST['some_text']; ?>" />



<select name="continent" onChange="autoSubmit();">

    <option value="null">select continent</option> 


    <?php
    $q1 = "SELECT continent_id, continent FROM tbl_continent ";
    $s1 = mysqli_query($dbc,$q1);

    while($row = mysqli_fetch_array($s1))
    {        
        echo ("<option value=\"$row[continent_id]\" " . ($continent == $row["continent_id"] ? " selected" : "") . ">$row[continent]</option>");        
    }
    ?>

</select>




<select name="country" onChange="autoSubmit();">

    <option value="null">select country</option>  

     <?php
    $q2 = "SELECT country_id, country FROM tbl_country WHERE (continent_id = $continent)  ";
    $s2 = mysqli_query($dbc,$q2);

    while($row = mysqli_fetch_array($s2))
    {        
        echo ("<option value=\"$row[country_id]\" " . ($country == $row["country_id"] ? " selected" : "") . ">$row[country]</option>");        
    }
    ?>

</select>

<select name="city" onChange="autoSubmit();">

   <option value="null">select city</option> 

    <?php        
    $q3 = "SELECT city_id, city FROM tbl_city WHERE (country_id = $country)  ";
    $s3 = mysqli_query($dbc,$q3);

    while($row = mysqli_fetch_array($s3))
    {
        echo ("<option value=\"$row[city_id]\" " . ($city == $row["city_id"] ? " selected" : "") . ">$row[city]</option>");        
    }
    ?>    

</select>    


<input type="submit" name="button" id="button" value="Submit" />
<input type="hidden" name="submitted" value="TRUE" />


</form>
</body>
</html>

johanafm

I'd do something like what you can see below. Do note that there is code repetition, such as creating the html code for the continent select element, in the various if/else blocks that should be wrapped in functions to remove the code repetition. And you will have to modify the code to actually retrieve data from a database.

<!-- script elements do not have a language attribute.
	also, for elements that do have a language attribute, the values are limited
	to natural languages: en, us-en, fr etc.
    But scripts elements do have a required type attribute, which should be
    text/javascript in this case -->
<script type="text/javascript">
function select_changed(o) {
	if (o.value != 0) {
		o.parentNode.parentNode.submit();
	}
}
</script>
</head>
<body>
<?php
# SQL query to retrieve all continents
$continents = array(1 => 'North America', 2 => 'Europe');

# all selections done
if (isset($_GET['submit_btn'])) {
	# will be 0 if $_GET['continent'] doesn't start with numbers
	$continent = (int) $_GET['continent'];
	$country = (int) $_GET['country'];
	$city = (int) $_GET['city'];

# do whatever you need to with selection
echo '<h4>You selected</h4><ul>';
echo "\t<li>$continent</li>\n\t<li>$country</li>\n\t<li>$city</li>\n<ul>\n";

# exactly the same as when nothing has been selected, i.e. base look of form
$continent_select = 
'<select name="continent" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	foreach($continents as $k => $v) {
		$continent_select .=
"\n\t<option value='$k'>$v</option>";
	}
	$continent_select .= "\n</select>";

$country_select = $city_select = '';
}
# continent and country selected
elseif (isset($_GET['country'])) {
	# will be 0 if $_GET['continent'] doesn't start with numbers
	$continent = (int) $_GET['continent'];
	$country = (int) $_GET['country'];

$continent_select = 
'<select name="continent" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	foreach ($continents as $k => $v) {
		$continent_select .=
"\n\t<option value='$k'". ($continent == $k ? ' selected="selected"' : '') .">$v</option>";
	}
	$continent_select .= "\n</select>";

# SQL query to retrieve countries for selected continent
$all_countries = array(	1 => array(1 => 'USA', 2 => 'Canada'),
					2 => array(1 => 'UK', 2 => 'France'));
$countries = $all_countries[$continent];
# End of SQL query

$country_select =
'<select name="country" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	foreach ($countries as $k => $v) {
		$country_select .=
"\n\t<option value='$k'". ($country == $k ? ' selected="selected"' : '') .">$v</option>";
	}
	$country_select .= "\n</select>";

# SQL query to retrieve cities for selected country
$all_cities = array(	1 => array( 1 => array(1 => 'New York', 2 => 'Orlando'),
									2 => array(1 => 'Ottawa', 2 => 'Vancouver')),
						2 => array(	1 => array(1 => 'London', 2 => 'Dublin'),
									2 => array(1 => 'Paris', 2 => 'Cannes')));
$cities = $all_cities[$continent][$country];
# End of SQL query

$city_select =
'<select name="city">
	<option value="0">Please select...</option>';
	foreach ($cities as $k => $v) {
		$city_select .=
"\n\t<option value='$k'>$v</option>";
	}
	$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>";
}
# only continent selected
elseif (isset($_GET['continent'])) {
	# will be 0 if $_GET['continent'] doesn't start with numbers
	$continent = (int) $_GET['continent'];

$continent_select = 
'<select name="continent" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	foreach ($continents as $k => $v) {
		$continent_select .=
"\n\t<option value='$k'". ($continent == $k ? ' selected="selected"' : '') .">$v</option>";
	}
	$continent_select .= "\n</select>";

# SQL query to retrieve countries for selected continent
$all_countries = array(	1 => array(1 => 'USA', 2 => 'Canada'),
					2 => array(1 => 'UK', 2 => 'France'));
$countries = $all_countries[$continent];
# End of SQL query

$country_select =
'<select name="country" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	foreach ($countries as $k => $v) {
		$country_select .=
"\n\t<option value='$k'>$v</option>";
	}
	$country_select .= "\n</select>";

$city_select = '';
}
# nothing selected
else {
	$continent_select = 
'<select name="continent" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	foreach($continents as $k => $v) {
		$continent_select .=
"\n\t<option value='$k'>$v</option>";
	}
	$continent_select .= "\n</select>";

$country_select = $city_select = '';
}
?>
	<form action="" method="get">
		<div>
<?php
	echo $continent_select . PHP_EOL;
	echo $country_select . PHP_EOL;
	echo $city_select . PHP_EOL;
?>
		</div>
	</form>

zooropa

Hi Johanafm,
Thanks again for your reply. My first impression on seeing your code was to think that i've got no chance of understanding it - it's probably way too well written for a Newbie like me to understand. I was hoping for some minor modifications to my version (maybe not elegant but at least i'd be able to follow it). I thought i'd try to see if at least i could get your suggestion to work but came unstuck fairly quickly with the following message:

Warning: Invalid argument supplied for foreach() in C:\InetPub\wwwroot\test\myexample.php on line 106

I have 3 tables:

tbl_continent (continent_id, continent)
tbl_country (country_id, continent_id, country)
tbl_city (city_id, country_id, city)

and my version of the script you supplied (i stripped out the comment lines, added missing <html> and <body> tags and replaced several ines with what i thought the queries on the tables should be):

<html>
<head>
<script type="text/javascript">
function select_changed(o) {
if (o.value != 0) {
o.parentNode.parentNode.submit();
}
}
</script>

</head>
<body>
<?php

$continents = "SELECT continent_id, continent FROM tbl_continent ";

if (isset($_GET['submit_btn'])) {

$continent = (int) $GET['continent'];
$country = (int) $GET['country'];
$city = (int) $_GET['city'];

$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';
foreach($continents as $k => $v) {
$continent_select .=
"\n\t<option value='$k'>$v</option>";
}
$continent_select .= "\n</select>";

$country_select = $city_select = '';
}

elseif (isset($_GET['country'])) {

$continent = (int) $GET['continent'];
$country = (int) $GET['country'];

$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';
foreach ($continents as $k => $v) {
$continent_select .=
"\n\t<option value='$k'". ($continent == $k ? ' selected="selected"' : '') .">$v</option>";
}
$continent_select .= "\n</select>";

$all_countries = "SELECT country_id, country FROM tbl_country";
$countries = $all_countries[$continent];

$country_select =
'<select name="country" onchange="select_changed(this);">
<option value="0">Please select...</option>';
foreach ($countries as $k => $v) {
$country_select .=
"\n\t<option value='$k'". ($country == $k ? ' selected="selected"' : '') .">$v</option>";
}
$country_select .= "\n</select>";

$all_cities = "SELECT city_id, city FROM tbl_city";
$cities = $all_cities[$continent][$country];

$city_select =
'<select name="city">
<option value="0">Please select...</option>';
foreach ($cities as $k => $v) {
$city_select .=
"\n\t<option value='$k'>$v</option>";
}
$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>";
}
elseif (isset($_GET['continent'])) {

$continent = (int) $_GET['continent'];
$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';
foreach ($continents as $k => $v) {
$continent_select .=
"\n\t<option value='$k'". ($continent == $k ? ' selected="selected"' : '') .">$v</option>";
}
$continent_select .= "\n</select>";

$all_countries = "SELECT * FROM tbl_country";
$countries = $all_countries[$continent];

$city_select = '';
}

else {
$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';
foreach($continents as $k => $v) {
$continent_select .=
"\n\t<option value='$k'>$v</option>";
}
$continent_select .= "\n</select>";

$country_select = $city_select = '';
}
?>
<form action="" method="get">
<div>
<?php
echo $continent_select . PHP_EOL;
echo $country_select . PHP_EOL;
echo $city_select . PHP_EOL;
?>
</div>
</form>

Thanks

johanafm

Please wrap your code in [ php] tags, [ html] tags or if neither is appropriate, code tags since reading it is otherwise unbearable. Also, when php reports an error, notice or similar, please indicate which line that is in the posted code.

So, without looking at your code, I'd guess you are still using my mock data arrays (for countries, continents and cities) rather than result set resources retrieved from your database.

zooropa

Hi Johanafm,
Sorry for not including tags. I see what you mean about being difficult to read. I am not using your moch data arrays but replaced them with what i thought the queries should be. Tagged code shown below.

Warning: Invalid argument supplied for foreach() in C:\InetPub\wwwroot\test\myexample.php on line 106

I have 3 tables:

tbl_continent (continent_id, continent)
tbl_country (country_id, continent_id, country)
tbl_city (city_id, country_id, city)

and my version of the script you supplied (i stripped out the comment lines, added missing <html> and <body> tags and replaced several ines with what i thought the queries on the tables should be):

 <html>
<head>
<script type="text/javascript"> 
function select_changed(o) { 
if (o.value != 0) { 
o.parentNode.parentNode.submit(); 
} 
} 
</script> 

</head> 
<body>

 

<?php 

$continents = "SELECT continent_id, continent FROM tbl_continent "; 

if (isset($_GET['submit_btn'])) { 

$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 
$city = (int) $_GET['city']; 

$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
foreach($continents as $k => $v) { 
$continent_select .= 
"\n\t<option value='$k'>$v</option>"; 
} 
$continent_select .= "\n</select>"; 

$country_select = $city_select = ''; 
} 

elseif (isset($_GET['country'])) { 

$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 

$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
foreach ($continents as $k => $v) { 
$continent_select .= 
"\n\t<option value='$k'". ($continent == $k ? ' selected="selected"' : '') .">$v</option>"; 
} 
$continent_select .= "\n</select>"; 



$all_countries = "SELECT country_id, country FROM tbl_country"; 
$countries = $all_countries[$continent]; 

$country_select = 
'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
foreach ($countries as $k => $v) { 
$country_select .= 
"\n\t<option value='$k'". ($country == $k ? ' selected="selected"' : '') .">$v</option>"; 
} 
$country_select .= "\n</select>"; 

$all_cities = "SELECT city_id, city FROM tbl_city"; 
$cities = $all_cities[$continent][$country]; 

$city_select = 
'<select name="city"> 
<option value="0">Please select...</option>'; 
foreach ($cities as $k => $v) { 
$city_select .= 
"\n\t<option value='$k'>$v</option>"; 
} 
$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>"; 
} 
elseif (isset($_GET['continent'])) { 

$continent = (int) $_GET['continent']; 
$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
foreach ($continents as $k => $v) { 
$continent_select .= 
"\n\t<option value='$k'". ($continent == $k ? ' selected="selected"' : '') .">$v</option>"; 
} 
$continent_select .= "\n</select>"; 

$all_countries = "SELECT * FROM tbl_country"; 
$countries = $all_countries[$continent]; 

$country_select = 
'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
foreach ($countries as $k => $v) { 
$country_select .= 
"\n\t<option value='$k'>$v</option>"; 
} 
$country_select .= "\n</select>"; 

$city_select = ''; 
} 

else { 
$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
foreach($continents as $k => $v) { 
$continent_select .= 
"\n\t<option value='$k'>$v</option>"; 
} 
$continent_select .= "\n</select>"; 

$country_select = $city_select = ''; 
} 
?>

 
<form action="" method="get"> 
<div>

 
<?php 
echo $continent_select . PHP_EOL; 
echo $country_select . PHP_EOL; 
echo $city_select . PHP_EOL; 
?>

 
</div> 
</form> 

<body>
<html>

johanafm

Ah, you still have some work to do with remaining stuff from my mock data

# When you assigned a string containing a SQL query to this variable, it contained
# a string, not an array (and not a mysqli result set resource either)
$all_countries = array('mock data');
# which made $countries contain a string of one character; the character being
# the one at offset $continent into the string
$countries = $all_countries[$continent];

# which is why the foreach loop complained about not getting an array

should be turned into

# All countries are never needed (you have those in your database)
# You only ever retrieve countries for the selected continent

# This part is nothing but a string that means nothing special to PHP - it could contain anything
$query = "SELECT country_id, country FROM tbl_country WHERE continent_id = " . $continent;

# Get a result set resource by sending the above string to the database
$countries = mysqli_query($dbc, $query);

# To use the result set resource, replace the foreach ($countries as $country) with
while ($country = mysqli_fetch_assoc($countries))

zooropa

Hi Johanafm,
Below is my latest attempt - still probably some way off from working but i have attempted (without really understanding a lot of it) to adapt the script as per your suggestions:

I'm getting the following errors:

Notice: Undefined variable: continents in C:\InetPub\wwwroot\test\start_fdd_lot4.php on line 110

Warning: mysqli_fetch_assoc() expects parameter 1 to be mysqli_result, null given in C:\InetPub\wwwroot\test\start_fdd_lot4.php on line 110

but at least i'm getting one Dropdown box containing the words "Array" twice

 
<html>
<head>
<script type="text/javascript"> 
function select_changed(o) { 
if (o.value != 0) { 
o.parentNode.parentNode.submit(); 
} 
} 
</script> 

</head> 
<body>

 
<?php 
require_once('mysqli_connect_dropdown.php');


if (isset($_GET['submit_btn'])) { 

$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 
$city = (int) $_GET['city']; 

$query1 = "SELECT continent_id, continent FROM tbl_continent "; 
$continents=mysqli_query($dbc,$query1);

$query2 = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent; 
$countries=mysqli_query($dbc,$query2);

$query3 = "SELECT city_id, city FROM tbl_city WHERE country_id=".$country; 
$cities = mysqli_query($dbc,$query3);


$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
while ($continent=mysqli_fetch_assoc($continents)){

$continent_select .= 
"\n\t<option value='$continent_id'>$continent</option>"; 
} 
$continent_select .= "\n</select>"; 

$country_select = $city_select = ''; 
} 

elseif (isset($_GET['country'])) { 

$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 

$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
while ($continent=mysqli_fetch_assoc($continents)){

$continent_select .= 
"\n\t<option value='$continent_id'". ($continent == $continent_id ? ' selected="selected"' : '') .">$continent</option>"; 
} 
$continent_select .= "\n</select>"; 


$country_select = 
'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
while ($country=mysqli_fetch_assoc($countries)){ 
$country_select .= 
"\n\t<option value='$country_id'". ($country == $country_id ? ' selected="selected"' : '') .">$country</option>"; 
} 
$country_select .= "\n</select>"; 


$city_select = 
'<select name="city"> 
<option value="0">Please select...</option>'; 
while ($city=mysqli_fetch_assoc($cities)){
$city_select .= 
"\n\t<option value='$city_id'>$city</option>"; 
} 
$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>"; 
} 
elseif (isset($_GET['continent'])) { 

$continent = (int) $_GET['continent']; 
$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
while ($continent=mysqli_fetch_assoc($continents)){
$continent_select .= 
"\n\t<option value='$continent_id'". ($continent == $continent_id ? ' selected="selected"' : '') .">$continent</option>"; 
} 
$continent_select .= "\n</select>"; 

$country_select = 
'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
while ($country=mysqli_fetch_assoc($countries)){ 
$country_select .= 
"\n\t<option value='$country_id'>$country</option>"; 
} 
$country_select .= "\n</select>"; 

$city_select = ''; 
} 

else { 

$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 
while ($continent=mysqli_fetch_assoc($continents)){
$continent_select .= 
"\n\t<option value='$continent_id'>$continent</option>"; 
} 
$continent_select .= "\n</select>"; 

$country_select = $city_select = ''; 
} 
?>

<form action="" method="get"> 
<div>

<?php 
echo $continent_select . PHP_EOL; 
echo $country_select . PHP_EOL; 
echo $city_select . PHP_EOL; 
?>

 
</div> 
</form> 

<body>
<html>

johanafm

Indent your code. Otherwise it's impossible to read. Different indentation styles. It doesn't really matter which you pick (or come up with one of your own). The most important thing is that you do pick one style and stick to it consistently. If you don't write all code alone, you should use the same style as the others.

if (isset($_GET['submit_btn']))
{
	$continent = (int) $_GET['continent'];
	$country = (int) $_GET['country'];
	$city = (int) $_GET['city'];

$query1 = "SELECT continent_id, continent FROM tbl_continent ";
$continents=mysqli_query($dbc,$query1);


$query2 = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent;
$countries=mysqli_query($dbc,$query2);

$query3 = "SELECT city_id, city FROM tbl_city WHERE country_id=".$country;
$cities = mysqli_query($dbc,$query3);


$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';
# You can't use $continent here without overwriting the selected continent from
#			$continent = (int) $_GET['continent']
# While you did not use the value of $continent from above anymore, you really should use it.
# It gives you the ability to have the continent/country/city selected by the user still be
# selected when you present the next page to them
	while ($c=mysqli_fetch_assoc($continents))
	{

	$continent_select .=
	"\n\t<option value='$continent_id'".
	# You must also specify the field you wish to retrieve: $c is an array
	($c['continent_id'] == $continent ? ' selected="selected"' : '') .
	'>'.$c['continent'].'</option>';
}
$continent_select .= "\n</select>";

$country_select = $city_select = '';
}
# Since this is an elseif block, it will NEVER be execute if the above if/elseif block was
# You performed your calls to mysqli_query in the above block, but you do not do that below
# which means that in this case, you have no result sets (reason for the error message)
elseif (isset($_GET['country']))
{
	$continent = (int) $_GET['continent'];
	$country = (int) $_GET['country'];

$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';
# same problem as before with overwriting the value of $continent
# and as describe before this code block, $continents has not been defined
# and will default to null. Thus:
#		Warning: mysqli_fetch_assoc() expects parameter 1 to be mysqli_result,
#		null given in C:\InetPub\wwwroot\test\start_fdd_lot4.php on line 110
# 
# But didn't you also get this E_NOTICE:
#		Undefined variable: continents
while ($continent=mysqli_fetch_assoc($continents))
{
	# same problem as before with using the row array rather than an actual row field
	# also need the check for which option should have selected="selected"
	$continent_select .=
	"\n\t<option value='$continent_id'". ($continent == $continent_id ? 'selected="selected"' : '') .">$continent</option>";
}

$continent_select .= "\n</select>";

$country_select =
'<select name="country" onchange="select_changed(this);">
<option value="0">Please select...</option>';

# overwriting $country
while ($country=mysqli_fetch_assoc($countries))
{
	# array rather than array element...
	# also need the check for which option should have selected="selected"
	$country_select .=
	"\n\t<option value='$country_id'".
	($country == $country_id ? ' selected="selected"' : '') .">$country</option>";
}
$country_select .= "\n</select>";


$city_select =
'<select name="city">
<option value="0">Please select...</option>';

# ...
while ($city=mysqli_fetch_assoc($cities))
{
	# ...
	$city_select .=
	"\n\t<option value='$city_id'>$city</option>";
}
$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>";
}
# ...
elseif (isset($_GET['continent']))
{
	$continent = (int) $_GET['continent'];
	$continent_select =
	'<select name="continent" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	# ...
	while ($continent=mysqli_fetch_assoc($continents))
	{
		# ...
		$continent_select .=
		"\n\t<option value='$continent_id'". ($continent == $continent_id ? ' selected="selected"' : '') .">$continent</option>";
	}
	$continent_select .= "\n</select>";

$country_select =
'<select name="country" onchange="select_changed(this);">
<option value="0">Please select...</option>';
while ($country=mysqli_fetch_assoc($countries))
{
	$country_select .=
	"\n\t<option value='$country_id'>$country</option>";
}
$country_select .= "\n</select>";

$city_select = '';
}
# ...
else
{
	$continent_select =
	'<select name="continent" onchange="select_changed(this);">
	<option value="0">Please select...</option>';
	# ...
	while ($continent=mysqli_fetch_assoc($continents))
	{
		$continent_select .=
		"\n\t<option value='$continent_id'>$continent</option>";
	}
	$continent_select .= "\n</select>";

$country_select = $city_select = '';
}

zooropa

Hi Johanafm,
Thanks for your reply. You must be giving up the will to live helping me. I think i've managed to dig myself into a big hole of php confusion : ) - i sort of got some of what you were trying to tell me but not to the extent where i could fix my problems without digging the hole deeper.

I appreciate you not just giving me the answer as i prefer to work out the answer but sometimes you just have to admit defeat (i'd rather admit defeat and ask for more direct help than just give up and miss out on all the great knowledge i've yet to grasp)

I have a possibly cheeky request - Would you consider posting what you think the code should be ? (i.e. as you'd write it but using the fields i've supplied e.g. continent_id, continent etc).

If I can at least get it working I would then be left with the (for me) sizeable challenge of understanding the code (and i hope you don't mind me asking you further questions about that) - it's my hope that i can start contributing solutions rather than problems on this board in the not-too-distant future.

I really appreciate all the help you've given me up to this point and will understand if you think i've overstepped the mark by essentially asking you to solve my problem.

It's just that If I can just get this chunk of code sorted out it would help me to finish the application i'm working on and i feel like i've been stuck on this small part for ages now (and feeling very frustrated)

:eek:

johanafm

I believe this should do the trick, and pretty much contain the fixes for the comments provided in my previous post.

# The continent select element will always be present, which means continents are
# always needed. Always perform this query
# You will not need the string $query after this, so keeping it in a separate
# variable $query1 that you won't overwrite is unnecessary
$query = "SELECT continent_id, continent FROM tbl_continent ";
$continents=mysqli_query($dbc,$query);



# Since you perform auto_submit on continent/country changes, the submit button is
# only showed when both continent and country have been selected. In other words,
# this is the last step of the form process: choices for continent, country and city exist
if (isset($_GET['submit_btn']))
{
    $continent = (int) $_GET['continent'];
    $country = (int) $_GET['country'];
    $city = (int) $_GET['city'];

# Since you wanted to reset the form so that only continents are shown, these aren't needed
/*
    $query2 = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent;
    $countries=mysqli_query($dbc,$query2);

$query3 = "SELECT city_id, city FROM tbl_city WHERE country_id=".$country;
$cities = mysqli_query($dbc,$query3);
*/  

$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';

# I changed $continent to $c here. You could use anything (other than variables
# allready used, for which you still need the value)
# $row is commonly used as name, since it will contain data for one row from the DB.
while ($c=mysqli_fetch_assoc($continents))
{
    $continent_select .=
    "\n\t<option value='$continent_id'".

	# $c is the row as an array with elements: $c['continent_id'] and $c['continent']
	# ?: operator, see
# http://www.php.net/manual/en/language.operators.comparison.php#language.operators.comparison.ternary
        ($c['continent_id'] == $continent ? ' selected="selected"' : '') .
        '>'.$c['continent'].'</option>';
    }
    $continent_select .= "\n</select>";

# These will be empty
$country_select = $city_select = '';
}
elseif (isset($_GET['country']))
{
    $continent = (int) $_GET['continent'];
    $country = (int) $_GET['country'];

# Here you will need both countries for selected continent and cities for selected country
# But, you won't need either of the strings after this point, so just like at the top
# you can just use $query and overwrite it with each next query.
# You could also directly use
#	mysqli_query($dbc, "SELECT country_id, .... WHERE ..." );
# But it's often good to have queries stored in a variable so you can do one of
# 		echo $query;
#		error_log($query);
# if you ever need to manually inspect a query that doesn't give you what you want.
$query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent;
$countries=mysqli_query($dbc,$query);

$query = "SELECT city_id, city FROM tbl_city WHERE country_id=".$country;
$cities = mysqli_query($dbc,$query3);


$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';

while ($c=mysqli_fetch_assoc($continents))
{
    $continent_select .=
    "\n\t<option value='$continent_id'". ($c['continent_id' == $continent_id ? 'selected="selected"' : '') .'>'.$c['continent'].'</option>';
}

$continent_select .= "\n</select>";

$country_select =
'<select name="country" onchange="select_changed(this);">
<option value="0">Please select...</option>';

# Using $c here for country is fine, even though $c was used above for rows of
# continent data, since the last row from that loop is no longer needed
while ($c = mysqli_fetch_assoc($countries))
{
    $country_select .=
    "\n\t<option value='$country_id'".
    ($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';
}
$country_select .= "\n</select>";


$city_select =
'<select name="city">
<option value="0">Please select...</option>';

while ($c = mysqli_fetch_assoc($cities))
{
    # ...
    $city_select .=
    "\n\t<option value='$city_id'".
    ($c['city_id'] == $city ? ' selected="selected"' : '') . 
    '>'.$c['city'].'</option>';
}
$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>";
}
# ...
elseif (isset($_GET['continent']))
{
    $continent = (int) $_GET['continent'];

# When continent has been selected, retrieve its countries from DB
$query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent;
$countries=mysqli_query($dbc,$query);

$continent_select =
'<select name="continent" onchange="select_changed(this);">
<option value="0">Please select...</option>';
while ($c = mysqli_fetch_assoc($continents))
{
    # ...
    $continent_select .=
    "\n\t<option value='$continent_id'". ($c['continent_id'] == $continent_id ? ' selected="selected"' : '') .'>'.$c['continent'].'</option>';
}
$continent_select .= "\n</select>";

$country_select =
'<select name="country" onchange="select_changed(this);">
<option value="0">Please select...</option>';

while ($c = mysqli_fetch_assoc($countries))
{
    $country_select .=
    "\n\t<option value='$country_id'".
    ($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';
}
$country_select .= "\n</select>";

# But until country has been selected, no select element is shown for cities.
$city_select = '';
}
#
else
{
    $continent_select =
    '<select name="continent" onchange="select_changed(this);">
    <option value="0">Please select...</option>';

while ($c=mysqli_fetch_assoc($continents))
{
    $continent_select .=
    "\n\t<option value='$continent_id'>".$c['continent'].'</option>';
}

$continent_select .= "\n</select>";
}

zooropa

Hi Johanafm,
At last, progress (but little thanks to me ha ha) I'm now getting a dropdown with the continents showing but the following error messages:

Undefined variable: continent_id in C:\InetPub\wwwroot\test\start_fdd_lot2.php on line 163

Undefined variable: country_select in C:\InetPub\wwwroot\test\start_fdd_lot2.php on line 173

Undefined variable: city_select in C:\InetPub\wwwroot\test\start_fdd_lot2.php on line 174

As usual, I can't figure out the reason why these variables are undefined (as it looks to me as if the were defined)

The latest script is:

 
<html>
<head>
<script type="text/javascript"> 
function select_changed(o) { 
if (o.value != 0) { 
o.parentNode.parentNode.submit(); 
} 
} 
</script> 

</head> 
<body>

 
<?php 

require_once('mysqli_connect_dropdown.php');


$query = "SELECT continent_id, continent FROM tbl_continent ";
$continents=mysqli_query($dbc,$query);


if (isset($_GET['submit_btn']))
{
   $continent = (int) $_GET['continent'];
   $country = (int) $_GET['country'];
   $city = (int) $_GET['city'];


   $continent_select =
   '<select name="continent" onchange="select_changed(this);">
   <option value="0">Please select...</option>';


   while ($c=mysqli_fetch_assoc($continents))
   {
       $continent_select .=
       "\n\t<option value='$continent_id'".


   ($c['continent_id'] == $continent ? ' selected="selected"' : '') .
   '>'.$c['continent'].'</option>';
   }
   $continent_select .= "\n</select>";


   $country_select = $city_select = '';

}
elseif (isset($_GET['country']))
{
   $continent = (int) $_GET['continent'];
   $country = (int) $_GET['country'];



   $query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent;
   $countries=mysqli_query($dbc,$query);

   $query = "SELECT city_id, city FROM tbl_city WHERE country_id=".$country;

   $cities = mysqli_query($dbc,$query3);


   $continent_select =
   '<select name="continent" onchange="select_changed(this);">
   <option value="0">Please select...</option>';


   while ($c=mysqli_fetch_assoc($continents))
   {
       $continent_select .=

   "\n\t<option value='$continent_id'". ($c['continent_id'] == $continent_id ? 'selected="selected"' : '') .'>'.$c['continent'].'</option>';

   }

   $continent_select .= "\n</select>";

   $country_select =

   '<select name="country" onchange="select_changed(this);">
   <option value="0">Please select...</option>';

   while ($c = mysqli_fetch_assoc($countries))
   {
       $country_select .=
       "\n\t<option value='$country_id'".
       ($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';

   }
   $country_select .= "\n</select>";


   $city_select =
   '<select name="city">
   <option value="0">Please select...</option>';


   while ($c = mysqli_fetch_assoc($cities))
   {

   $city_select .=
   "\n\t<option value='$city_id'".
   ($c['city_id'] == $city ? ' selected="selected"' : '') .
   '>'.$c['city'].'</option>';

   }
   $city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>";
}

elseif (isset($_GET['continent']))
{
   $continent = (int) $_GET['continent'];

   $query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent;
   $countries=mysqli_query($dbc,$query);


   $continent_select =
   '<select name="continent" onchange="select_changed(this);">
   <option value="0">Please select...</option>';

   while ($c = mysqli_fetch_assoc($continents))
   {

   $continent_select .=

   "\n\t<option value='$continent_id'". ($c['continent_id'] == $continent_id ? ' selected="selected"' : '') .'>'.$c['continent'].'</option>';

   }
   $continent_select .= "\n</select>";

   $country_select =

   '<select name="country" onchange="select_changed(this);">
   <option value="0">Please select...</option>';


   while ($c = mysqli_fetch_assoc($countries))
   {
       $country_select .=
       "\n\t<option value='$country_id'".
       ($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';
   }
   $country_select .= "\n</select>";


   $city_select = '';
}

else
{
   $continent_select =
   '<select name="continent" onchange="select_changed(this);">
   <option value="0">Please select...</option>';


   while ($c=mysqli_fetch_assoc($continents))
   {
       $continent_select .=

   "\n\t<option value='$continent_id'>".$c['continent'].'</option>';
   }

   $continent_select .= "\n</select>";
}
?>

 
<form action="" method="get"> 
<div>

 
<?php 
echo $continent_select . PHP_EOL; 
echo $country_select . PHP_EOL; 
echo $city_select . PHP_EOL; 
?>

 
</div> 
</form> 
<body>
</html>

johanafm

Once again, please indicate what line(s) matches the error messages by adding comments, for example

$foo = bar();
# line 133 below (added to show me which line is which)
$foo += $undefined_variable + undefined_function();

Had it not been for the last two error messages that were obvious to me, I would not have been able to find line 163 (since the php code posted only contains 154 lines).

For the last two error messages, check each respective if/elseif/else block of code. One or more of those are not defining $country_select and/or $city_select. Hint: look in the blocks for which there is no need for either of them, i.e. when only the continent or both continent and country select elements are supposed to be shown. Then for example add $city_select = ''; as has been done elsewhere in your code.

The first error message is here

   while ($c=mysqli_fetch_assoc($continents))
   {
       $continent_select .=
	# This is line 163 - compare it to the other while lops for continent.
       "\n\t<option value='$continent_id'>".$c['continent'].'</option>';
   }

zooropa

Here is my latest attempt and i've taken note of your request to put a comment above any lines that are relevant. So I've put comments above the block of code for countries that doesn't seem to work. If I can get that sorted out, the Continent > Country > City part should be easy because now i can at least identify the 3 main blocks.

 
<html>
<head>
<script type="text/javascript"> function select_changed(o) { 
if (o.value != 0) { 
o.parentNode.parentNode.submit();
 }
 }
</script>
</head>
<body>

 
<?php 

require_once('mysqli_connect.php'); 


$query = "SELECT continent_id, continent FROM tbl_continent "; 
$continents=mysqli_query($dbc,$query); 


if (isset($_GET['submit_btn'])) 
{ 
$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 
$city = (int) $_GET['city']; 


$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c=mysqli_fetch_assoc($continents)) 
{ 
$continent_select .= 
"\n\t<option value='$continent_id'".($c['continent_id'] == $continent ?
' selected="selected"' : '') .'>'.$c['continent'].'</option>'; 
} 
$continent_select .= "\n</select>"; 


$country_select = $city_select = ''; 

} 
elseif (isset($_GET['country'])) 
{ 
$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 



$query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent; 
$countries=mysqli_query($dbc,$query); 

$query = "SELECT city_id, city FROM tbl_city WHERE country_id=".$country; 

$cities = mysqli_query($dbc,$query3); 


$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c=mysqli_fetch_assoc($continents)) 
{ 
$continent_select .= 

"\n\t<option value='$continent_id'". ($c['continent_id'] == $continent_id ? 'selected="selected"' : '') .'>'.$c['continent'].'</option>'; 

} 

$continent_select .= "\n</select>"; 

$country_select = 

'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 

while ($c = mysqli_fetch_assoc($countries)) 
{ 
$country_select .= 
"\n\t<option value='$country_id'". 
($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>'; 


} 
$country_select .= "\n</select>"; 


$city_select = 
'<select name="city"> 
<option value="0">Please select...</option>'; 


while ($c = mysqli_fetch_assoc($cities)) 
{ 

$city_select .= 
"\n\t<option value='$city_id'". 
($c['city_id'] == $city ? ' selected="selected"' : '') . 
'>'.$c['city'].'</option>'; 

} 
$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>"; 
} 

elseif (isset($_GET['continent'])) 
{ 
$continent = (int) $_GET['continent']; 

$query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent; 
$countries=mysqli_query($dbc,$query); 


$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c = mysqli_fetch_assoc($continents)) 
{ 

$continent_select .= 

"\n\t<option value='$continent_id'". ($c['continent_id'] == $continent_id ? ' selected="selected"' : '') .'>'.$c['continent'].'</option>'; 

} 
$continent_select .= "\n</select>"; 




//Here is the block for countries that i've inserted
//***************************************************

$country_select = 

'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 

while ($c=mysqli_fetch_assoc($countries)) 
{

$country_select .= 
"\n\t<option value='$country_id'". ($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>'; 

} 

$country_select .= "\n</select>"; 
$city_select = ''; 
}
//****************************************************



else 
{ 
$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c=mysqli_fetch_assoc($continents)) 
{ 
$continent_select .= 

"\n\t<option value='$continent_id'>".$c['continent'].'</option>'; 
} 

$continent_select .= "\n</select>"; 
} 
?>

 

<form action="" method="get">

 

<?php 
echo $continent_select . PHP_EOL; 
echo $country_select . PHP_EOL; 
echo $city_select . PHP_EOL; 
?>

 
</form>
<body>
</html>

zooropa

Oh, and I can't see errors but that's probably because i'm on my work PC rather than on my home PC. I suspect that error reporting is off on my work PC but i don't know how to turn it on.

johanafm

You could add this to your php script, at the very top of it, but fatal errors that abort parsing will make this approach fail

error_reporting(-1);

A better approach is to edit php.ini. See directives error_reporting, display_errors, log_errors, and http://se2.php.net/manual/en/errorfunc.configuration.php]documentation is here

And in the code for the country select you are still using $country_id rather than indexing the array returned by mysqli_fetch_assoc

$country_select .=

"\n\t<option value='$country_id'" . /* this is the failing part */

 ($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';

zooropa

Hi Johanafm,

In the following, do you mean that i need to replace only the following line

"\n\t<option value='$country_id'"

with something else? - i tried substituting $c for $country_id but to no avail.

Even though you're practically telling me the answer I still can't figure out what to replace the following code with

 

$country_select .=

"\n\t<option value='$country_id'" . /* this is the failing part */

($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';

johanafm

This is how it works. Let's say you have a table with fields

id
name
age

# return value of function call is either false (query failed) or a result set resource
$result = mysqli_query($dbc, 'SELECT id, name, age AS years FROM table');

# see if you got false or a result set resource
if ($result) {
	# iterate over the result set resource, grabbing on row at a time as an array
	while ($row = mysql_fetch_assoc($result)) {
		# the selected fields are elements of the array
		$row['id'];
		$row['name'];
		$row['years'];	# we gave this field an alias, and can't use $row['age']
	}
}
# if you want to get more information about the error that occured
else {
	error_log(mysqli_errno($dbc) . ': ' . mysqli_error());
}

zooropa;10966396 wrote:
"\n\t<option value='$country_id'"
with something else? - i tried substituting $c for $country_id but to no avail.

As I described above, $c is an array while its elements are fields from the current row. $c['country_id'] should work.

zooropa

Hi Johanafm,
Thanks for your explanation. I think i understand what you're telling me. As I haven't used an alias i don't need to worry about that. Is the following any closer? (I've just changed one line) but it's still not working - I'm still only getting the Continents Dropdown. I'm obviously missing something here (apart from a few brain cells).

 

'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 

while ($c=mysqli_fetch_assoc($countries)) 
{

$country_select .=

"\n\t<option value=".$c['country_id']. /* i've changed this line */

($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';

} 

$country_select .= "\n</select>";

johanafm

zooropa;10966597 wrote:

 
'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>';

Was the variable missed when you copy pasted, or does the code actually look like the above? If it does, insert "$country_select = " before the string literal above.

Else, you had better post your current version of the script.

zooropa

Hi Johanafm,
Sorry, I just forgot to post the string literal but it was in my code. OK, so here's my code:

 
<html>
<head>
<script type="text/javascript"> function select_changed(o) { 
if (o.value != 0) { 
o.parentNode.parentNode.submit();
 }
 }
</script>
</head>
<body>

 
<?php 

require_once('mysqli_connect.php'); 


$query = "SELECT continent_id, continent FROM tbl_continent "; 
$continents=mysqli_query($dbc,$query); 


if (isset($_GET['submit_btn'])) 
{ 
$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 
$city = (int) $_GET['city']; 


$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c=mysqli_fetch_assoc($continents)) 
{ 
$continent_select .= 
"\n\t<option value='$continent_id'".($c['continent_id'] == $continent ?
' selected="selected"' : '') .'>'.$c['continent'].'</option>'; 
} 
$continent_select .= "\n</select>"; 


$country_select = $city_select = ''; 

} 
elseif (isset($_GET['country'])) 
{ 
$continent = (int) $_GET['continent']; 
$country = (int) $_GET['country']; 



$query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent; 
$countries=mysqli_query($dbc,$query); 

$query = "SELECT city_id, city FROM tbl_city WHERE country_id=".$country; 

$cities = mysqli_query($dbc,$query3); 


$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c=mysqli_fetch_assoc($continents)) 
{ 
$continent_select .= 

"\n\t<option value='$continent_id'". ($c['continent_id'] == $continent_id ? 'selected="selected"' : '') .'>'.$c['continent'].'</option>'; 

} 

$continent_select .= "\n</select>"; 

$country_select = 

'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 

while ($c = mysqli_fetch_assoc($countries)) 
{ 
$country_select .= 
"\n\t<option value='$country_id'". 
($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>'; 


} 
$country_select .= "\n</select>"; 


$city_select = 
'<select name="city"> 
<option value="0">Please select...</option>'; 


while ($c = mysqli_fetch_assoc($cities)) 
{ 

$city_select .= 
"\n\t<option value='$city_id'". 
($c['city_id'] == $city ? ' selected="selected"' : '') . 
'>'.$c['city'].'</option>'; 

} 
$city_select .= "\n</select>\n<input type='submit_btn' name='submit' value='Submit'/>"; 
} 

elseif (isset($_GET['continent'])) 
{ 
$continent = (int) $_GET['continent']; 

$query = "SELECT country_id, country FROM tbl_country WHERE continent_id=".$continent; 
$countries=mysqli_query($dbc,$query); 


$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c = mysqli_fetch_assoc($continents)) 
{ 

$continent_select .= 

"\n\t<option value='$continent_id'". ($c['continent_id'] == $continent_id ? ' selected="selected"' : '') .'>'.$c['continent'].'</option>'; 

} 
$continent_select .= "\n</select>"; 






$country_select = 

'<select name="country" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 

while ($c=mysqli_fetch_assoc($countries)) 
{

$country_select .=

//******* I changed the following line ***********************

"\n\t<option value=".$c['country_id']. /* this is the failing part */

//*****************************************************

($c['country_id'] == $country_id ? ' selected="selected"' : '') .'>'.$c['country'].'</option>';

} 

$country_select .= "\n</select>"; 
$city_select = ''; 
}
//****************************************************



else 
{ 
$continent_select = 
'<select name="continent" onchange="select_changed(this);"> 
<option value="0">Please select...</option>'; 


while ($c=mysqli_fetch_assoc($continents)) 
{ 
$continent_select .= 

"\n\t<option value='$continent_id'>".$c['continent'].'</option>'; 
} 

$continent_select .= "\n</select>"; 
} 
?>

 

<form action="" method="get">

 
<?php 
echo $continent_select . PHP_EOL; 
echo $country_select . PHP_EOL; 
echo $city_select . PHP_EOL; 
?>

 
</form>
<body>
</html>

I still only get the Continents Dropdown showing