Newbie function problem

[ellesgaard]

Hi!

Im working on a function, and I just can't get it to work.

Here is my function:

function db_select($tabel, $where, $sort){
        $SQL = "SELECT * FROM $tabel";
        if ($where != ""){
            $SQL .= " WHERE $where";
        }
        if ($sort != ""){
            $SQL .= " ORDER BY $sort";
        }

    $db_result = mysql_query($SQL);


    return mysql_fetch_array($db_result);
}

and here is how i try to make it do a loop.

while(db_select("users")){
echo "ole";
}

If I run that code, its just keeps writing "oleoleoleoleoleoleole......".

Can someone help me please? 🙂

[paulnaj]

The function db_select() is called in every time in the while condition hence the first row of the result is being returned every time - meaning the result of the while condition is ALWAYS true.

You could return $db_result from the function before you enter the while loop and use $array = mysql_fetch_array($db_result) as the while condtion.