PROBLEM WITH WHILE LOOP

samannoychatter

Hi ,
I am facing a typical problem while using while loop .

I have inserted php code with javascript. Now when i am running the while loops its working fine. No issues. With Mozilla i don't have any problem, but with ie its giving javascript error.

here is my code.

   <script type="text/javascript">
   <?php
   	$slideimg1="SELECT image_id,heading,description FROM slide";
	$slideimg1=mysql_query($slideimg1);
   ?>
    if(!window.slider) var slider={};slider.data=[<?php while($slidedetails=mysql_fetch_array($slideimg1)){?>{"id":"<?php echo $slidedetails['image_id']?>","client":"<?php echo $slidedetails['heading']?>","desc":"<?php echo $slidedetails['description']?>"},
    <?php } ?>
];
   </script>

Its php tagged with javascript. The loop is running fine but it prints , in every line. I don't want , in my last line. What is the way out. Please help me.

johanafm

samannoychatter;10966278 wrote:
I have inserted php code with javascript.

No, you have inserted javascript code with PHP.

The only thing worse than code without indentation...

function foo(){
while($bar){
if ($foobar){
for($i=10;$i; --$i){
#lots of more code;
}
#more code
}
}
if ($something)foo(); # is this part of the while loop?
}
} # correct amount of closing brackets?

Would be the same code written without even line breaks...

samannoychatter;10966278 wrote:

    if(!window.slider) var slider={};slider.data=[<?php while($slidedetails=mysql_fetch_array($slideimg1)){?>{"id":"<?php echo $slidedetails['image_id']?>","client":"<?php echo $slidedetails['heading']?>","desc":"<?php echo $slidedetails['description']?>"},
    <?php } ?>
];

samannoychatter;10966278 wrote:
The loop is running fine but it prints , in every line. I don't want , in my last line. What is the way out.

Your question really makes little sense to me, but I'm quite certain that if you rewrote the above code with linebreaks and indentation (from a PHP perspective for starters, and then produce javascript code with linebreaks and indentation ("\n" and "\t" are your friends in this case), you should be able to follow the programmatic flow and correct whatever it is you don't want.

anakadote

Without discounting the importance of what johanafm wrote, your problem is that you are including a comma (,) on every line of your loop, including the last. There are a few ways to avoid this. Here is one:

$i=1;
$num_results=count($results);
while($row = mysql_fetch_array($results)){
   // Print whatever here
   if($i != $num_results){
      echo ',';
      $i++;
   }
}

johanafm

Oh, now I get it. I've been seeing too much weird language on the internet lately, so I actually assumed the commas were part of the sentence rather than designating the character being printed :s