[RESOLVED] return radio button value from Javascript function

jrough

I am getting the error message in Firebug "array is undefined".
Something must be wrong with my get_radio_value function.
What I'm trying to do is get the radio button value into my AJAX function so it can refresh the page window.location url so that the sql update in the page gets reflected in the web page display.
I get the right values in the refreshed url even though I get the error message but the window.location in the xhr function doesn't change the displayed values.
The url has the right values. Presumably it is because the error prevents the confirm_print() function to run. There are two radio buttons I need the values of.

function get_radio_value(rbName)
{
var rbName =new array();
for (var i=0; i < document.form[0].rbName; i++)
   {
   if (document.form[0].rbName[i].checked)
      {
      var rad_val = document.form[0].rbName[i].value;
      }
   }
   return rad_val;
}
[code]
part of AJAX function, see window.location= where it refreshes the page with the right values.  

[code]
function confirmPrint(){
var print_flag=get_radio_value("search_pref_flag");
var pref_ind=get_radio_value("search_print_ind");etc etc


  window.location="print_labels_forml.php?page="+page+"&bu="+bu+"&zonenm="+zonenm+"&zoneid="+zoneid+
"&print_flag="+print_flag+"&pref_ind="+pref_ind;
}else

This is the first of the two radio buttons I want to get the value of into Javascript

echo "<th align='right'>Preferred Status</th>\n";
echo "<div='search_pref_ind'>";
if ($search_pref_ind==''){
echo "<td><input type='radio' class='radio_b' name='search_pref_ind'  value ='N' >Not Preferred </td>\n";
echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='Y' >Preferred</td>\n";
echo "<td><input type='radio' name='search_pref_ind' class='radio_b' value= 'A' checked >ALL</td>\n";
}else {
   if ( $search_pref_ind=='N' ) {
        echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='N' checked >Not Preferred</td>\n";
        echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='Y'>Preferred</td>\n";
        echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='A'>ALL</td>\n";
    }elseif($search_pref_ind=='Y'){

    echo "<td><input type='radio' name='search_pref_ind' class='radio_b' value ='N' >Not Preferred</td>\n";
    echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='Y' checked>Preferred</td>\n";
    echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='A'>ALL</td>\n";
}elseif($search_print_flag=='A'){
    echo "<td><input type='radio' name='search_pref_ind' class='radio_b' value ='N'>Not Preferred</td>\n";
    echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='Y'>Preferred</td>\n";
    echo "<td><input type='radio' name ='search_pref_ind' class='radio_b' value='A' checked>ALL</td>\n";
}

}//end else
echo "</div>";

Thanks for your help. I need to fix the undefined error so I can get the AJAX to run.

Res

If I'm not mistaken it should be

var rbName = new Array();

A instead of a in Array.

johanafm

Correct. And once that is fixed, you have a new problem. To solve it yourself, you need to use a browser that tells you where the problem is.

Do use one that indicates not only the line number of the error, but also the correct line number, and provides a meaningful error message. Firefox is my favorite, and if nothing else, IE7 does not meet these requirements. IE8 might actually get the line numbers right, but its error messages are often not as clears as FF's, and I still find it so much worse that I only ever use it to debug things when they allready work in every other browser.

In this case, using Firefox, I'd get an error message like

Error: array is not defined
Source file: http://example.com/file.php             Line N

Clicking on http://example.com/file.php takes me to the source code with the appropriate line highlighted, i.e.

	var rbName =new array();

And suddenly there is very little code to look at to find the error. Doing the same should let you find your "form" error.

Edit: just reread and reazlied you are using FF. Anyway, for these problems, I stick to the error console rather than Firebug.

jrough

thank you both for your response. Actually I did do it in Firefox and i looked in the line number but I didn't see the typo because I am not used to Javascript being case sensitive. Thanks again.