[RESOLVED] Help with tab function

Walle

<?php
$id = $_GET["a"];
$id = $_GET["b"];
$id = $_GET["c"];


echo "
<a href='test.php?a=$id'>Tab-A</a> | 
<a href='test.php?b=$id'>Tab-B</a> |
<a href='test.php?o=$id'>Tab-C</a> |
<br>
";
?>

I can’t get this work, im try to make some tab function with simple link.

I have a URL as test.php?a=27, test.php?b=27 and test.php?c=27 and need to take that id number for tab-a, tab-2 and tab-3.

Is it possible take id-number from this deferent GET and use or return back to link tab-a, tab-2 and tab-3?

cretaceous

yes it is possible

but your $id will always equal $_GET["c"];
as that is the last one you set

you need to have
$ida=$GET["a"];
$idb=$GET["b"];
$idc=$_GET["c"];

Walle

<a href="/test.php?a=27">test1</a>
<a href="/test.php?a=30">test2</a>
<a href="/test.php?a=34">test3</a>

<br><br>


<?php 
$ida=$_GET["a"]; 
$idb=$_GET["b"]; 
$idc=$_GET["c"];


echo " 
<a href='test.php?a=$id'>Tab-A</a> | 
<a href='test.php?b=$id'>Tab-B</a> | 
<a href='test.php?c=$id'>Tab-C</a> | 
<br> 
"; 
?>

Didn’t work or i did something wrong. "Tab links" don’t get any id from url. If i click on link "test2" then I need id 30 for all tabs and if click on some of the tabs then I want keep have same id for all tabs but this didn’t work. I did something wrong?

cretaceous

I don't clearly understand what you want to do
ok lets go back to the first version..

the problem is that the value - empty or not - of 'c 'will override the others

$id = $_GET["a"];
$id = $_GET["b"];
$id = $_GET["c"];

you could try this

if(isset($_GET["a"])$id =$_GET["a"];
if(isset($_GET["b"])$id = $_GET["b"];
if(isset($_GET["c"])$id = $_GET["c"];

Walle

Well my explain is probably not best but let’s say you have test.php?a=27 as address when you arrives to "test.php". If Tab-A is clicked I want link to a=27, if Tab-B is clicked to b=27, and if Tab-C is clicked to c=27.

Depends on which tab is klicked different between url is characters before "="

I tested with if(isset.. but get Parse error: syntax error, unexpected T_VARIABLE. On same row as if(isset.. starts.

cretaceous

yeah it should work - providing you also keep a record of which of the tabs was clicked

I left out a closing bracket sorry

if(isset($_GET["a"]) ) $id =$_GET["a"];
if(isset($_GET["b"]) ) $id = $_GET["b"];
if(isset($_GET["c"]) ) $id = $_GET["c"];

and to get the tab clicked you could modify to this

if(isset($_GET["a"])) {
$id =$_GET["a"];
$tabclicked='a';
}
if(isset($_GET["b"])) {
$id = $_GET["b"];
$tabclicked='b';
}
if(isset($_GET["c"])) {
$id = $_GET["c"]; 
$tabclicked='c';
}

Bonesnap

Walle;10967054 wrote:
<a href="/test.php?a=27">test1</a>
<a href="/test.php?a=30">test2</a>
<a href="/test.php?a=34">test3</a>

 


<?php 
$ida=$_GET["a"]; 
$idb=$_GET["b"]; 
$idc=$_GET["c"];


echo " 
<a href='test.php?a=$id'>Tab-A</a> | 
<a href='test.php?b=$id'>Tab-B</a> | 
<a href='test.php?c=$id'>Tab-C</a> | 
 
"; 
?>
Didn’t work or i did something wrong. "Tab links" don’t get any id from url. If i click on link "test2" then I need id 30 for all tabs and if click on some of the tabs then I want keep have same id for all tabs but this didn’t work. I did something wrong?

You didn't change the $id variable in your links after making the changes.

<a href="/test.php?a=27">test1</a>
<a href="/test.php?a=30">test2</a>
<a href="/test.php?a=34">test3</a>

<br><br>


<?php 
$ida=$_GET["a"]; 
$idb=$_GET["b"]; 
$idc=$_GET["c"];


echo " 
<a href='test.php?a=$ida'>Tab-A</a> | 
<a href='test.php?b=$idb'>Tab-B</a> | 
<a href='test.php?c=$idc'>Tab-C</a> | 
<br> 
"; 
?>

Also, what's your DOCTYPE? tags are to be closed such as " " in XHTML. They're fine as " " in HTML, though.

Walle

Bonesnap;10967087 wrote:
You didn't change the $id variable in your links after making the changes.

I didn’t change that because I early had variable named $a, $b, $c and It didn’t work.

$ida, $idb, $idc was just different variable name in that case.

Walle

cretaceous;10967071 wrote:
yeah it should work - providing you also keep a record of which of the tabs was clicked

I left out a closing bracket sorry
if(isset($_GET["a"]) ) $id =$_GET["a"];
if(isset($_GET["b"]) ) $id = $_GET["b"];
if(isset($_GET["c"]) ) $id = $_GET["c"]; 
and to get the tab clicked you could modify to this
if(isset($_GET["a"])) {
$id =$_GET["a"];
$tabclicked='a';
}
if(isset($_GET["b"])) {
$id = $_GET["b"];
$tabclicked='b';
}
if(isset($_GET["c"])) {
$id = $_GET["c"]; 
$tabclicked='c';
}

That’s work great and just like what I mean. Is it possible to reduce the code somehow? Example if possible somehow make one variable from $GET["a"] , $GET["b"] and $GET["c"]. Or somehow with $SESSION?

New code (working code) looks now

<?php 
if(isset($_GET["a"])) { 
$id =$_GET["a"]; 
$tabclicked='a'; 
} 
if(isset($_GET["b"])) { 
$id = $_GET["b"]; 
$tabclicked='b'; 
} 
if(isset($_GET["c"])) { 
$id = $_GET["c"]; 
$tabclicked='c'; 
} 

echo " 
<a href='test.php?a=$id'>Tab-A</a> | 
<a href='test.php?b=$id'>Tab-B</a> | 
<a href='test.php?c=$id'>Tab-C</a> | 
<br> 
"; 
?>

cretaceous

you could do this

<?php
$id =$_GET["id"];
$tabclicked=$_GET["tab"];;

echo "
<a href='test.php?id=$id&tab=a'>Tab-A</a> |
<a href='test.php?id=$id&tab=b'>Tab-B</a> |
<a href='test.php?id=$id&tab=c'>Tab-C</a> |
<br>";
?>

for html write the '&' as '&'

<a href='test.php?c=$id&amp;tab=c'>Tab-C</a>

Walle

cretaceous;10967099 wrote:

you could do this

<?php
$id =$_GET["id"];
$tabclicked=$_GET["tab"];;

echo "
<a href='test.php?id=$id&tab=a'>Tab-A</a> |
<a href='test.php?id=$id&tab=b'>Tab-B</a> |
<a href='test.php?id=$id&tab=c'>Tab-C</a> |
<br>";
?>

for html write the '&' as '&'

<a href='test.php?c=$id&amp;tab=c'>Tab-C</a>

Thanks for your help man. It works great. I got little longer URL in address bar instead but I guess that’s no big problem.

Thanks again...

cretaceous

glad to help
remember to mark the thread resolved

Walle

cretaceous;10967194 wrote:
glad to help
remember to mark the thread resolved

How to mark thread resolved?

BTW, i tested and find this work:

<?php 
$id = $_GET["a"] | $_GET["b"] | $_GET["c"];

echo "
<a href='test.php?a=$id'>Tab-A</a> |
<a href='test.php?b=$id'>Tab-B</a> |
<a href='test.php?c=$id'>Tab-C</a> | 
"; 
?>

What do you think, It can’t be with less code?

bradgrafelman

Walle wrote:
How to mark thread resolved?

By clicking the "Mark Thread Resolved" link on the Thread Tools menu above.

By the way... this:

$id = $_GET["a"] | $_GET["b"] | $_GET["c"];

doesn't make much sense (from a practical point of view - mathematically it can certainly be done). Why are you doing a bitwise OR operation on three different strings?

cretaceous

I don't know why you are so keen to do something in less code
of course you should be efficient - but has someone set a task to do it one line ??
there's no real world requirement for that!

Walle

bradgrafelman;10967284 wrote:
doesn't make much sense (from a practical point of view - mathematically it can certainly be done). Why are you doing a bitwise OR operation on three different strings?

Why not, it works just like I want.

Walle

cretaceous;10967312 wrote:
I don't know why you are so keen to do something in less code
of course you should be efficient - but has someone set a task to do it one line ??
there's no real world requierment for that!

I think less code as possible is good. For this simple function this $id = $GET["a"] | $GET["b"] | $_GET["c"]; works good. Don’t know if it is good PHP or correct thing to do but it work.