Keep getting Parse errors

[matsturge001]

I'm really new at this and I'm tearing my hair out trying to understand what i've done wrong here. I keep getting these parse errors and although I seemed to fix some of them, now I keep getting this one...

Parse error: syntax error, unexpected $end in /home/stinkyp1/public_html/contact.php on line 32

...and I just can't figure it out. I've read the other threads with similar problems and tried the solutions suggested but now I think i might be making it worse.

All I want to do is have a form on my site that emails me the info from the field boxes and thanks them for submitting it.

Here is the code I've used for the form:

<form method="post" action="/contact.php">

<table bgcolor=#ffffcc border=8 align=center>

<tr><td colspan=2 align=center><strong>Book your collection using this form:</strong></td></tr>


<tr><td>Area:</td><td><select name="sendto">

<option value="[e-mail]">Gold Coast</option>

<option value="[e-mail]">Brisbane</option>

<option value="[e-mail]">Other</option>

</select></td></tr>

<tr><td>Name:</td><td><input size=45 name="Name"></td></tr>

<tr><td>Email:</td><td><input size=45 name="Email"></td></tr>

<tr><td>Phone:</td><td><input size=45 name="Phone"></td></tr>

<tr><td>Address:</td><td><input size=45 name="Address"></td></tr>

<tr><td colspan=2>Message (optional):</td></tr>

<tr><td colspan=2 align=center><textarea name="Message" rows=5 cols=52></textarea></td></tr>

<tr><td colspan=2 align=center><input type=submit name="send" value="Submit"></td></tr>

<tr><td colspan=2 align=center>Stinky Poos will contact you shortly</small></td></tr>

</table>

</form>

and here is the code I've used for the contact file:

<?php 
$to = "[e-mail]" ; 
$from = $_REQUEST['Email'] ; 
$name = $_REQUEST['Name'] ; 
$headers = "From: $name <$from>"; 
$subject = "Web Contact Data";

$fields = array(); 
$fields{"Name"} = "Name";
$fields{"Email"} = "Email";
$fields{"Message"} = "Message";

$body = "We have received the following information:\n\n"; foreach($fields as $a => $b){ 	$body .= sprintf("%20s: %s\n",$b,$_REQUEST[$a]); } 

$headers2 = "From: You <[e-mail]>"; 
$subject2 = "Thank you for contacting us"; 
$autoreply = "Thank you for contacting us. Somebody will get back to you as soon as possible, usually within 48 hours.";

if($from == '') {print "You have not entered an email, please go back and try again";} 
else { 
if($name == '') {print "You have not entered a name, please go back and try again";}
else {
if($phone == '') {print "You have not entered a phone number, please go back and try again";} 
else { 
$send = mail($to, $subject, $body, $headers); 
$send2 = mail($from, $subject2, $autoreply, $headers2); 
if($send) 
{print "Thank you for contacting us."; } 
else 
{print "We encountered an error sending your mail, please notify [email][e-mail][/email]"; } 
}
}

Can someone please help me?

[NogDog]

If you indent your PHP code, you should be able to see that the curly braces do not balance out. (PS: Welcome to the forum, and in the future, you can help us help you by making use of this forum's [noparse]

...

[/noparse] BBCode tags.

<?php
$to = "[e-mail]";
$from = $_REQUEST['Email'];
$name = $_REQUEST['Name'];
$headers = "From: $name <$from>";
$subject = "Web Contact Data";
$fields = array();
$fields{"Name"} = "Name";
$fields{"Email"} = "Email";
$fields{"Message"} = "Message";
$body = "We have received the following information:\n\n";
foreach($fields as $a => $b) {
   $body.= sprintf("%20s: %s\n", $b, $_REQUEST[$a]);
}
$headers2 = "From: You <[e-mail]>";
$subject2 = "Thank you for contacting us";
$autoreply = "Thank you for contacting us. Somebody will get back to you as soon as possible, usually within 48 hours.";
if ($from == '') {
   print "You have not entered an email, please go back and try again";
} else {
   if ($name == '') {
      print "You have not entered a name, please go back and try again";
   } else {
      if ($phone == '') {
         print "You have not entered a phone number, please go back and try again";
      } else {
         $send = mail($to, $subject, $body, $headers);
         $send2 = mail($from, $subject2, $autoreply, $headers2);
         if ($send) {
            print "Thank you for contacting us.";
         } else {
            print "We encountered an error sending your mail, please notify [email][e-mail][/email]";
         }
      }
   }
   

[matsturge001]

I don't really understand but I tried the indented version to gave and got another error:
Parse error: syntax error, unexpected $end in /home/stinkyp1/public_html/contact.php on line 35

[NogDog]

The problem is that the number of "{" for if/else blocks or loops do not equal the closing "}". I'm not sure if you just left out a "}" at the very end, or if you need it somewhere earlier -- that depends on the precise logic you want to implement. The indenting just helps to show how the current code is organized based on the existing braces.

[matsturge001]

Thanks NogDog. I don't understand indenting very well at all but you were right; I had left out a } and was also indenting it incorrectly when i did add it. I'm all fixed now so thanks for your help.

[dockeryz]

Just a few tips

There is such thing as an elseif statement. There's no need to go all

else { if () {} }

on your code style. This probably has a lot to do with the reason you came up with "so many 'parse' errors" I symbolize parse because a parse error is a user error. It usually/most always means the coder screwed up somewhere in their syntax.

Another tip, if you IF statement has only one expression, then you DO NOT need curly braces.

For instance

if($numExpressions == 1) echo "Woohoo!!... no curly braces needed!!!!";


////  <==  Irrelevant spacing

/*
  The same thing with elseif's OR else if's
 ////// blah blah some if statements.... here
 ..................
*/
elseif($numExpressions == 73) echo "Well I guess it equals 75!";

else if($numExpressions == 0) echo "Why is it ZERO???!!";

Also, IMO, elseif's are completely pointless. You can just as easily do it procedurally. Like so

if($blah == 2) echo $blah . " is definitely 2";
if($blah == "not numerical") echo $blah . "is definitely not a number";

This can also be accomplished by a switch. Like so

switch($blah) {
   case 2:
        echo $blah . " is definitely 2";
   break;

   case "":
        echo $blah . " is definitely not a number";
   break;
}

[dockeryz]

Well, I take that back... else if's aren't completely pointless, but as far as what you're doing they are.

else if's are meant for counters and such... for example... else if (whatever)... don't count ... or count extra.
Get it?

http://static.flingbits.com/bar_php_help.png