I'm trying to dynamically add an attribute to an input tag,need help

dan_default

I want to do this so that the user can be returned to the form in the case of an error and still have all the checkboxes still check from before they submitted a form.

The way I thought of doing this was to place all the data in the SESSION array. This works easily for the text fields, but the multiple checkboxes have been a problem.

Here's what I've got:

<?php
function findit($s)
	{
		$arr = $_SESSION['statevisited'];
		$states_string = implode(",", $arr);
		$pos = strpos($states_string, $s);

	if ($pos !== false)
	{
		echo 'checked="true"';
	}
}

?>


<input type="checkbox" name="statevisited[]" value="Alabama" <?php findit('Alabama') ?> >Alabama<br/>
[...etc...the rest of 50 states...]

I'm trying to call the function from within the <input> tag in hopes of returning the checked="true" attribute if the findit function finds the passed state name in the SESSION array.

This is not working. It doesn't seem that I can call a function from here. I've tested calling the function from else where with no problems. But it doesn't work from inside the tag.

Perhaps I'm going about this all wrong.

dagon

that's a very unique way to search your array

most of us use in_array()

dan_default

dagon;10968002 wrote:
that's a very unique way to search your array

most of us use in_array()

Thank you for that!

What about the rest of my mess?

dan_default

dan_default;10968005 wrote:
Thank you for that!

What about the rest of my mess?

Looks like you've answered my question. This works:

Thanks for your help.

anakadote

A quick note on the above, depending on your error reporting settings if $_SESSION['statevisited'] isn't defined yet or isn't an array is_array() will throw an error. You can suppress those using the at each symbol (@):

<input type="checkbox" name="statevisited[]" value="Alabama" <?php
if (@in_array("Alabama", $_SESSION['statevisited'])) {echo 'checked="true"';} ?> >

dan_default

Thanks for the tip!

laserlight

anakadote wrote:
A quick note on the above, depending on your error reporting settings if $SESSION['statevisited'] isn't defined yet or isn't an array is_array() will throw an error. You can suppress those using the at each symbol (@):

You could, but it is better to be explicit than to mysteriously suppress a warning:

<input type="checkbox" name="statevisited[]" value="Alabama" <?php
if (isset($_SESSION['statevisited']) && is_array($_SESSION['statevisited']) && in_array("Alabama", $_SESSION['statevisited'])) {echo 'checked="true"';} ?> >

If you are concerned about verbosity then write a function.

Incidentally, I think checked="true" should be checked="checked".