php or css?

iikon

Ok i have what i thought to be a simple little addition to my page, turns out the solution isnt working for me, here is what i am trying to attempt,
I am trying to change the background-color of my <td> depending on the value of my $var from the database

my $var
if it >1000 but < 2000 i want background-color:#000;
if it >2000 but < 3000 i want background-color:#fff;
And so on

Somebody else gave me this to use in css but it is not working

background-color:#<?php
$defwin=7;
switch($defwin)
{
case ($defwin > 0 &&  $defwin < 1000): echo "FFF;"; break;
case ($defwin > 1000 && $defwin < 2000): echo "FFFF00;"; break;
case ($defwin > 2000 && $defwin < 2500): echo "66FF99;"; break;
case ($defwin > 2500 && $defwin < 3000): echo "E0C760;"; break;
case ($defwin > 3000 && $defwin < 4000): echo "669999;"; break;
case ($defwin > 4000 && $defwin < 4500): echo "9933FF;"; break;
case ($defwin > 4500 && $defwin < 5000): echo "CC6666;"; break;
case ($defwin > 5000 && $defwin < 5500): echo "0066FF;"; break;
case ($defwin > 5500 && $defwin < 6000): echo "006633;"; break;
case ($defwin > 6000 && $defwin < 7000): echo "666666;"; break;
case ($defwin > 7000 && $defwin < 8000): echo "996600;"; break;
case ($defwin > 8000 && $defwin < 9000): echo "FF00FF;"; break;
case ($defwin > 9000 && $defwin < 10000): echo "330000;"; break;
case ($defwin > 10000 && $defwin < 12500): echo "66FF00;"; break;
case ($defwin > 12500 && $defwin < 15000): echo "333333;"; break;
case ($defwin > 15000 && $defwin < 20000): echo "CC99FF;"; break;
case ($defwin > 20000 && $defwin < 30000): echo "CCCCFF;"; break;
case ($defwin > 30000 && $defwin < 40000): echo "993300;"; break;
case ($defwin > 40000 && $defwin < 50000): echo "660099;"; break;
case ($defwin > 50000 ): echo "000;"; break;
default: "000"; 
} 
?>

Obviously my $var=defwin Can someone help me?

bradgrafelman

The [man]switch/man statement basically compares what's inside the switch() part with all of the individual case (expr) expressions. Take one of your case expressions:

($defwin > 0 &&  $defwin < 1000)

the value of that expression is going to be a boolean true or false. Now look at what you're comparing that boolean value to (e.g. the expression in the switch() part):
code=php[/code]Notice the problem?

iikon

ok i notice that they are the same, what am i supposed to compare them to?

again i have very little knowledge, and i am just trying to see where this went wrong or use something else, should i be comparing it to another $var?

bradgrafelman

iikon;10969088 wrote:
ok i notice that they are the same

No, they aren't. Pretend $defwin is equal to the number 436.

In that case, you're comparing this:

($defwin > 0 &&  $defwin < 1000)

to the number 436. In other words, you're comparing boolean TRUE with the number 436. Those values are not strictly equal.

Instead, you should be comparing each "case" value to boolean TRUE - not $defwin.

iikon

ok, im sorry i am such a noob at this, which part should i be changing?

bradgrafelman

All of the case expressions are boolean expressions - meaning they're statements that are either true or false. Which case do you want? You want the one that is true, thus you should be comparing all of the case statements to TRUE in order to find the matching case. Presently, you're comparing them to the value of $defwin instead.

You're going to end up with a common switch(TRUE) structure which I've never been very fond of (from a semantics point of view) since I makes more sense to me to write the statements as a series of chained if/elseif/elseif/... statements instead of a switch() structure.

iikon

i would rather have it in a else if myself also, but again i am new and someone else gave that to me, i was just trying to work with what i had which wasnt very good obviously 🙂

bradgrafelman

iikon;10969093 wrote:
i would rather have it in a else if myself also

Well then by all means - change it!

Using an if/elseif/... here not only makes the meaning a tad bit clearer, but it's even less code than the useless switch(TRUE) structure is.

iikon

And if i knew how to do that i wouldnt have posted for help, again i thank you for all that you have done but i have 0 clue

iikon

Could someone please help me

johanafm

iikon;10969093 wrote:
i would rather have it in a else if myself also

To feel that you'd prefer if/else statements, you must have some idea of how they work. So why not try to do it? If you fail, post what you did and ask for help, else be happy that you managed by trying it out.

iikon

ok from a few examples i seen i came up with this

<?php


{

$color = "#000000;";

if ($defwin >= 0)
   $color = "#FFFFFF;";
else if ($defwin >= 1001)
   $color = "#FFFF00;";
else if ($defwin >= 2000)
   $color = "#66FF99;";
else if ($defwin >= 2500)
   $color = "#E0C760;";
else if($defwin <= 3500)
   $color = "#669999;";
else if ($defwin <= 4000)
   $color = "#9933FF;";
else if ($defwin <= 4500)
   $color = "#CC6666;";
else if ($defwin <= 5000)
   $color = "#0066FF;";
else if ($defwin <= 5500)
   $color = "#006633;";
else if ($defwin <= 6000)
   $color = "#666666;";
else if($defwin <= 7000)
   $color ="#996600;";
else if($defwin <= 8000)
   $color = "#FF00FF;";
else if ($defwin <= 9000)
   $color = "#330000;";
else if ($defwin <= 10000)
   $color = "#66FF00;";
else if ($defwin <= 12500)
   $color = "#333333;";
else if($defwin <= 15000)
   $color ="#CC99FF;";
else if ($defwin <= 20000)
   $color = "#CCCCFF;";
else if ($defwin <= 30000)
   $color = "#993300;";
else if ($defwin <= 40000)
   $color = "#660099;";
else if ($defwin >= 40000)
   $color = "#000000;";
}
?>

And i used this in my TD

<td  style=\"background-color:$color color:#ff0000; font-size:12; font-weight:bold;\">".$defwin."</td>

I know im surprised to that a noob like me cant figure it out

johanafm

There is just a small problem with the comparison logic, since 1 > 0, just like 1002 > 0, any positive integer will make the first if clause true. As such, start with a comparison against the greatest possible value instead.
And, stick to the same comparison operator all the way, in this case >. In your example above you switched from > to < in the middle.

Also, since the ; is not part of the color, I'd leave it out of it. That is, instead of assigning strings like "#123456;" I'd just assign "#123456" and add the ; as needed in the inline style attribute.

# Any value less than 40k goes on to the next if 
if ($defwin >= 40000)
   $color = "#000000";
# Any value less than 30k goes on to the next if. Any value of 40k or higher was dealt with above
# so this part is only true for values from 30000 to 39999
else if ($defwin >= 30000)
   $color = "#993300";
/* and continue in this way until you get to the compaison against your lowest value */
elseif ($defwin >= 0)
   $color = "#FFFFFF";


echo '<table><tbody><tr>';
echo "<td  style=\"background-color:$color; color:#ff0000; font-size:12; font-weight:bold;\">".$defwin."</td>";
echo '</tr></tbody></table>';