unexpected T_CONSTANT_ENCAPSED_STRING

Caljim36

I have read a lot on these forums about this error, but I cannot seem to fix my problem. I have an UPDATE query with the following code that gives the error:

if('" . $FILES['image']['name'] . "' !=""){
picture='" . $FILES['image']['name'] . "',
}

The error does not say it is expecting anything.

I did try this:

$pic = '" . $FILES['image']['name'] . "';
if($pic !=""){
picture='" . $FILES['image']['name'] . "',
}

And I get the same error.

Thanks. I appreciate any help.

dagon

gone way overboard with the quotes

if($_FILES['image']['name'] !=''){
$picture=$_FILES['image']['name'];
}

you may like to use empty() instead of =''

Caljim36

Thanks, Dagon. When I made the changes you suggested, I get this error: unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING.

I'm posting the whole query so you can see what I'm trying to do.

$query = "UPDATE posts SET employer='". $POST['employer'] . "',
email ='". $POST['email'] . "',
pass ='". $POST['pass'] . "',
if($FILES['image']['name'] !=''){
picture= '".$FILES['image']['name'] . "',
}
first ='". $POST['first'] . "',
last ='". $POST['last'] . "',
phone ='". $POST['phone'] . "',
web ='". $POST['web'] . "',
address ='". $POST['address'] . "',
city ='". $POST['city'] . "',
state ='". $POST['state'] . "',
zip ='". $POST['zip'] . "',
days ='". $POST['days'] . "',
comment ='". $POST['comment'] . "'
WHERE email = '". $POST['email'] . "' AND pass = '". $_POST['pass'] . "'";
$result = mysql_query($query) or die ("<p>Errpr : " . mysql_error());
header("Location: index.php");
}

dagon

please use the boards php tags like i did
never insert data from a user directly in to a db
the passwords should not be stored as plain text.

<?php

if($_FILES['image']['name'] !=''){
$picture= $_FILES['image']['name'];
}

$query = "UPDATE posts SET employer='{$_POST['employer']}',
email ='{$_POST['email']}',
pass ='{$_POST['pass']}',
picture='$picture',
first ='{$_POST['first']}',
last ='{$_POST['last']}',
phone ='{$_POST['phone']}',
web ='{$_POST['web']}',
address ='{$_POST['address']}',
city ='{$_POST['city']}',
state ='{$_POST['state']}',
zip ='{$_POST['zip']}',
days ='{$_POST['days']}',
comment ='{$_POST['comment']}'
WHERE email = '{$_POST['email']}' AND pass = '{$_POST['pass']}' ";

$result = mysql_query($query) or die('<p>Errpr : '.mysql_error());

header("Location: index.php"); 

?>

Caljim36

Thank you for your recommendations. I've been doing PhP for about six months now. I know the importance of what you say, and I will follow up.

Don't know how to fix this, but the "picture" line in the code I posted should be replaced with the if(....) in the first post.

dagon

Caljim36;10970321 wrote:
Don't know how to fix this, but the "picture" line in the code I posted should be replaced with the if(....) in the first post.

should work fine wit the code i posted above, what's the exact issue?

Caljim36

Here is the code I used following your recommendations:

if($FILES['image']['name'] !=' '){
picture= '". $FILES['image']['name'] . "',
}

And I get this error:

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING

The code looks correct to me, but I'm obviously creating a bug here. I'm in the dark.

dagon

thats not what i wrote

Caljim36

I don't think putting an if condition into the UPDATE query string works. I am testing the condition before the query, and things are working better. Thanks for your help.

dagon

Caljim36;10970473 wrote:
I don't think putting an if condition into the UPDATE query string works.

it does if you do it properly.

$query = "UPDATE posts SET employer='{$_POST['employer']}',
email ='{$_POST['email']}',
pass ='{$_POST['pass']}',";


if($_FILES['image']['name'] !=''){
$query .= "picture= '{$_FILES['image']['name']}',"; 
}

$query .= '';//rest of query

Caljim36

I have the code working now. I was not aware of ".=" assignment operator. Thank you for your patience and help. I appreciate it very much.