[RESOLVED] Broke function -- need help

zzz

I had a function that detected URLs in text and turned them into links. However it won't take user directly to the link but rather to a warning page that it was an outside link. It worked well.

I have modified this function since to check if the URL was to an internal page within my site. I added preg_replace_callback and piped the match into another function that created links based on a logic mySite vs. Outside Site.

I have broke something because the function just doesn't work any longer. Since i can't seem to be able to see what I messed up, could someone please take a look at the new function below...

function makeLink($src) {

$checkDomain = preg_replace_callback('/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/', 'checkDomain', $src);

   function checkDomain($matches) {

$host =  parse_url($matches[0], PHP_URL_HOST);
$host =  ltrim($host, 'www.');

if ($host == 'mydomain.com') {
    $makeUrl = preg_replace("/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/", '<a href="http://$2$3">$2$4</a>', $matches[0]);
} else {
    $makeUrl = preg_replace("/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/", '<a href="/warningPage/$2$3" rel="nofollow">$2$4</a>', $matches[0]);
}
   }
   return $makeUrl;
}

Res

Let me preface by saying I haven't look at the logic of your function, just noticed you have a function inside of a function, which would prevent it from working. Not to say it will work once you correct it, just that it's the glaring issue.

function makeLink($src) {

$checkDomain = preg_replace_callback('/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/', 'checkDomain', $src);

$makeUrl = checkDomain($checkDomain);

return $makeUrl;
}

function checkDomain($matches) {

$host =  parse_url($matches[0], PHP_URL_HOST);
$host =  ltrim($host, 'www.');

if ($host == 'mydomain.com') {
	$makeUrl = preg_replace("/(http
:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/", '<a href="http://$2$3">$2$4</a>', $matches[0]);
	} else {
		$makeUrl = preg_replace("/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/", '<a href="/warningPage/$2$3" rel="nofollow">$2$4</a>', $matches[0]);
	}

return $makeUrl;
}

zzz

True... Is there a way to make use of preg_replace_callback without sending match into a function?

Res

Sorry I didn't look at your function much past the syntax error. You're using a callback, which means you are correct in that you shouldn't have to pass matches off to a function. You can omit that part, but your call back function does have to be defined for it to be used.

function makeLink($src) {

$checkDomain = preg_replace_callback('/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/', 'checkDomain', $src);

return $checkDomain;
}

function checkDomain($matches) {

$host =  parse_url($matches[0], PHP_URL_HOST);
$host =  ltrim($host, 'www.');

if ($host == 'mydomain.com') {
    $makeUrl = preg_replace("/(http
:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/", '<a href="http://$2$3">$2$4</a>', $matches[0]);
    } else {
        $makeUrl = preg_replace("/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/", '<a href="/warningPage/$2$3" rel="nofollow">$2$4</a>', $matches[0]);
    }

return $makeUrl;
}

zzz

OK, I see your point but now I'm hopelessly confused on how to use these functions. I used to have something like this:

function makeLink($src) { 
     $makeUrl = preg_replace("/(http:\/\/|(www\.))(([^\s<]{4,68})[^\s<]*)/", '<a href="/warningPage/$2$3" rel="nofollow">$2$4</a>', $matches[0]);

return $makeUrl;
}

and on my page I would include it as:

echo nl2br_indent(makeLink($src), $indent = 0).'

where nl2br_indent is another function that preserved formatting.
How do I use the new combo? Sorry, it's probably basic, but I'm a bit confused.

Res

It should work as is, unless there are other problems.

Basically you are using a callback function, which means it's going to pass your matches to whatever you define there. The only thing we've changed is properly declaring your functions, as having a function in a function causes a syntax error.

What's happening now when you run

echo nl2br_indent(makeLink($src), $indent = 0)

If that's still broken, add some echos to you checkDomain function, the callback function, and see if the data is going into that as you expect.

Take a look at:
http://php.net/manual/en/function.preg-replace-callback.php

zzz

You're right. I had a typo which broke it all. Works like a charm!