DELETE from table in PHP - Help plzzz

princeofpesia

Hi guys, I have a table of messeges where listed from database. I have added a column (thanks to php freak forum) where users can delete msgs from the table, there are two pages, view messege page which lists the messeges and a delete function page (please see below)

All the connections are fine and pagination works perfectly, but when i press on delete it wont delete anything from the database.

I have worked around it abit but still not working. Could you please help me to see what i am doing wrong here? im sure mysql is fine, surely there is something wrong im doing in my php

many thanks and merry xmas in advance.

View Messeges page:

<?php

session_start();

include ("../global.php");
//welcome messaage
$username=$_SESSION['username'];
echo "$username";

$query=mysql_query("SELECT id FROM users WHERE username='$username'");
while($row = mysql_fetch_assoc($query))
{
$user_id = $row['id'];
echo $id;
}
//get pageinatio in each page
$per_page=5;
/*
if( intval($_GET['start']) < 1 ) {
     $start = 0;
} else {
     $start = (int) $_GET['start'];
}
*/

$start=$_GET['start'];
$record_count =mysql_num_rows(mysql_query("SELECT * FROM msg"));


$max_page=$record_count/$per_page;

if(!$start)
$start=0;

$result= mysql_query("SELECT * FROM msg LIMIT $start, $per_page");

while($row = mysql_fetch_assoc($result))
{








$title=$row['title'];
$id_rent=$row['id_msg'];
?>
<table>


<tr>










<td><? echo $id_msg; ?></td>
        <td><? echo $title; ?></td>








<td><?php echo "<a href='delete-msg.php?msg={$row['id_msg']}'>" ?>Delete</a></td></tr>
        </tr>






</table>





<?php










//while





} 



$prev=$start - $per_page;
$next=$start + $per_page;













if(!($start<=0))






echo



"<a href='view-msgs?start=$prev'>Previous</a>";




if(!($start>=$record_count-$per_page))



echo



"<a href='view-msgs.php?start=$next'>Next</a>";




mysql_close();
?>

delete-msg.php DELETE function page:

<?php

include ("../global.php");

$id=$_GET['id_msg'];






$result=mysql_query("DELETE FROM msg WHERE id_msg='$id'");






if($result){
echo "Deleted Successfully";
echo "<BR>";
echo "<a href='view-msg.php'>Back to main page</a>";
}

else {
echo "ERROR";
}

// close connection
mysql_close();


?>

dagon

look at theses 2 lines:

<?php echo "<a href='delete-msg.php?msg={$row['id_msg']}'>" ?>

delete page

$id=$_GET['id_msg'];

simcax77

Hi,

did you remember to connect to the database?

In addition I always add

OR DIE("MySQL error occured with sql $sql.<br>" . mysql_error();

for debugging cases like this, then you get the response from the database..

So something like:

mysql_query("SELECT id FROM users WHERE username='$username'") OR DIE("MySQL error...<br>" . mysql_error();

princeofpesia

yeah i am connected, I see the result from mysql perfectly

princeofpesia;10970802 wrote:
Hi guys, I have a table of messeges where listed from database. I have added a column (thanks to php freak forum) where users can delete msgs from the table, there are two pages, view messege page which lists the messeges and a delete function page (please see below)

All the connections are fine and pagination works perfectly, but when i press on delete it wont delete anything from the database.

I have worked around it abit but still not working. Could you please help me to see what i am doing wrong here? im sure mysql is fine, surely there is something wrong im doing in my php

many thanks and merry xmas in advance.

View Messeges page:
<?php

session_start();

include ("../global.php");
//welcome messaage
$username=$_SESSION['username'];
echo "$username";

$query=mysql_query("SELECT id FROM users WHERE username='$username'");
while($row = mysql_fetch_assoc($query))
{
$user_id = $row['id'];
echo $id;
}
//get pageinatio in each page
$per_page=5;
/*
if( intval($_GET['start']) < 1 ) {
     $start = 0;
} else {
     $start = (int) $_GET['start'];
}
*/

$start=$_GET['start'];
$record_count =mysql_num_rows(mysql_query("SELECT * FROM msg"));


$max_page=$record_count/$per_page;

if(!$start)
$start=0;

$result= mysql_query("SELECT * FROM msg LIMIT $start, $per_page");

while($row = mysql_fetch_assoc($result))
{








$title=$row['title'];
$id_rent=$row['id_msg'];
?>
<table>


<tr>










<td><? echo $id_msg; ?></td>
        <td><? echo $title; ?></td>








<td><?php echo "<a href='delete-msg.php?msg={$row['id_msg']}'>" ?>Delete</a></td></tr>
        </tr>






</table>





<?php










//while





} 



$prev=$start - $per_page;
$next=$start + $per_page;













if(!($start<=0))






echo



"<a href='view-msgs?start=$prev'>Previous</a>";




if(!($start>=$record_count-$per_page))



echo



"<a href='view-msgs.php?start=$next'>Next</a>";




mysql_close();
?>
delete-msg.php DELETE function page:
<?php

include ("../global.php");

$id=$_GET['id_msg'];






$result=mysql_query("DELETE FROM msg WHERE id_msg='$id'");






if($result){
echo "Deleted Successfully";
echo "<BR>";
echo "<a href='view-msg.php'>Back to main page</a>";
}

else {
echo "ERROR";
}

// close connection
mysql_close();


?>

princeofpesia

yes i did, i have the connection working fine.

dagon

did you fix the error i pointed out?

princeofpesia

i dont get any errors

princeofpesia

that code has wasted my time so i creates another table in my db and have the functionality in one page, but again it doesnt work

<?php

session_start();

include ("../global.php");
//welcome messaage
$username=$_SESSION['username'];
echo "$username";

$query=mysql_query("SELECT id FROM users WHERE username='$username'");
while($row = mysql_fetch_assoc($query))
{
$user_id = $row['id'];
echo $id;
}

$per_page=5;


$start=$_GET['start'];

$record_count =mysql_num_rows(mysql_query("SELECT * FROM rent"));
?>
<td><form name="form1" method="post" action=""> </td>
<?php
$max_page=$record_count/$per_page;

if(!$start)
$start=0;
$result= mysql_query("SELECT id, msg, title, reference FROM msg LIMIT $start, $per_page");
while($row = mysql_fetch_array($result))
{

$id=$row['id'];
$msg=$row['msg'];
$reference=$row['reference'];
$title=$row['title'];

?>



<table>


<tr>
	<td align="center" bgcolor="#FFFFFF"><input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id']; ?>"></td> 
		<td><?php echo $title; ?></td>
        <td><?php echo $id; ?></td>
        <td><?php echo $reference; ?></td>
        <td><?php echo $msg; ?></td>


    </tr>

</table>
<tr>
<td colspan="5" align="center" bgcolor="#FFFFFF"><input name="delete" type="submit" id="delete" value="Delete"></td>
</tr>
		<?php

	//while
	} 


$prev=$start - $per_page;
$next=$start + $per_page;		



if(!($start<=0))	
	echo	"<a href='view-data.php?start=$prev'>Previous</a>";

if(!($start>=$record_count-$per_page))
	echo	"<a href='view-data.php?start=$next'>Next</a>";	
if(isset($_POST['delete']))
{
    for($i = 0; $i <= count($_POST['checkbox']); $i++)
    {
        $del_id = $checkbox[$i];
        $sql = "DELETE FROM rent WHERE id='$del_id'";
        $result = mysql_query($sql);
    }


if($result)
{
    header('Location: view-data.php');
}
} 
?>

</table>
</form>

bradgrafelman

princeofpesia;10970829 wrote:
i dont get any errors

Well than that's because you aren't displaying errors and/or don't have error reporting set to E_ALL.

dagon pointed out a pretty critical error in his post above.

princeofpesia

i corrected those, and made another page to do the functionality with checkboxes (post above)

dagon

princeofpesia;10970833 wrote:
i corrected those, and made another page to do the functionality with checkboxes (post above)

same issue you're being sloppy with your variable names

<input name="checkbox[]" type="checkbox" id="checkbox[]" value="<? echo $rows['id']; ?>