Modules Php Parse error syntax error, unexpected $end

[omname]

Parse error: syntax error, unexpected $end in //includes/modules.php on line 92

1 <?php
2 //Shows a Module
3 function show_module($params)
4 {
5 if (!$result){
6 echo "SQL Failed :".$query;
7 die(mysql_error());
8 $view = $params['view'];
9 $action = $params['action'];
10 $id = $params['id'];
11 include(MODULES_PATH.$params['module'].'/controller.php');
12 }
13 else
14 {
15 return false;
16 }
17 //Check Module.
18 function is_module($module_name)
19 {
20 $connection = db_connect();
21 $query = sprintf("SELECT FROM modules WHERE name = '%s'",
22 mysql_real_escape_string($module_name));
23 $result = mysql_query($query);
24 //Checking Whether the Result is Empty.
25 $number_of_news = mysql_num_rows($result);
26 if ($number_of_news == 0)
27 {
28 return false;
29 }
30 return true;
31 }
32 //Returns the array of modules.
33 function list_modules()
34 {
35 $connection = db_connect();
36 $query = 'SELECT FROM modules WHERE system = 0';
37 $result = mysql_query($query);
38 //Checking Whether the Result is Empty.
39 $number_of_news = mysql_num_rows($result);
40 if ($number_of_news == 0)
41 {
42 return false;
43 }
44 $result = result_to_array($result);
45 return $result;
46 }
47 function list_modules_menu()
48 {
49 $connection = db_connect();
50 $query = 'SELECT * FROM modules WHERE show_menu = 1';
51 $result = mysql_query($query);
52 //Checking Whether the Result is Empty.
53 $number_of_news = mysql_num_rows($result);
54 if ($number_of_news == 0)
55 {
56 return false;
57 }
58 $result = result_to_array($result);
59 return $result;
60 }
61 //Load template.
62 function load_template($module,$view)
63 {
64 if (file_exists(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php'))
65 {
66 include_once(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php');
67 }
68 elseif (file_exists(TEMPLATE_PATH.'modules/'.$module.'/index.php'))
69 {
70 include_once(TEMPLATE_PATH.'modules/'.$module.'/index.php');
71 }
72 elseif (file_exists(TEMPLATE_PATH.'index.php'))
73 {
74 include_once(TEMPLATE_PATH.'index.php');
75 }
76 elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php'))
77 {
78 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php');
79 }
80 elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php'))
81 {
82 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php');

83 }
84 elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php'))
85 {
86 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php');
87 }
88 else
89 {
90 include_once(ERROR_PAGE);
91 }
92 ?>

[omname]

The code posted above was pasted, numbered, copied and posted here to show line numbers, so it might appear badly formated. The code is reposted below as a copy from the editor:

<?php
//Shows a Module
function show_module($params)
{
   if (!$result){
echo "SQL Failed:".$query;
die(mysql_error());
   $view = $params['view'];
   $action = $params['action'];
   $id = $params['id'];
   include(MODULES_PATH.$params['module'].'/controller.php');
   }
   else
   {
   return false;
   }
//Check Module.
function is_module($module_name)
 {
  $connection = db_connect();		
  $query = sprintf("SELECT * FROM modules WHERE name = '%s'",
                    mysql_real_escape_string($module_name));		
			$result = mysql_query($query);
  //Checking Whether the Result is Empty.
			$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;
			}
			return true;
 }
//Returns the array of modules.
function list_modules()
 {
  $connection = db_connect();			
  $query = 'SELECT * FROM modules WHERE system = 0';
			$result = mysql_query($query);
  //Checking Whether the Result is Empty.
			$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;
			}
			$result = result_to_array($result);
			return $result;
 }
function list_modules_menu()
 {
  $connection = db_connect();		
  $query = 'SELECT * FROM modules WHERE show_menu = 1';
			$result = mysql_query($query);
  //Checking Whether the Result is Empty.
			$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;
			}
			$result = result_to_array($result);
			return $result;
 }
 //Load template.
function load_template($module,$view)
{
 if (file_exists(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php'))
 {
 include_once(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php');
 }
elseif (file_exists(TEMPLATE_PATH.'modules/'.$module.'/index.php'))
 {
 include_once(TEMPLATE_PATH.'modules/'.$module.'/index.php');
 }
elseif (file_exists(TEMPLATE_PATH.'index.php'))
 {
 include_once(TEMPLATE_PATH.'index.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php');
 }
else
 {
 include_once(ERROR_PAGE);
 }
 ?>

[bradgrafelman]

When posting PHP code, please use the board's [noparse]

..

[/noparse] bbcode tags as they make your code much easier to read and analyze. In addition, there is a stickied thread entitled Parse Error: syntax error in the Coding forum dedicated to this issue.

As for your problem, neither the show_module() nor load_template() functions have a closing '}'.

[omname]

As for your problem, neither the show_module() nor load_template() functions have a closing '}'.[/QUOTE]

I added curly braced in line 17 and 93 to close show_module and load_modulte functions as shown in the revised code below, with different error messages now.

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in /home/istudio/public_html/school/openschool/includes/modules.php on line 26

Warning: include_once(ERROR_PAGE) [function.include-once]: failed to open stream: No such file or directory in /home/istudio/public_html/school/openschool/includes/modules.php on line 91

Warning: include_once() [function.include]: Failed opening 'ERROR_PAGE' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/istudio/public_html/school/openschool/includes/modules.php on line 91

<?php
//Shows a Module
function show_module($params)
{
   if (!$result){
echo "SQL Failed:".$query;
die(mysql_error());
   $view = $params['view'];
   $action = $params['action'];
   $id = $params['id'];
   include(MODULES_PATH.$params['module'].'/controller.php');
   }
   else
   {
   return false;
   }
   }
//Check Module.
function is_module($module_name)
 {
  $connection = db_connect();		
  $query = sprintf("SELECT * FROM modules WHERE name = '%s'",
                    mysql_real_escape_string($module_name));		
			$result = mysql_query($query);
  //Checking Whether the Result is Empty.
			$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;
			}
			return true;
 }
//Returns the array of modules.
function list_modules()
 {
  $connection = db_connect();			
  $query = 'SELECT * FROM modules WHERE system = 0';
			$result = mysql_query($query);
  //Checking Whether the Result is Empty.
			$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;
			}
			$result = result_to_array($result);
			return $result;
 }
function list_modules_menu()
 {
  $connection = db_connect();		
  $query = 'SELECT * FROM modules WHERE show_menu = 1';
			$result = mysql_query($query);
  //Checking Whether the Result is Empty.
			$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;
			}
			$result = result_to_array($result);
			return $result;
 }
 //Load template.
function load_template($module,$view)
{
 if (file_exists(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php'))
 {
 include_once(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php');
 }
elseif (file_exists(TEMPLATE_PATH.'modules/'.$module.'/index.php'))
 {
 include_once(TEMPLATE_PATH.'modules/'.$module.'/index.php');
 }
elseif (file_exists(TEMPLATE_PATH.'index.php'))
 {
 include_once(TEMPLATE_PATH.'index.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php');
 }
else
 {
 include_once(ERROR_PAGE);
 }
 }
 ?>

[bradgrafelman]

The first error suggests that your query didn't execute properly (since [man]mysql_query/man returns boolean FALSE if an error occurs, and the error message states you passed the function a boolean value). As such, use [man]mysql_error/man when debugging to retrieve the actual SQL error message for the failing query.

The other error messages suggest that ERROR_PAGE isn't a defined constant with the path to an error page (which, I'm assuming, it is expected to be).

[omname]

I have changed the ERROR_PAGE line as

include_once(ERROR_PAGE.'/error.php');

Now there is only one error

Parse error: syntax error, unexpected '}' in /modules.php on line 30

Line 25-38

//Checking Whether the Result is Empty.

$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;TEMPLATE_PATH
//next line is line30 which has the error
			  }
			  return true;
 }
//Returns the array of modules.
function list_modules()
 {
  $connection = db_connect();			
  $query = 'SELECT * FROM modules WHERE system = 0';
			$result = mysql_query($query);

[bradgrafelman]

Er.. isn't it obvious? Look at the preceding line... 'TEMPLATE_PATH' is thrown in there with no apparent purpose (other than to cause a parse error, of course).

[omname]

Thank you for helping me on this.

I removed TEMPLATE_PATH in line 29 to make it look like

return false;

This only complicates the issue as there are three error messages now, up from 1:

Warning: mysql_num_rows() expects parameter 1 to be resource, boolean given in /home/istudio/public_html/school/openschool/includes/modules.php on line 26

Warning: include_once(ERROR_PAGE/error.php) [function.include-once]: failed to open stream: No such file or directory in /home/istudio/public_html/school/openschool/includes/modules.php on line 91

Warning: include_once() [function.include]: Failed opening 'ERROR_PAGE/error.php' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/istudio/public_html/school/openschool/includes/modules.php on line 91

[bradgrafelman]

Already offered suggestions for those three error messages - see my previous post above (post #5 in the thread).

[omname]

Yes, Post # 5 offered a solution, I did not know what to do on the my sql error but I defined the path to ERROR-PAGE as

include_once(ERROR_PAGE.'/error.php');

After that the error message relating to ERROR-PAGE was gone, with only one error, pertaining to the hanging TEMPLATE_PATH in line 29. When that was removed, the ERROR_PAGE line again becomes a problem and the my sql error appears out of nowhere. This is what is puzzling.

(And I don't know what to do with your instructions pertaining to the mysql errors, I don't have an idea of what to change, where, to correct the mysql error)

The following are the lines pertaining to the present error messages.

//Checking Whether the Result is Empty. Next line is line 26, with the error
			$number_of_news = mysql_num_rows($result);
			if ($number_of_news == 0)
			{
			  return false;
			  }
			  return true;
 }

//next are lines 90-92

 {
 include_once(ERROR_PAGE.'/error.php');
 }

[bradgrafelman]

omname wrote:

I defined the path to ERROR-PAGE as

include_once(ERROR_PAGE.'/error.php'); 

That code doesn't define any constants - it tries to use the value of an undefined constant. You use the [man]define/man function to define a constant.

omname wrote:

(And I don't know what to do with your instructions pertaining to the mysql errors, I don't have an idea of what to change, where, to correct the mysql error)

We don't have an idea either, since we don't even know what the MySQL error is yet. See the PHP manual page for [man]mysql_query/man - the first coding example shows how you should be checking the return value of [man]mysql_query/man to handle errors. For debugging purposes, you'd want to output the value of [man]mysql_error/man when a query fails so that you can see the MySQL error message. It can also often be beneficial to output the entire SQL query string itself so you can visually inspect it.

[omname]

bradgrafelman;10971102 wrote:

We don't have an idea either, since we don't even know what the MySQL error is yet. See the PHP manual page for [man]mysql_query/man - the first coding example shows how you should be checking the return value of [man]mysql_query/man to handle errors. For debugging purposes, you'd want to output the value of [man]mysql_error/man when a query fails so that you can see the MySQL error message. It can also often be beneficial to output the entire SQL query string itself so you can visually inspect it.

The PHP error was very possibly due to a fundamental step that I had missed. There was a database data file os.sql, that had to be run with the command install/os.sql. I did that and the db error no longer appears (at least with the present set of code corrections)

bradgrafelman;10971102 wrote:

That code doesn't define any constants - it tries to use the value of an undefined constant. You use the [man]define/man function to define a constant.

I don't know what to do. I changed it to

include_once(TEMPLATE_PATH.'error.php');

And I created error.php page where it is missing. Now the error.php file is in the following directories;

/public_html/school/openschool/error.php

/public_html/school/openschool/includes/error.php

/public_html/school/openschool/templates/oslite/error.php

/public_html/school/openschool/templates/oslite/modules/os_pages/error.php

(I assumed that the problem could also be because the file error.php is not found, so created the file, some of which are unnessary)

Now the errors are:

Warning: include_once(/home/istudio/public_html/app/templates/oslite/error.php) [function.include-once]: failed to open stream: No such file or directory in /home/istudio/public_html/school/openschool/includes/modules.php on line 91

Warning: include_once() [function.include]: Failed opening '/home/istudio/public_html/app/templates/oslite/error.php' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/istudio/public_html/school/openschool/includes/modules.php on line 91

The code pertaining to the error:

 //Load template.
function load_template($module,$view)
{
 if (file_exists(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php'))
 {
 include_once(TEMPLATE_PATH.'modules/'.$module.'/'.$view.'.php');
 }
elseif (file_exists(TEMPLATE_PATH.'modules/'.$module.'/index.php'))
 {
 include_once(TEMPLATE_PATH.'modules/'.$module.'/index.php');
 }
elseif (file_exists(TEMPLATE_PATH.'index.php'))
 {
 include_once(TEMPLATE_PATH.'index.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.$view.'.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/modules/'.$module.'/'.'index.php');
 }
elseif (file_exists(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php'))
 {
 include_once(SERVER_ROOT.APP_ROOT.'/templates/oslite/index.php');
 }
else
 {
//next line is line 90
 include_once(TEMPLATE_PATH.'error.php');
 }
 }
 ?>

Thank You for all the help so far.

[bradgrafelman]

Well the error message is fairly self-explanatory; it couldn't find error.php where you told it to look, and it even gives you the full path that you supplied. So... put error.php in the correct location (or, if the location is incorrect, supply the correct location in the code).

[omname]

bradgrafelman;10971120 wrote:

Well the error message is fairly self-explanatory; it couldn't find error.php where you told it to look, and it even gives you the full path that you supplied. So... put error.php in the correct location (or, if the location is incorrect, supply the correct location in the code).

The error message showed a non-existent path /public_html/app/... There was no folder named app under public_html, created a folder, copied the template folder from /public_html/school/openschool which is the default folder for this web application. Now the error message says:

SQL Failed:

This takes me closer to the solution 🙂 because there are no more php errors ?