Photos

worsethenu

Hey guys, I have a path stored in the DB to whichever image i want to display. Using the code below I get the default image all the time when I echo it out in my div. If i echo $photo i get the correct path back. Why would i not get the image? I've checked permissions and they are good. I've tried googling around and haven't been able to find anything to help.

$sql = mysql_query("SELECT * FROM DB WHERE id='1'");
while($row = mysql_fetch_array($sql)){ 

$photo = $row["db_photo_path"];
}

$cacheBuster = rand(999999999,9999999999999); 


$default_pic = "pics/image01.jpg";

if (file_exists($photo)) {

$pic1 = "<img src=\"$photo?$cacheBuster\" width=\"275px\" />"; 

} else {

$pic1 = "<img src=\"$default_pic\" width=\"275px\" />"; 

}

<div>
<?php echo $pic1;?>     //always gives default img
</div>

bradgrafelman

First off - why the while() loop? If you're only expecting at most 1 row, then there's no point in having a loop.

Secondly, don't use 'SELECT *' - only SELECT the columns from which you actually need data.

Finally, do a [man]var_dump/man on $photo after it's retrieved from the DB - what do you get?

worsethenu

Thanks, i've been working with PHP & MYSQL for 36 hours now, so while loops are about all i know and i think i may want to pull more data later. If there's a better way please lemme know what it is cause i would love to learn more.

Result of var_dump are as expected:
string(24) "pics/image02.jpg"

if not SELECT then what should i use? Most of the tuts i've seen use SELECT.

thanks again

bradgrafelman

worsethenu;10971857 wrote:
If there's a better way please lemme know what it is cause i would love to learn more.

Well if you're going to be pulling more than one row at a later date, then by all means - leave the while loop in there. If you're ever in a situation where you only expect a single row, however, there's no need for a loop (since loops are meant to be run multiple times until some stop condition is met) - just call the appropriate fetch function (e.g. whatever is in the body of the while loop) a single time and use the data.

Result of var_dump are as expected:
string(24) "pics/image02.jpg"

worsethenu;10971857 wrote:
if not SELECT then what should i use? Most of the tuts i've seen use SELECT.

I wasn't suggesting that you use a different query altogether - SELECT is what you're wanting. I was instead suggesting that the '*' is what should be changed; you should instead list the columns that you need data from, e.g. "SELECT col1, col2, ... FROM myTable" .

As for your problem, try adding this code before the if() statement to get some additional information:

error_reporting(E_ALL);
ini_set('display_errors', 'On');
var_dump( is_readable("pics/") );
var_dump( is_readable($photo) );

Let us know what output that produces (including any PHP error messages, if applicable).