Isset Question

NZ_Kiwis

if (isset($_POST['username'])){
	echo "no username or password";
} else {
	echo $_POST['username'];
}

even if i enter a username or not i always get no username and password, what is wrong with this?

THis is my HTML

    <form action="login.php" method="post">
	<label class="BlackNormal">Username: <input class="BlackNormal" name="username" type="text" size="30" maxlength="30" /></label><br />
	<label class="BlackNormal">Password: <input class="BlackNormal" name="password" type="password" size="30" maxlength="30" /></label><br />
	<input class="BlackNormal" name="" type="submit" value="Login" /> <label class="BlackNormal">Register</label>

</form>

bradgrafelman

Not typing anything into a form field doesn't mean it isn't set. Your browser is going to include every non-disabled form element when it POST's data... the empty string is a perfectly valid value to set a form entity to.

NZ_Kiwis

how can i tell if it holds a value then?

iostreamax

try to use this code,

if (empty($POST['username'])){
echo "no username or password";
} else {
echo $POST['username'];
}

bradgrafelman

In other words, [man]empty/man may be an alternative.

An even better one would be to compare the value to the empty string if it is set, since [man]empty/man can return true for what may truly be non-empty data.

DaveRandom

So to amalgamate all the info from above:

if (!isset($_POST['username'])){
  echo "Invalid request";
} else if ($_POST['username'] == '') {
  echo "No username entered";
} else {
  echo "Your username is ".$_POST['username'];
}

Really, it would be better to validate the user entry with Javascript before allowing the form to be submitted.

dewcansam

again with the agreeing with the Dave !!

DaveRandom

I have the terrible affliction of being a bit good. It has affected me since birth... 😛