retrieve data if,else or switch case ? how to

[CrOuZ]

i have any page for show video / images / map .
now i change my code to ajax external loading . now for speed up how to join images/video/map to one file for retrieve result.
example:
mydomain/media.php?m=video&id=10

mydomain/media.php?m=images&id=15

mydomain/media.php?m=map&id=7

Better and faster is : else,if Or switch,case ?? how to ?

thanks

[DaveRandom]

With either if/else or switch/case you will have to modify your script every time you add/remove a file.

Far better to query a database and get the data from there.

e.g. (MySQL)

  // Query the database
  $result = mysql_query("SELECT `file_path` FROM `table` WHERE `file_type` = '".$_GET['m']."' AND `file_id` = '".$_GET['id']."' LIMIT 0,1");
  // check that a record was found
  if (mysql_num_rows($result) < 1) exit("Could not find the requested file"); else $result = mysql_fetch_array($result);
  // serve the file
  readfile($result['file_path']);

There is a lot missing from that code but hopefully it should give you something to build on.

[CrOuZ]

I have 3 table no 1 table and filetype.

| id | url | articleid | // for video
| id | url | articleid | // for images
| id | ur l| articleid | // for map

i add for each article id any video / images gallery / map etc . . . . .

[anakadote]

If you pass the table name you can still use DaveRandom's suggestion. Otherwise, use a conditional statement.

$table = mysql_real_escape_string($_GET['m']);
$id = (int) $_GET['id'];

$query = "SELECT * FROM `{$table}` WHERE `id`=$id LIMIT 1";

or

$type = mysql_real_escape_string($_GET['m']);
$id = (int) $_GET['id'];

switch($type){
case 'video' :
   $query = "SELECT * FROM `videos` WHERE `id`=$id LIMIT 1";
   break;
case 'images' :
   $query = "SELECT * FROM `images` WHERE `id`=$id LIMIT 1";
   break;
case 'maps' :
   $query = "SELECT * FROM `maps` WHERE `id`=$id LIMIT 1";
   break;
default :
   die('Invalid media type');
}

[CrOuZ]

DaveRandom , anakadote Thanks Both. So Switch case is faster and better .

[DaveRandom]

CrOuZ wrote:

So Switch case is faster and better

Be careful with statements like this you may regret them... 😃

Switch is a powerful tool with many and varied possibilties, much greater than many people realise - I highly recommend everyone read this thoroughly insightful comment on the PHP manual page - but it won't do everything.

Overall, a switch structure will probably take more CPU cycles to get the same job done, as it effectively does more comparisons due to the fact it is really a looping structure. Sometimes a well written elseif tree is just the ticket - it takes careful consideration to decide which is best for any given task.

Remember, pretty code is not necessarily efficient code...