[RESOLVED] Error Saying Undefined Index

Majeste

Hi,

I'm new in PHP and trying to build a dynamic web site for now. I use if statement to include php files into my content div by this code.

<?php
	$p = $_GET['p'];

if ( !empty($p) && file_exists('./pages/' . $p . '.php') && stristr( $p, '.' ) == false )
	{
	$file = './pages/' . $p . '.php';
	}
	else
	{
	$file = './pages/home.php';
	}

include $file;
?>

Everything is fine when I access web site with "?p=something" but when the URL is just index.php it says "Notice: Undefined index: p in C:\wamp\www\php_website\index.php on line 16". The line is the second written here in php code.

I got this code from here. What may be the problem?

Thanks.

DaveRandom

Try...

<?php 

  if (isset($_GET['p']) && file_exists('./pages/' . $_GET['p'] . '.php') && strpos( $_GET['p'], '.' ) === false ) { 
    $file = './pages/' . $p . '.php'; 
  } else $file = './pages/home.php'; 

  include $file; 

?>

PHP Manual wrote:
From the strstr() page: If you only want to determine if a particular needle occurs within haystack, use the faster and less memory intensive function strpos() instead.

Majeste

Thanks DaveRandom. It works now. 🙂

Majeste

I couldn't edit my post 🙁 sorry for flood.

I want to share the trick for the ones who cannot solve this like me.

Instead of using variable "$p", DaveRandom put "$_GET['p']" inside the code.

Finally,

<?php

if ( isset($_GET['p']) && file_exists('./pages/' . $_GET['p'] . '.php') && strpos( $_GET['p'], '.' ) == false )
	{
	$file = './pages/' . $_GET['p'] . '.php';
	}
	else
	{
	$file = './pages/home.php';
	}

include $file;

?>

DaveRandom

No probs.

The problem was with the

$p = $_GET['p'];

line - if you haven't passed the ?p=whatever in the URL, the variable $_GET['p'] is not set. If you test that it has been set before you try and use it with isset() you will avoid error messages like the one you were getting.

You can also call

error_reporting(0);

to stop errors from being written to output.

Majeste

The final function is also great. 🙂 But of course, I should get rid of errors.

bradgrafelman

Don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu above.

Majeste

bradgrafelman;10973063 wrote:
Don't forget to mark this thread resolved (if it is) using the link on the Thread Tools menu above.

I was trying to find a way to do this 🙂 Thank you. I guess I should read forum guide before posting.