Helping with a form

siabanie

I have two forms, one is create page and the other is modify page which work fine. These forms using $_POST to passing the values from the database extract them to the next confirmation page before it being submitted.

I wonder, if there is a way I can merge these two forms so I only have one form but does two different things. I would like to use sessions on this new form.

Can anyone give me an ideas?

DaveRandom

We would need to see code/web pages before anyone can offer any suggestions for this.

What you ask is possible, but there are many ways of doing it, depending what you have already.

siabanie

Ok here are two of my form codes: Basically I like to use if/elseif, can someone please explain to me how these two form here can combine together so it will only have one form but do two different function (create and modify form). Then after these form being edit or create - it will go to another different page which is the confirmation page using sessions.

modify form code

<?php

require 'includes/application.php';    
//Define
$name = "";
$surname = "";
$add = "";
$dept= "";
$mobile = "";

if (!isset($_POST['goSubmit']))
{

    $q = "SELECT * FROM persons WHERE ID = $_GET[id]";

    $result = mysql_query($q) or die (mysql_error());
    $row = mysql_fetch_array($result);

    $name = $row['name'];
    $surname = $row['surname'];
    $address = $row['address'];
    $dept = $row['dept_id'];
    $mobile = $row['mobile'];

    }

if (isset($_POST['goSubmit']))
{
    $name = $_POST['name'];
    $surname = $_POST['surname'];
    $address = $_POST['address'];
    $dept = $_POST['dept'];
    $mobile = $_POST['mobile'];

    $errormsg = "";

    if($name == "")
        $errormsg = $errormsg. "Name<br/ >";

    if ($surname == "")
        $errormsg = $errormsg. "Surname Please <br/ >";

    if ($mobile != "" && !is_numeric ($mobile))
        $errormsg = $errormsg. "Mobile No? <br/ >";

     if ($errormsg != "")
        echo "Please fill the blank info: <br/ > $errormsg";

        else
        {
            $input_field = "";


            foreach ($_POST as $key => $val)
            {
                if ($key != 'goSubmit')
                {
                $_SESSION[$key] = $val;
                }
            }

             header("Location: confirmPage.php");
        }        
}   

?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Modify Document</title>
</head>

<body>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
  <div align="center">
  <table width="300" border="1">
    <h1> Modifying A User </h1>

  <tr>
    <th scope="row">Name</th>
    <td><input type="text" name="name" value="<?php echo $name;?>" /></td>
  </tr>

<tr>
  <th scope="row">Surname</th>
    <td>
    <input type="text" name="surname" value="<?php echo $surname; ?>" /></td>
  </tr>

<tr>
  <th scope="row">Address</th>
    <td><input type="text" name="address" value="<?php echo $address; ?>" /></td>
</tr>


<tr>
  <th scope="row">Department</th>
    <td>

    <select name="dept">
        <option value="">Select..</option>

    <?php
    $data = mysql_query ("SELECT * FROM dept ORDER BY `id` DESC") or die (mysql_error());

      echo $data;

        while($row_dept = mysql_fetch_array( $data ))
    {
    ?>
    <option value="<?php echo $row_dept['id'] ;?>" <?php if($row_dept['id']==$dept){echo ' selected="selected"';}?>>
    <?php echo $row_dept['dept_name'] ;?>
    </option>

<?php
}
?>
    </select>
    </td>
</tr>

<tr>
  <th scope="row">Mobile</th>
    <td><input type="text" name="mobile" value="<?php echo $mobile; ?>" /></td>
  </tr>

  </table>
  <br/>

  <a href="indexPage.php">
    <input type="button" name="back" value="Back" /></a>

<input type="hidden" name="id" value="<?php echo $_GET['id']; ?>">

<input type="submit" name="goSubmit" value="Modify"/>

  </div>
</form>

</body>
</html>

create form page

<?php

require 'includes/application.php';    
//Define
$name = "";
$surname = "";
$address = "";
$dept= "";
$mobile = "";

// isset determine if a varaible is set



if (isset($_POST['goSubmit']))
{
    $name = $_POST['name'];
    $surname = $_POST['surname'];
    $address = $_POST['address'];
    $dept = $_POST['dept'];
    $mobile = $_POST['mobile'];

print_r($_POST);

    $errormsg = "";

    if($name == "")
        $errormsg = $errormsg. "Name<br/ >";

    if ($surname == "")
        $errormsg = $errormsg. "Surname Please <br/ >";

    if ($mobile != "" && !is_numeric ($mobile))
        $errormsg = $errormsg. "Mobile No? <br/ >";

     if ($errormsg != "")
        echo "Please fill the blank info: <br/ > $errormsg";

        else
        {
            $input_field = "";


            foreach ($_POST as $key => $val)
            {
                if ($key != 'goSubmit')
                {
                $_SESSION[$key] = $val;

                }
            }

             header("Location: confirmPage.php");

        }        
}   


?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Modify Document</title>
</head>

<body>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
  <div align="center">
  <table width="300" border="1">
    <h1> Modifying A User </h1>

  <tr>
    <th scope="row">Name</th>
    <td><input type="text" name="name" value="<?php echo $name;?>" /></td>
  </tr>

<tr>
  <th scope="row">Surname</th>
    <td>
    <input type="text" name="surname" value="<?php echo $surname; ?>" /></td>
  </tr>

<tr>
  <th scope="row">Address</th>
    <td><input type="text" name="address" value="<?php echo $address; ?>" /></td>
</tr>


<tr>
  <th scope="row">Department</th>
    <td>

    <select name="dept">
        <option value="">Select..</option>

    <?php
    $data = mysql_query ("SELECT * FROM dept ORDER BY `id` DESC") or die (mysql_error());

      echo $data;

        while($row_dept = mysql_fetch_array( $data ))
    {
    ?>
    <option value="<?php echo $row_dept['id'] ;?>" <?php if($row_dept['id']==$dept){echo ' selected="selected"';}?>>
    <?php echo $row_dept['dept_name'] ;?>
    </option>

<?php
}
?>
    </select>
    </td>
</tr>

<tr>
  <th scope="row">Mobile</th>
    <td><input type="text" name="mobile" value="<?php echo $mobile; ?>" /></td>
  </tr>

  </table>
  <br/>

  <a href="indexPage.php">
    <input type="button" name="back" value="Back" /></a>

<input type="hidden" name="id" value="<?php echo $_GET['id']; ?>">

<input type="submit" name="goSubmit" value="Modify"/>

  </div>
</form>
</body>
</html>

I was thinking something like these condition to do the forms but I am not exactly sure... - But after this page another confirmation page will appear once the button submitted is click.

if (isset($_GET['id']) == $id) {
  //do the modify query 
  //display the modify form
} else if (isset ($_GET ['id'] == NULL) {
  //display the form where user can fill up the form
}

OR, can I do like this instead:

if (isset ($_GET['id'])) {
  $_SESSION ['page'] = 'modify';
  //perform the modify form
} else if (isset($_GET['id'])) {
  $_SESSION ['page'] = 'create';
 //perform the create form
}

siabanie

modify form code

<?php

require 'includes/application.php';    
//Define
$name = "";
$surname = "";
$add = "";
$dept= "";
$mobile = "";

if (!isset($_POST['goSubmit']))
{

    $q = "SELECT * FROM persons WHERE ID = $_GET[id]";

    $result = mysql_query($q) or die (mysql_error());
    $row = mysql_fetch_array($result);

    $name = $row['name'];
    $surname = $row['surname'];
    $address = $row['address'];
    $dept = $row['dept_id'];
    $mobile = $row['mobile'];

    }

if (isset($_POST['goSubmit']))
{
    $name = $_POST['name'];
    $surname = $_POST['surname'];
    $address = $_POST['address'];
    $dept = $_POST['dept'];
    $mobile = $_POST['mobile'];

    $errormsg = "";

    if($name == "")
        $errormsg = $errormsg. "Name<br/ >";

    if ($surname == "")
        $errormsg = $errormsg. "Surname Please <br/ >";

    if ($mobile != "" && !is_numeric ($mobile))
        $errormsg = $errormsg. "Mobile No? <br/ >";

     if ($errormsg != "")
        echo "Please fill the blank info: <br/ > $errormsg";

        else
        {
            $input_field = "";


            foreach ($_POST as $key => $val)
            {
                if ($key != 'goSubmit')
                {
                $_SESSION[$key] = $val;
                }
            }

             header("Location: confirmPage.php");
        }        
}   

?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Modify Document</title>
</head>

<body>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
  <div align="center">
  <table width="300" border="1">
    <h1> Modifying A User </h1>

  <tr>
    <th scope="row">Name</th>
    <td><input type="text" name="name" value="<?php echo $name;?>" /></td>
  </tr>

<tr>
  <th scope="row">Surname</th>
    <td>
    <input type="text" name="surname" value="<?php echo $surname; ?>" /></td>
  </tr>

<tr>
  <th scope="row">Address</th>
    <td><input type="text" name="address" value="<?php echo $address; ?>" /></td>
</tr>


<tr>
  <th scope="row">Department</th>
    <td>

    <select name="dept">
        <option value="">Select..</option>

    <?php
    $data = mysql_query ("SELECT * FROM dept ORDER BY `id` DESC") or die (mysql_error());

      echo $data;

        while($row_dept = mysql_fetch_array( $data ))
    {
    ?>
    <option value="<?php echo $row_dept['id'] ;?>" <?php if($row_dept['id']==$dept){echo ' selected="selected"';}?>>
    <?php echo $row_dept['dept_name'] ;?>
    </option>

<?php
}
?>
    </select>
    </td>
</tr>

<tr>
  <th scope="row">Mobile</th>
    <td><input type="text" name="mobile" value="<?php echo $mobile; ?>" /></td>
  </tr>

  </table>
  <br/>

  <a href="indexPage.php">
    <input type="button" name="back" value="Back" /></a>

<input type="hidden" name="id" value="<?php echo $_GET['id']; ?>">

<input type="submit" name="goSubmit" value="Modify"/>

  </div>
</form>

</body>
</html>

create form page

<?php

require 'includes/application.php';    
//Define
$name = "";
$surname = "";
$address = "";
$dept= "";
$mobile = "";

// isset determine if a varaible is set



if (isset($_POST['goSubmit']))
{
    $name = $_POST['name'];
    $surname = $_POST['surname'];
    $address = $_POST['address'];
    $dept = $_POST['dept'];
    $mobile = $_POST['mobile'];

print_r($_POST);

    $errormsg = "";

    if($name == "")
        $errormsg = $errormsg. "Name<br/ >";

    if ($surname == "")
        $errormsg = $errormsg. "Surname Please <br/ >";

    if ($mobile != "" && !is_numeric ($mobile))
        $errormsg = $errormsg. "Mobile No? <br/ >";

     if ($errormsg != "")
        echo "Please fill the blank info: <br/ > $errormsg";

        else
        {
            $input_field = "";


            foreach ($_POST as $key => $val)
            {
                if ($key != 'goSubmit')
                {
                $_SESSION[$key] = $val;

                }
            }

             header("Location: confirmPage.php");

        }        
}   


?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Modify Document</title>
</head>

<body>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
  <div align="center">
  <table width="300" border="1">
    <h1> Modifying A User </h1>

  <tr>
    <th scope="row">Name</th>
    <td><input type="text" name="name" value="<?php echo $name;?>" /></td>
  </tr>

<tr>
  <th scope="row">Surname</th>
    <td>
    <input type="text" name="surname" value="<?php echo $surname; ?>" /></td>
  </tr>

<tr>
  <th scope="row">Address</th>
    <td><input type="text" name="address" value="<?php echo $address; ?>" /></td>
</tr>


<tr>
  <th scope="row">Department</th>
    <td>

    <select name="dept">
        <option value="">Select..</option>

    <?php
    $data = mysql_query ("SELECT * FROM dept ORDER BY `id` DESC") or die (mysql_error());

      echo $data;

        while($row_dept = mysql_fetch_array( $data ))
    {
    ?>
    <option value="<?php echo $row_dept['id'] ;?>" <?php if($row_dept['id']==$dept){echo ' selected="selected"';}?>>
    <?php echo $row_dept['dept_name'] ;?>
    </option>

<?php
}
?>
    </select>
    </td>
</tr>

<tr>
  <th scope="row">Mobile</th>
    <td><input type="text" name="mobile" value="<?php echo $mobile; ?>" /></td>
  </tr>

  </table>
  <br/>

  <a href="indexPage.php">
    <input type="button" name="back" value="Back" /></a>

<input type="hidden" name="id" value="<?php echo $_GET['id']; ?>">

<input type="submit" name="goSubmit" value="Modify"/>

  </div>
</form>
</body>
</html>

I was thinking something like these condition to do the forms but I am not exactly sure... - But after this page another confirmation page will appear once the button submitted is click.

if (isset($_GET['id']) == $id) {
  //do the modify query 
  //display the modify form
} else if (isset ($_GET ['id'] == NULL) {
  //display the form where user can fill up the form
}

OR, can I do like this instead:

if (isset ($_GET['id'])) {
  $_SESSION ['page'] = 'modify';
  //perform the modify form
} else if (isset($_GET['id'])) {
  $_SESSION ['page'] = 'create';
 //perform the create form
}

DaveRandom

<?php 

require 'includes/application.php';     

if (!isset($_POST['name']) && isset($_GET['id'])) { 

  // If $_POST['name'] is not set, but $_GET['id'] is, we can assume we are MODIFYING

  $mode = "Modifying";

  // Get data from DB

    $q = "SELECT * FROM `persons` WHERE `ID` = '".$_GET['id']."' LIMIT 0,1"; // Add a LIMIT clause in case records get duplicated...
    $result = mysql_query($q) or die (mysql_error()); 
    $row = mysql_fetch_array($result); 

    $name = $row['name']; 
    $surname = $row['surname']; 
    $address = $row['address']; 
    $dept = $row['dept_id']; 
    $mobile = $row['mobile']; 

} else if (!isset($_POST['name']) && !isset($_GET['id'])) { 

  // If $_POST['name'] is not set, and neither is $_GET['id'], we can assume we are CREATING

  $mode = "Creating";

  // Data is empty

  $name = $surname = $address = $dept = $mobile = "";

} else {

    // $_POST['name'] is set, we are handling a submission

    // Validate submitted data - build error message via an array to make it tidier
    $errors = array();
    if ($_POST['name'] == "") $errors[] = "Name"; 
    if ($_POST['surname'] == "") $errors[] = "Surname"; 
    if ($_POST['mobile'] == "" || !is_numeric ($_POST['mobile'])) $errors[] = "Mobile No"; 

    if (count($errors)) {

        // If there were errors, diplay the page again with error message and the submitted data

        $errormsg = "Please fill the blank info:<br/ >".implode('<br />',$errors);

        $mode = $_POST['mode']; 
        $name = $_POST['name']; 
        $surname = $_POST['surname']; 
        $address = $_POST['address']; 
        $dept = $_POST['dept']; 
        $mobile = $_POST['mobile'];         

    } else {

        // Otherwise store $_POST values into $_SESSION and redirect

        foreach ($_POST as $key => $val) $_SESSION[$key] = $val; 

        header("HTTP/1.1 303 See Other"); // This is the RIGHT way to redirect after a POST request
        header("Location: http://".$_SERVER['HTTP_HOST'].dirname($_SERVER['PHP_SELF'])."/confirmPage.php"); // This should really be a full URL, not a relative path

    }         

}    

?> 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> 
<html xmlns="http://www.w3.org/1999/xhtml"> 
<head> 
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> 
<title>Modify Document</title> 
</head> 

<body> 
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post"> 
  <?php if (isset($errormsg)) echo "<div id=\"error_message\" style=\"color:red;\">$errormsg</div>"; ?>
  <div align="center"> 
  <table width="300" border="1"> 
    <h1> <?php echo $mode; ?> A User </h1> 

  <tr> 
    <th scope="row">Name</th> 
    <td><input type="text" name="name" value="<?php echo $name;?>" /></td> 
  </tr> 

<tr> 
  <th scope="row">Surname</th> 
    <td> 
    <input type="text" name="surname" value="<?php echo $surname; ?>" /></td> 
  </tr> 

<tr> 
  <th scope="row">Address</th> 
    <td><input type="text" name="address" value="<?php echo $address; ?>" /></td> 
</tr> 


<tr> 
  <th scope="row">Department</th> 
    <td> 

    <select name="dept"> 
        <option value="">Select..</option> 

<?php 

$data = mysql_query ("SELECT * FROM `dept` ORDER BY `id` DESC") or die (mysql_error()); 
while($row_dept = mysql_fetch_array( $data )) { 

?> 
        <option value="<?php echo $row_dept['id'] ;?>" <?php if($row_dept['id']==$dept){echo ' selected="selected"';}?>> 
        <?php echo $row_dept['dept_name'] ;?> 
        </option> 

<?php 
   } 
?> 
        </select> 
        </td> 
    </tr> 

<tr> 
  <th scope="row">Mobile</th> 
    <td><input type="text" name="mobile" value="<?php echo $mobile; ?>" /></td> 
  </tr> 

  </table> 
  <br/> 

  <a href="indexPage.php"> 
    <input type="button" name="back" value="Back" /></a> 

<input type="hidden" name="id" value="<?php echo $_GET['id']; ?>"> 
<input type="hidden" name="mode" value="<?php echo $mode; ?>"> 

<input type="submit" value="<?php echo ($mode == "Creating") ? 'Create' : 'Modify'; ?>"/> 

  </div> 
</form> 

</body> 
</html>

Have a go with that, it's all commented where necessary.

If you are going to go to the trouble of declaring your document as XHTML (as you have commendably done) please Validate your Markup 😉

siabanie

Hi DaveRandom, thanks for the inputs. It works great as I wanted thanks, but I have few questions 😃,

Why you need to declaring this: $mode = "Modifying"; ? and $mode = "Creating"; ?

What is the 0, 1 here for? You said it prevent from duplication e.g?

$q = "SELECT * FROM `persons` WHERE `ID` = '".$_GET['id']."' LIMIT 0,1";

Why we need to use count function?
```
if (count($errors))
```
Can you please explain to me what this does: Is it mean that if var $mode equal to 'Creating' then perform create form blank page otherwise do modify?
```
<input type="submit" value="<?php echo ($mode == "Creating") ? 'Create' : 'Modify'; ?>"/> 
```

I'm creating a confirmation page where this page will have UPDATE and INSERT query and I am using sessions on here depends which form it is for before submitting them to the main page. Here is my code:

confirm Modify php

<?php
require 'includes/application.php';
		session_start();
		$id = (int)$_SESSION['id'];

	if (isset($_POST['submit'])) {

	$modify_sql = "UPDATE persons SET name = '".$_SESSION['name']."', surname = '".$_SESSION['surname']."', address = '".$_SESSION
	['address']."', mobile = '".$_SESSION['mobile']."', `dept_id`= '".$_SESSION['dept']."' WHERE persons.id = " . $id;

	$confirm_modify = mysql_query ($modify_sql) or die (mysql_error());		
	header("Location: indexPage.php?id=".$id."&page=modify");
	}

?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Confirm Create</title>
</head>

<body>

<form action="<?php echo $_SERVER['PHP_SELF'];?>" method="post">
<div align="center">
  <table width="200" border="1">
    <h1>Are You Happy With These Info?</h1>
    <tr>
      <th scope="row">First Name</th>
      <td><?php echo $_SESSION['name'];?> </td>
    </tr>

<tr>
  <th scope="row">Surname</th>
  <td><?php echo $_SESSION['surname'];?></td>
</tr>

<tr>
  <th scope="row">Address</th>
  <td><?php echo $_SESSION['address'];?></td>
</tr>


<!--Department Modify Form-->

   <tr>
      <th scope="row">Department</th> 
		<td>         

<?php


	// The id must be valid and exists from the modify page.
	// Syntax: SELECT column_name FROM table_name
	//$data = mysql_query ("SELECT * FROM dept ORDER BY `id` DESC") or die 
	$data = mysql_query ("SELECT dept_name FROM dept WHERE id = '".$_SESSION['dept']."'") or die (mysql_error());
   // print_r ($data);
		$row_dept= mysql_fetch_array( $data );
		//echo $row_dept;

  		$_SESSION['dept_name'] = $row_dept['dept_name'];
		echo $_SESSION['dept_name'];
		//echo $row_dept['dept_name']; // Display the name
	?>

	</td>
</tr>

<!--End Department-->
<tr>
  <th scope="row">Mobile</th>
  <td><?php echo $_SESSION['mobile'];?> </td>
</tr>

<tr>
<br/ >
<td colspan="2" align="center"><p>
    <input type="button" value="Back" onclick="history.go(-1)" />

	<?php 
	foreach ($_POST as $thislabel => $thisvalue)
		{		
			echo "<input type = 'hidden' name = '".$thislabel."' value = '" .$thisvalue."'/>";
		}
	?>
	<input type="submit" name="submit" value="Submit"/>
    </td>


 </table>

</div>
</form>
</body>
</html>

confirm Create php cut-down version:

..
	if (isset($_POST['submit'])) {


$create_sql = "INSERT INTO persons SET `Name`='$name', `Surname`='$surname', `dept_id`='$dept', `Address`='$add', `Mobile`='$mobile' ";

$confirm_create = mysql_query ($create_sql) or die (mysql_error());


//FROM persons LEFT JOIN dept ON persons.dept_id = dept.id WHERE persons.id = $_GET[id]";
header("Location: index.php?id=".mysql_insert_id()."&page=create");	
} 
...
...
<!--Department form-->
   <tr>
      <th scope="row">Department</th>
		<td>

	<select name="dept">
		<option value="">Select..</option>

	<?php
	$data = mysql_query ("SELECT * FROM dept ORDER BY `id` DESC") or die (mysql_error());

		while($row_dept = mysql_fetch_array( $data )) 
	{ 
	?>
	<option value="<?php echo $row_dept['id'] ;?>" <?php if($row_dept['id']==$dept){echo ' selected="selected"';}?>> 
	<?php echo $row_dept['dept_name'] ;?> 
	</option>

<?php
}
?>
	</select>
	</td>
</tr>
<!--End department form-->
...
...

and I would like to use javascript for the back button as when user press "Back" the values will remind there, something like this:

<input type="button" value="Back" onclick="history.go(-1)" />

but for some reason it does not work. Can you suggest how to merge these two confirmation page so I can only have one page which will be using UPDATE and INSERT query please?

DaveRandom

siabanie,

$mode defines the title of the page, and helps us track what we are doing - creating or modifying. You will notice this value follows with the form submission in the new type='hidden' input as well.
Since ID is (i presume) the primary key in the database, this is only really there to help catch errors in the database engine. If you end up with more than one entry in the table with the same ID, the LIMIT clause will only return the first result. It's non-essential for this, merely good practice.
By placing the errors into the array instead of building the string, you can use implode() to avoid the extra line break (<br />) tag that was always going to be there on the end of the string. The count function returns the number of items in the array, so if there are no errors, it will return 0, which evaluates to FALSE. If there were errors, it will return a no-zero value, which evaluates to TRUE. So
```
if (count($errors))
```
...is really saying "if there were any errors".
This syntax is known as a ternary operator. The code segment above uses the value of $mode to determine what the submit button should say on it... if the value of mode is 'Creating' the button will say 'Create' on it, otherwise in will say 'Modify'.

I will have a look at the confirmation page later on, I am little busy at the moment 😉

siabanie

DaveRandom, thanks again..

I have done some of the confirmation page but something was not right; Below is my attempt.

BTW, I found one error back at the post#5 - When I tried to click 'Create User' hyper-link on my main page (index page) it will take me to blank form page which is correct, but then when look at the source code (HTML), there is an error saying:

Notice:  Undefined index: id  on line 138

Line 138 shown here:

 <input type="hidden" name="id" value="<?php echo $_GET['id']; ?>">

As far as I understand we can delete these now, cant we?:

<input type="hidden" name="id" value="<?php echo $_GET['id']; ?>">
<input type="hidden" name="mode" value="<?php echo $mode; ?>">

as we already use the foreach function, am I make sense? as far as I know if we use foreach statement then no there no need the 'hidden' inputs anymore? Please correct me if am wrong.

This is my attempt, of the confirmation page so far but it still not working properly as when I clicked the 'Create User' hyper-link and filled the form and submitted them the button change to 'Modify' (confirmation page) instead of 'Create' - and when I pressed the button (Modify or Create on the confirmation page still) it won't let me to go to main page (index page)

session_start();
<?php
require 'includes/application.php';

	$id = (int)$_SESSION['id'];
	$mode = $_SESSION['mode'];
	if (!isset ($_SESSION['name']) && isset($id)) {

	$mode = "Modify";

	$modify_sql = "UPDATE persons SET name = '".$_SESSION['name']."', surname = '".$_SESSION['surname']."', address = '".$_SESSION
	['address']."', mobile = '".$_SESSION['mobile']."', `dept_id`= '".$_SESSION['dept']."' WHERE persons.id = " . $id;

	echo $modify_sql;
	$confirm_modify = mysql_query ($modify_sql) or die (mysql_error());	

	header("Location: indexPage.php?id=".$id."&page=modify");
	} else if (!isset($_SESSION['name']) && !isset($id)) {

		$mode = "Creating";

		$create_sql = "INSERT INTO persons SET `Name`='$name', `Surname`='$surname', `dept_id`='$dept', `Address`='$add', 
		`Mobile`='$mobile' ";

		$confirm_create = mysql_query ($create_sql) or die (mysql_error());
		header("Location: indexPage.php?id=".mysql_insert_id()."&page=create");	
	} 
?>

...
...
<td colspan="2" align="center"><p>
	    <input type="button" value="Back" onclick="history.go(-1)" />

	<?php 
	foreach ($_POST as $key => $val)
			$_SESSION[$key] = $val;
	?>
	<!--input type="hidden" name="mode" value="<?php echo $mode;?>" /-->
	<input type="submit" value="<?php echo ($mode == "Creating") ? 'Create' : 'Modify';?>"/>
    </td>
...
...

siabanie

I cannot seem to edit my post, some type..so
EDIT:

session_start();
<?php
require 'includes/application.php';

should be:

<?php
session_start();
require 'includes/application.php';

DaveRandom

siabanie;10973416 wrote:
As far as I understand we can delete these now, cant we?:
<input type="hidden" name="id" value="<?php echo $_GET['id']; ?>">
<input type="hidden" name="mode" value="<?php echo $mode; ?>"> 

You can't remove them entirely, because they are needed if there is an error with input or you are doing a 'Modify' - use this instead:

<input type="hidden" name="id" value="<?php if (isset($_REQUEST['id'])) echo $_REQUEST['id']; ?>">
<input type="hidden" name="mode" value="<?php echo $mode; ?>">

This will remove the error, and using $_REQUEST ensures that the value of 'id' will always be used, regardles of whether it was received by GET or POST.

Below is how I would write the first segment of code above:

<?php

  // Start session/require application.php (what does this file do, apart from connecting to the DB?) 
  session_start();
  require 'includes/application.php';

  /* These two lines are unecessary, we can just use the values from $_SESSION directly
  $id = (int)$_SESSION['id'];
  $mode = $_SESSION['mode']; */

  if (!isset($_SESSION['mode'])) {

// if we get to this page without $_SESSION['mode'] being defined, we're in the wrong place...
exit("Invalid session data");

  } else if ($_SESSION['mode'] == 'Modifying') {

// We are modfying the DB
$modify_sql = "UPDATE `persons` SET `name` = '".$_SESSION['name']."', `surname` = '".$_SESSION['surname']."', `address` = '".$_SESSION['address']."', `mobile` = '".$_SESSION['mobile']."', `dept_id`= '".$_SESSION['dept']."' WHERE `id` = '".$_SESSION['id']."'";
mysql_query($modify_sql) or die (mysql_error());    

// Redirect to indexPage.php    
header("HTTP/1.1 303 See Other");
header("Location: http://".$_SERVER['HTTP_HOST'].dirname($_SERVER['PHP_SELF'])."/indexPage.php?id=".$_SESSION['id']."&page=modify");

  } else {

// We are creating a new entry
$create_sql = "INSERT INTO `persons` (`name`,`surname`,`dept_id`,`address`,`mobile`) VALUES ('".$_SESSION['name']."','".$_SESSION['surname']."','".$_SESSION['dept']."','".$_SESSION['address']."','".$_SESSION['mobile']."')";
mysql_query($create_sql) or die (mysql_error());

// Redirect to indexPage.php    
header("HTTP/1.1 303 See Other");
header("Location: http://".$_SERVER['HTTP_HOST'].dirname($_SERVER['PHP_SELF'])."/indexPage.php?id=".mysql_insert_id()."&page=create");

  } 

?>

I'm not sure what the second segment relates to - where does this code appear? What do you want it to do?

siabanie

DaveRandom;10973418 wrote:

<input type="hidden" name="id" value="<?php if (isset($_REQUEST['id'])) echo $_REQUEST['id']; ?>">
<input type="hidden" name="mode" value="<?php echo $mode; ?>">

So we keep this in both pages (newForm page and confirmPage)? Am I correct?

DaveRandom;10973418 wrote:

  // Start session/require application.php (what does this file do, apart from connecting to the DB?) 
  session_start();
  require 'includes/application.php';

Nothing there are only connection the DB.

DaveRandom;10973418 wrote:
I'm not sure what the second segment relates to - where does this code appear? What do you want it to do?

This code should appear on a confirmation page (confirmPage.php) to view all the values before submitting them to the main page.

Also I would like to use JS "Back" button so when I click back the values still remind there in both page( create new user and modify user)

I tired to placed this code in confirmPage.php (confirmation page) but but it does not seem to work:

  <input type="button" value="Back" onclick="history.go(-1)" />

confirmPage.php

<?php
session_start();
// Start session/require application.php (what does this file do, apart from connecting to the DB?)
require 'includes/application.php';


  if (!isset($_SESSION['mode'])) {

// if we get to this page without $_SESSION['mode'] being defined, we're in the wrong place...
exit("Invalid session data");

  } else if ($_SESSION['mode'] == 'Modifying') {

// We are modfying the DB
$modify_sql = "UPDATE `persons` SET `name` = '".$_SESSION['name']."', `surname` = '".$_SESSION['surname']."', `address` = '".$_SESSION['address']."', `mobile` = '".$_SESSION['mobile']."', `dept_id`= '".$_SESSION['dept']."' WHERE `id` = '".$_SESSION['id']."'";
mysql_query($modify_sql) or die (mysql_error());    

// Redirect to indexPage.php    
header("HTTP/1.1 303 See Other");
header("Location: http://".$_SERVER['HTTP_HOST'].dirname($_SERVER['PHP_SELF'])."/indexPage.php?id=".$_SESSION['id']."&page=modify");

  } else {

// We are creating a new entry
$create_sql = "INSERT INTO `persons` (`name`,`surname`,`dept_id`,`address`,`mobile`) VALUES ('".$_SESSION['name']."','".$_SESSION['surname']."','".$_SESSION['dept']."','".$_SESSION['address']."','".$_SESSION['mobile']."')";
mysql_query($create_sql) or die (mysql_error());

// Redirect to indexPage.php    
header("HTTP/1.1 303 See Other");
header("Location: http://".$_SERVER['HTTP_HOST'].dirname($_SERVER['PHP_SELF'])."/indexPage.php?id=".mysql_insert_id()."&page=create");

  }

?> 
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Confirm Create</title>
</head>

<body>

<form action="<?php echo $_SERVER['PHP_SELF'];?>" method="post">
<div align="center">
  <table width="200" border="1">
    <h1>Are You Happy With These Info?</h1>
    <tr>
      <th scope="row">First Name</th>
      <td><?php echo $_SESSION['name'];?> </td>
    </tr>

<tr>
  <th scope="row">Surname</th>
  <td><?php echo $_SESSION['surname'];?></td>
</tr>

<tr>
  <th scope="row">Address</th>
  <td><?php echo $_SESSION['address'];?></td>
</tr>


<!--Department Modify Form-->

   <tr>
      <th scope="row">Department</th> 
		<td>         

<?php
	$data = mysql_query ("SELECT dept_name FROM dept WHERE id = '".$_SESSION['dept']."'") or die (mysql_error());

		$row_dept= mysql_fetch_array( $data );


  		$_SESSION['dept_name'] = $row_dept['dept_name'];
		echo $_SESSION['dept_name'];

	?>

	</td>
</tr>

<!--End Department-->
<tr>
  <th scope="row">Mobile</th>
  <td><?php echo $_SESSION['mobile'];?> </td>
</tr>

<tr>
<td colspan="2" align="center"><p>
<br/ >
    <input type="button" value="Back" onclick="history.go(-1)" />

	<?php 
	foreach ($_POST as $key => $val)
			echo $_SESSION[$key] = $val;
	?>

	<input type="hidden" name="id" value="<?php if (isset($_REQUEST['id'])) echo $_REQUEST['id']; ?>">
	<input type="hidden" name="mode" value="<?php echo $mode; ?>">

	<input type="submit" value="<?php echo ($mode == "Creating") ? 'Create' : 'Modify'; ?>"/>


    </td>
</tr>

 </table>

</div>
</form>
</body>
</html>

siabanie

I would like to show the confirmation page (confirmPage.php) before it redirect to main page (indexPage.php) - Can you please look at my code back at post #11 what did I miss?

Cheers

siabanie

Hi Guys,

I wonder if anyone could help me out: I am a bit stuck on the confirmation page, it seems that the confirmPage php back on the post #11 did not go to the confirmPage but it redirect to the index page (main page).

Based on DaveRandom post back on the post #10 I tried to add this bits....
Cut-down version.

.... else if ($_SESSION['mode'] == 'Modifying') {

// We are modfying the DB
$modify_sql = "UPDATE `persons` SET `name` = '".$_SESSION['name']."', `surname` = '".$_SESSION['surname']."', `address` = '".$_SESSION
['address']."', `mobile` = '".$_SESSION['mobile']."', `dept_id`= '".$_SESSION['dept']."' WHERE `id` = '".$_SESSION['id']."'";
mysql_query($modify_sql) or die (mysql_error());    


// Redirect to indexPage.php    
header("HTTP/1.1 303 See Other");
header("Location: http://".$_SERVER['HTTP_HOST'].dirname($_SERVER['PHP_SELF'])."/indexPage.php?id=".$_SESSION['id']."&page=modify");


  } else if ($_SESSION['mode'] == 'Creaeting'){ // Added

// We are creating a new entry
$create_sql = "INSERT INTO `persons` (`name`,`surname`,`dept_id`,`address`,`mobile`) VALUES ('".$_SESSION['name']."','".$_SESSION[
'surname']."','".$_SESSION['dept']."','".$_SESSION['address']."','".$_SESSION['mobile']."')";
mysql_query($create_sql) or die (mysql_error());

// Redirect to indexPage.php    
header("HTTP/1.1 303 See Other");
header("Location: http://".$_SERVER['HTTP_HOST'].dirname($_SERVER['PHP_SELF'])."/indexPage.php?id=".mysql_insert_id()."&page=create");
}
..
..
<!--HTML FORM DISPLAYING EITHER THE CREATE OR MODIFY FORM BEFORE PROCEEDING TO MAIN PAGE-->

But it still did not show the confirm Page - can anyone please help me out what did I miss here?

siabanie

----Solved----Thanks guys...!