Help with error msg..

[siabanie]

Hi guys,

Need some help here, I tried to run the code but I got an error:

Undefined index: rememberme on line 16

Can someone please explain me what did I miss? Thanks..

<?php
	require 'includes/application.php';

if (loggedin()){

	header ("Location: userarea.php");
	exit;
}

if(isset($_POST['login'])){

	//Get data
	$username = $_POST['username'];
	$password = $_POST['password'];
	$rememberme = $_POST['rememberme']; //Line 16


	//Form validation if the variables both has been enter do the following
	if ($username && $password)
	{

		//Get data from DB
		$login = mysql_query ("SELECT * FROM users WHERE username = '$username'");

		//Use while loop to specific column name in DB 
		while ($row = mysql_fetch_array($login))
		{

			// Check for the correct password same as in DB password column
			$db_password = $row['password'];


			if (md5($password) == $db_password)
				$loginok = TRUE;

			else
				$loginok = FALSE;

				//Checking loginok if the variable successful or not
				if ($loginok == TRUE)
				{

					if ($rememberme == "on") 
						setcookie("username", $username, time() + 7200);


					else  if($rememberme == "")
						$_SESSION['username']=$username; 


					header("Location: userarea.php");
					exit;
				}
				else 
				die ("Incorrect username / password combination");
		}
	}
	else
		die("Please enter a username and password");
}
?>

[bradgrafelman]

That error is probably caused by the fact that you're attempting to access an array element that was never defined since the corresponding form entity (a "Remember me?" checkbox, I'm guessing?) was never POST'ed.

As such, you should use something like [man]isset/man to check for existence of this entity before you attempt to access it.

[siabanie]

Thanks bradgrafelman, yes the "Remember me" is a checkbox - but how can I use isset() in this kind of situation? Is it like this:

$rememberme = $_POST['rememberme'];

if (isset($rememberme == "no")) //do the following...

cos, that still did not work -- What do you suggest?

[laserlight]

It should be:

if (isset($_POST['rememberme']) && $_POST['rememberme'] == "on")
{
    setcookie("username", $username, time() + 7200);
}
else
{
    $_SESSION['username'] = $username;
}

Actually, the logic does not really make sense since you probably want $_SESSION['username'] to be set either way, i.e., it should be:

if (isset($_POST['rememberme']) && $_POST['rememberme'] == "on")
{
    setcookie("username", $username, time() + 7200);
}
$_SESSION['username'] = $username;

[siabanie]

Thanks laserlight, that's sorted the error, well what I want to achieve on this code is the differences using sessions and cookie as if we placed:

if($rememberme == "")

which I think means is; if we did not click 'Remember me' on the checkbox then do the sessions. But yes it should be either way if we do it in a logical way. Terima Kasih