Page wont click into place?

Beffic

So I have a Javascript setup that always works for me and for some reason I can't get this page to load an if statement. The sell part has no problem what so ever. But I have looked at my MySql and can't find anything wrong and I have been looking at Javascript and can't seem to see anything wrong with that either.

My IDE isn't displaying any PHP errors either. So that's why I have come to you guys.

The link to buy Weapons should be able to execute the Javascript function and load the $_POSTed data showing what page it needs to be on. So now I am clueless. Any ideas?

viewshop.php

<?php
if(isset($_POST['page']) == "Weapon")   //Shop Weapons list
{

$data .= "<center><b>Weapons</b><br />";
$data .= "<table border=\'1\'><tr><td>Item</td><td>Type</td><td>Level Req</td><td>Str</td><td>Dex</td><td>End</td><td>Int</td><td>Con</td><td>Value</td><td>Sell</td></tr>";

$query = mysql_query("SELECT * FROM shop WHERE type='Weapon' ORDER BY value");
while($weapons = mysql_fetch_array($query)){
    $data .= "<tr><td>".$weapons['itemname']."</td><td>".$weapons['type']."</td><td>".$weapons['levelreq']."</td><td>".$weapons['strength']."</td><td>".$weapons['dexterity']."</td><td>".$weapons['endurance']."</td><td>".$weapons['intelligence']."</td><td>".$weapons['concentration']."</td><td>".$weapons['value']."</td><td><a href=\'javascript: buyItem(\"".$weapons['id']."\");\'>Buy</a></td></tr>";
}
$data .= "</table></center>";

}

$data .= "<a href=\'javascript: buy(Weapon);\'>Buy Weapon</a>";

load.js

function buy(what){
    data = "page=" + what;
    evalpostAJAXHtml("viewshop.php",data,0);
}

Desdinova

I see you're escaping the single quotes in the anchor href: href=\'...\'

Quite possibly this is causing the unintended behaviour. Try removing the \ here, you don't need them before the single quote if my eyes do not deceive me.

Beffic

Desdinova;10973869 wrote:
I see you're escaping the single quotes in the anchor href: href=\'...\'

Quite possibly this is causing the unintended behaviour. Try removing the \ here, you don't need them before the single quote if my eyes do not deceive me.

I couldn't see how this could be a problem, I have used this method on many of my scripts and haven't had anything go wrong?

Desdinova

I'm not sure. I guess that's up to the browser to decide. I don't think escaping quotes without a reason should be common practice really.

if you check the html source, do the href values seem ok?

Beffic

I wouldn't really be able to see when viewingsource. I have my site run off ajax and it runs off the index page. So when you view source, even logged in you see the index page. But when I put my cursor over the link it looks as though it should be.

Desdinova

ok. I suggest getting the developer toolbar for firefox when dealing with ajax. Also the firebug addon has some neat features you can use to view the 'live' html source.

If the hover looks ok, then try putting an alert in the js function to see if it opens the function properly.

If it doesn't, somehow the script won't fire. And my first suggestion would then again be to try removing the escapes 😉

Beffic

Anything like that from chrome?

Desdinova

not that I know of honestly. chrome does have developer tools built in I thought, not sure. I'd say just try the alert() first.

Additionally, the last anchor you add does a buy(Weapon). Weapon refers to a javascript variable here. It could be that it does not find the var and decides to stop javascript completely on the page. but that's also a guess. Perhaps you need to put Weapon in quotes here.

Beffic

So I have come to a conclusion that my whole viewshop.php script isn't working. I am looking over it right now I'll post it below if anyone feels like helping out and finds the problem before me. I'll see the email when someone post something here. But once it's fixed ill mark resolve.

<?php
if(isset($_POST['sellid']))   //selling
{
    $idinven = $_POST['sellid'];
    $check = mysql_query("SELECT * FROM inventory WHERE id='".$idinven."' AND username='".$charname."'")or die("Not an existing item in your inventory.");
    $selling = mysql_fetch_assoc($check);
    $sellworth = $selling['value'];
    $sellname = $selling['itemname'];
    $data .= "You sold ".$sellname." for ".number_format($sellworth)." gold, to the shop!<br /><br />";
    $delete = mysql_query("DELETE FROM inventory WHERE id='".$selling['id']."'");
    $gold = $char['gold'] + $sellworth;
    $addgold = mysql_query("UPDATE characters SET gold='".$gold."' WHERE username='".$charname."'");
}
elseif(isset($_POST['page']) == "Weapon")   //Shop Weapons list
{

$data .= "<center><b>Weapons</b><br />";
$data .= "<table border=\'1\'><tr><td>Item</td><td>Type</td><td>Level Req</td><td>Str</td><td>Dex</td><td>End</td><td>Int</td><td>Con</td><td>Value</td><td>Sell</td></tr>";

$query = mysql_query("SELECT * FROM shop WHERE type='Weapon' ORDER BY value");
while($weapons = mysql_fetch_array($query)){
    $data .= "<tr><td>".$weapons['itemname']."</td><td>".$weapons['type']."</td><td>".$weapons['levelreq']."</td><td>".$weapons['strength']."</td><td>".$weapons['dexterity']."</td><td>".$weapons['endurance']."</td><td>".$weapons['intelligence']."</td><td>".$weapons['concentration']."</td><td>".$weapons['value']."</td><td><a href=\'javascript: buyItem(\"".$weapons['id']."\");\'>Buy</a></td></tr>";
}
$data .= "</table></center>";

}
elseif(isset($_POST['itemid']))   //Buying
{
    $idshop = $_POST['itemid'];
    $check = mysql_query("SELECT * FROM shop WHERE id='".$idshop."'")or die("Failed to buy item.");
    $buying = mysql_fetch_assoc($check);
    if($buying['value'] > $char['gold']){
        $data .= "You cannot buy an item that you cannot afford.<br /><br />";
    }else{
        $buyworth = $buying['value'];
        $buyname = $buying['itemname'];
        $data .= "You bought ".$buyname." for ".number_format($buyworth)." gold, from the shop!<br /><br />";
        $makeitem = mysql_query("INSERT INTO inventory (`username`, `itemname`, `levelreq`, `power`, `type`, `strength`, `dexterity`, `endurance`, `intelligence`, `concentration`, `value`) VALUES ('".$char['username']."', '".$buying['itemname']."', '".$buying['levelreq']."', '".$buying['power']."', '".$buying['type']."', '".$buying['strength']."', '".$buying['dexterity']."', '".$buying['endurance']."', '".$buying['intelligence']."', '".$buying['concentration']."', '".$buying['value']."')");
        $gold = $char['gold'] - $buyworth;
        $addgold = mysql_query("UPDATE characters SET gold='".$gold."' WHERE username='".$charname."'");
    }

}


$data .= "<a href='javascript: buy(\"Weapon\");'>Buy Weapon</a>";
//Shop menu
$data .= "<center><b>Sell</b><br />";     //selling
$data .= "<table border='1'><tr><td>Item</td><td>Type</td><td>Level Req</td><td>Str</td><td>Dex</td><td>End</td><td>Int</td><td>Con</td><td>Value</td><td>Sell</td></tr>";

$querty = mysql_query("SELECT * FROM inventory WHERE username='".$char['username']."' AND equipped='No' ORDER BY value");
while($inventory = mysql_fetch_array($querty)){

    $data .= "<tr><td>".$inventory['itemname']."</td><td>".$inventory['type']."</td><td>".$inventory['levelreq']."</td><td>".$inventory['strength']."</td><td>".$inventory['dexterity']."</td><td>".$inventory['endurance']."</td><td>".$inventory['intelligence']."</td><td>".$inventory['concentration']."</td><td>".$inventory['value']."</td><td><a href=\'javascript: sell(\"".$inventory['id']."\");\'>Sell</a></td></tr>";

}
$data .= "</table></center>";

Desdinova

issue here:

elseif(isset($_POST['page']) == "Weapon") //Shop Weapons list

isset will be either true or false, which will then result into: if (true == "Weapon") or if (false == "Weapon"), which is never true thus never gets executed.

Change to:
elseif(isset($POST['page']) && $POST['page'] == "Weapon") //Shop Weapons list

Beffic

Oh how stressful, thanks for the note. I will keep that in mind next time. But at this time it doesn't seem to help...

Beffic

Got it fixed. Needed to put the slash back into it for some reason and it worked better after that.