Loop creates duplicates?! Help

kingcundy

Hi I'm trying to get back results from mysql and display them in a table. The table part isn't the problem at the moment as i'm experimenting but for some reason the results i get back are duplicated? I'm not sure why though?

//-create while loop, and loop through result set

 echo '<table>';
 while($row=mysql_fetch_array($result))
 {

 //-display the result of the array in a table
  echo '<table width="200">';
  echo '<table border="1">';

 echo '<tr>';
 echo '<th>Torrent Name</th>';
 echo '<td>';
 echo '</td>';
 echo '<tr>';

    foreach ($row as $Torrentname){
//loop through elements

echo "<td>$Torrentname</td>";
  }
  echo '</tr>';
}
echo '</table>';} 
          } 
         else{ 
          echo  "<p>Please enter a search query</p>"; 
          } 
          } 

    ?>

kingcundy

Please help me 🙁

NogDog

Maybe it's the SQL, not the PHP, that is the issue?

PS: In the future, please make use of this forum's [noparse]

[/noparse] [URL="http://phpbuilder.com/board/misc.php?do=bbcode"]bbcode tags[/URL] for you code snippets. (I added them to your post.)

TheDefender

You're telling it to duplicate the output because you are looping through the results using the while function and then looping through each while iteration using the foreach function... Go back to basics first. Also, since you didn't post all of your code, I'm doing the best I can with what we have to work with. Hope it helps.

<?php
if([Whatever your condition is])
{

echo '<table>'; 
echo '<tr>'; 
echo '<th>Torrent Name</th>'; 
echo '<tr>'; 

while($row=mysql_fetch_array($result)) 
{
	echo "<tr>";
	echo "<td>$Torrentname</td>"; 
	echo "</tr>";
} 
echo '</table>';


} else
{
	echo  "<p>Please enter a search query</p>"; 
} 

?>

johanafm

TheDefender;10974539 wrote:
You're telling it to duplicate the output because you are looping through the results using the while function and then looping through each while iteration using the foreach function...

Wrong.

Hes telling it to loop over rows that are retrieved with mysql_fetch_array from the result set resource, and then he's looping over fields in each row with foreach. Your code on the other hand uses an undefined variable $Torrentname and makes absolutely no use of row data.

TheDefender

Yes johanafm, my bad. I went through the code fast. Revision posted...

<?php
if([Whatever your condition is])
{

echo '<table>';
echo '<tr>';
echo '<th>Torrent Name</th>';
echo '<tr>';

while($row=mysql_fetch_array($result))
{
    echo "<tr>";
    echo "<td>". $row['fieldname1'] ."</td>";
    echo "<td>". $row['fieldname2']. "</td>";
    echo "</tr>";
}
echo '</table>';


} else
{
    echo  "<p>Please enter a search query</p>";
}

?>

Perhaps in the future johanafm, you could post some helpful advice to the thread after you kick someone else trying to lend a helping hand?!? In any respect, it doesn't matter why he's doing a foreach on the outputted $row data - it isn't necessary.

johanafm

It wasn't my intention to hurt your feelings, but I did forget to comment on the OP. There is no reason for output duplication in the posted code, which means it's either due to the select query, the retrieved data containing identical data in more than one row due to user input or redundant inserts/updates.