[RESOLVED] Notice: Undefined index: page in C:\xampp\htdocs\slkweb\bukapage.php on line 2

[airdan]

Hello, I was wondering if anybody could help me with the following errors:

Notice: Undefined index: page in C:\xampp\htdocs\slkweb\bukapage.php on line 2

The code for the page is as follows:

<?php
$page=$_GET['page'];
switch($page){	
	default 	: if(!file_exists ("home.php")) 
						 	die ("page 'home' not found !!"); 
							include "home.php"; 
							break;
	case "login" 	: if(!file_exists ("login_periksa.php")) 
						 	die ("page 'check login' not found !!"); 
							include "login_periksa.php"; 
							break;
	case 'laphar' 	: if(!file_exists ("Lap_Har_24.php")) 
						 	die ("page 'Laporan Harian' not found !!"); 
							include "Lap_Har_24.php"; 
							break;
	case 'inputdata24' 	: if(!file_exists ("input_har_24.php")) 
						 	die ("page 'Input Data' not found !!"); 
							include "input_har_24.php"; 
							break;
	case 'assetmapping':if(!file_exists ("Ass_Mapp.php")) 
							die ("page 'Asset Mapping' not found !!"); 
							include "Ass_Mapp.php";
							 break ;
	case 'update':if(!file_exists ("Ass_Mapp_Update.php")) 
							die ("page 'update status asset' not found !!"); 
							include "Ass_Mapp_Update.php";
							 break ;
	case 'gb'   :if(!file_exists ("Guestbook.php")) 
						 	die ("page 'Guest Book' not found !!"); 
							include "Guestbook.php"; 
							break;
	case 'gbview'   :if(!file_exists ("Guestbook_view.php")) 
						 	die ("page 'view guest book' not found !!"); 
							include "Guestbook_view.php"; 
							break;
	case 'gbsave'   :if(!file_exists ("Guestbook_save.php")) 
						 	die ("page 'guest book save' not found !!"); 
							include "Guestbook_save.php"; 
							break;
	case 'galery'   :if(!file_exists ("Galery.php")) 
						 	die ("page 'Galery' not found !!"); 
							include "Galery.php"; 
							break;
	case 'help' 	:if(!file_exists ("help.php")) 
						   die ("page 'help' not found !!"); 
							include "help.php"; 
							break;
	case 'profil' :if(!file_exists ("profil.php")) 
						   die ("page 'profil' not found !!"); 
							include "profil.php"; 
							break;
	}

?>

when i load index.php error message appear
If you need more information, Please ask. Thanks!

[bradgrafelman]

The error message is caused by the fact that you never check that $_GET['page'] exists before attempting to use it. You should never reference external data without first verifying that it exists with a function such as [man]isset/man or [man]empty/man.

[Judgey92]

Solution:

<?php 
$page=$_GET['page']; 
if(!isset($page)) {
    echo "Page Not Set";
    exit;
}else{
    if($page == "") {
        echo "Page Not Set";
        exit;
    }
}
switch($page){     

    default     : if(!file_exists ("home.php")) 
                             die ("page 'home' not found !!"); 
                            include "home.php"; 
                            break; 
    case "login"     : if(!file_exists ("login_periksa.php")) 
                             die ("page 'check login' not found !!"); 
                            include "login_periksa.php"; 
                            break; 
    case 'laphar'     : if(!file_exists ("Lap_Har_24.php")) 
                             die ("page 'Laporan Harian' not found !!"); 
                            include "Lap_Har_24.php"; 
                            break; 
    case 'inputdata24'     : if(!file_exists ("input_har_24.php")) 
                             die ("page 'Input Data' not found !!"); 
                            include "input_har_24.php"; 
                            break; 
    case 'assetmapping':if(!file_exists ("Ass_Mapp.php")) 
                            die ("page 'Asset Mapping' not found !!"); 
                            include "Ass_Mapp.php"; 
                             break ; 
    case 'update':if(!file_exists ("Ass_Mapp_Update.php")) 
                            die ("page 'update status asset' not found !!"); 
                            include "Ass_Mapp_Update.php"; 
                             break ; 
    case 'gb'   :if(!file_exists ("Guestbook.php")) 
                             die ("page 'Guest Book' not found !!"); 
                            include "Guestbook.php"; 
                            break; 
    case 'gbview'   :if(!file_exists ("Guestbook_view.php")) 
                             die ("page 'view guest book' not found !!"); 
                            include "Guestbook_view.php"; 
                            break; 
    case 'gbsave'   :if(!file_exists ("Guestbook_save.php")) 
                             die ("page 'guest book save' not found !!"); 
                            include "Guestbook_save.php"; 
                            break; 
    case 'galery'   :if(!file_exists ("Galery.php")) 
                             die ("page 'Galery' not found !!"); 
                            include "Galery.php"; 
                            break; 
    case 'help'     :if(!file_exists ("help.php")) 
                           die ("page 'help' not found !!"); 
                            include "help.php"; 
                            break; 
    case 'profil' :if(!file_exists ("profil.php")) 
                           die ("page 'profil' not found !!"); 
                            include "profil.php"; 
                            break; 
    } 

?>

[bradgrafelman]

That "solution" is no better than the original version, because you're still attempting to access $_GET['page'] before checking if it was set. In addition, you're using [man]isset/man on a variable you just defined, which doesn't make much sense.

[Judgey92]

Wow, i was only trying to help the guy. Here is a better than my original solution:

<?php  

if(!isset($_GET['page'])) {
    echo "Page Not Set";
    exit;
}else{
    if($_GET['page'] == "") {
        echo "Page Not Set";
        exit;
    }
}
$page = $_GET['page'];
switch($page){     

    default     : if(!file_exists ("home.php")) 
                             die ("page 'home' not found !!"); 
                            include "home.php"; 
                            break; 
    case "login"     : if(!file_exists ("login_periksa.php")) 
                             die ("page 'check login' not found !!"); 
                            include "login_periksa.php"; 
                            break; 
    case 'laphar'     : if(!file_exists ("Lap_Har_24.php")) 
                             die ("page 'Laporan Harian' not found !!"); 
                            include "Lap_Har_24.php"; 
                            break; 
    case 'inputdata24'     : if(!file_exists ("input_har_24.php")) 
                             die ("page 'Input Data' not found !!"); 
                            include "input_har_24.php"; 
                            break; 
    case 'assetmapping':if(!file_exists ("Ass_Mapp.php")) 
                            die ("page 'Asset Mapping' not found !!"); 
                            include "Ass_Mapp.php"; 
                             break ; 
    case 'update':if(!file_exists ("Ass_Mapp_Update.php")) 
                            die ("page 'update status asset' not found !!"); 
                            include "Ass_Mapp_Update.php"; 
                             break ; 
    case 'gb'   :if(!file_exists ("Guestbook.php")) 
                             die ("page 'Guest Book' not found !!"); 
                            include "Guestbook.php"; 
                            break; 
    case 'gbview'   :if(!file_exists ("Guestbook_view.php")) 
                             die ("page 'view guest book' not found !!"); 
                            include "Guestbook_view.php"; 
                            break; 
    case 'gbsave'   :if(!file_exists ("Guestbook_save.php")) 
                             die ("page 'guest book save' not found !!"); 
                            include "Guestbook_save.php"; 
                            break; 
    case 'galery'   :if(!file_exists ("Galery.php")) 
                             die ("page 'Galery' not found !!"); 
                            include "Galery.php"; 
                            break; 
    case 'help'     :if(!file_exists ("help.php")) 
                           die ("page 'help' not found !!"); 
                            include "help.php"; 
                            break; 
    case 'profil' :if(!file_exists ("profil.php")) 
                           die ("page 'profil' not found !!"); 
                            include "profil.php"; 
                            break; 
    } 

?>

[bradgrafelman]

A one-liner approach I often use to set external variables looks like this:

$foo = (isset($_GET['foo']) ? strtolower($_GET['foo']) : NULL);

since it offers a few benefits:

1. Error-less yet compact! 🙂

2. Allows you to 'filter' all values (e.g. apply [man]strtolower/man to them)

3. Allows you to define a default value (e.g. NULL)

[airdan]

thanks guy for your solution, my problem has been resolved.
i try solution from Judgey92, but not redirecting to default page. finally i use solution from bradgrafelman, become :

<?php
$page = (isset($_GET['page']) ? strtolower($_GET['page']) : NULL); 
switch($page){	
	default 	: if(!file_exists ("home.php")) 
						 	die ("page 'home' not found !!"); 
							include "home.php"; 
							break;
	case "login" 	: if(!file_exists ("login_periksa.php")) 
						 	die ("page 'check login' not found !!"); 
							include "login_periksa.php"; 
							break;
	case 'laphar' 	: if(!file_exists ("Lap_Har_24.php")) 
						 	die ("page 'Laporan Harian' not found !!"); 
							include "Lap_Har_24.php"; 
							break;
	case 'inputdata24' 	: if(!file_exists ("input_har_24.php")) 
						 	die ("page 'Input Data' not found !!"); 
							include "input_har_24.php"; 
							break;
	case 'assetmapping':if(!file_exists ("Ass_Mapp.php")) 
							die ("page 'Asset Mapping' not found !!"); 
							include "Ass_Mapp.php";
							 break ;
	case 'update':if(!file_exists ("Ass_Mapp_Update.php")) 
							die ("page 'update status asset' not found !!"); 
							include "Ass_Mapp_Update.php";
							 break ;
	case 'gb'   :if(!file_exists ("Guestbook.php")) 
						 	die ("page 'Guest Book' not found !!"); 
							include "Guestbook.php"; 
							break;
	case 'gbview'   :if(!file_exists ("Guestbook_view.php")) 
						 	die ("page 'view guest book' not found !!"); 
							include "Guestbook_view.php"; 
							break;
	case 'gbsave'   :if(!file_exists ("Guestbook_save.php")) 
						 	die ("page 'guest book save' not found !!"); 
							include "Guestbook_save.php"; 
							break;
	case 'galery'   :if(!file_exists ("Galery.php")) 
						 	die ("page 'Galery' not found !!"); 
							include "Galery.php"; 
							break;
	case 'help' 	:if(!file_exists ("help.php")) 
						   die ("page 'help' not found !!"); 
							include "help.php"; 
							break;
	case 'profil' :if(!file_exists ("profil.php")) 
						   die ("page 'profil' not found !!"); 
							include "profil.php"; 
							break;

}

?>

it works, that syntax redirecting to default page. thanks

[holdoffhunger]

To all of the suggested solutions, I say: EPIC FAIL.

Doesn't it strike you as odd that your solutions for a development environment require reprogramming your entire systems when you intend to deploy them? Maybe you should have a development-development, or development-development-development environment, for in between.

Solution for Actual Developers: EasyPHP.
Solution for Children: Xampp.

[Weedpacket]

holdoffhunger wrote:

To all of the suggested solutions, I say: EPIC FAIL.

Doesn't it strike you as odd that your solutions for a development environment require reprogramming your entire systems when you intend to deploy them? Maybe you should have a development-development, or development-development-development environment, for in between.

What are you wittering about?