RegEx Help Please

Judgey92

Hello Everyone,

First of all thank for taking the time to look at my post.

Ok, I have the following code in my coded forums which auto find and link links. It works great but i am also using my BBCode function which is used to echo out the post to replace the BB Codes with the HTML. So what's happening is when the user adds a link without the [link=][link] bbcodes it does replace it with the bbcodes but it also does it for images which messes up the img bb code as its doing this:

<img src="<a href="http://www.google.com">http://www.google.com</a>"" width="400" height="360">

Heres the regex for the auto link:

$reg_exUrl = "/(http|https|ftp|ftps)\:\/\/[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,3}(\/\S*)?/";
    preg_match_all($reg_exUrl, $string, $matches);
    $usedPatterns = array();
    foreach($matches[0] as $pattern){
        if(!array_key_exists($pattern, $usedPatterns)){
            $usedPatterns[$pattern]=true;
            $string = str_replace($pattern, '[link='.$pattern.']'.$pattern.'[/link]', $string);
        }
    }

And here is the code i'm using and encoutering problem with:

<?

function BBCode ($string) {	


$search = array(
        '#\[b\](.*?)\[/b\]#',
        '#\[i\](.*?)\[/i\]#',
        '#\[u\](.*?)\[/u\]#',
		'#\[youtube\](.*?)\[/youtube\]#',
        '#\[img\](.*?)\[/img\]#',
        '#\[link=(.*?)\](.*?)\[/link\]#',
        '#\[code\](.*?)\[/code\]#'
);
$replace = array(
        '<b>\\1</b>',
        '<i>\\1</i>',
        '<u>\\1</u>',
		'<br /><br /><center><object width="500" height="306"><param name="movie" value="http://www.youtube.com/v/\\1?fs=1&amp;hl=en_US&amp;color1=0x234900&amp;color2=0x4e9e00"></param><param name="allowFullScreen" value="true"></param><param name="allowscriptaccess" value="always"></param><embed src="http://www.youtube.com/v/\\1?fs=1&amp;hl=en_US&amp;color1=0x234900&amp;color2=0x4e9e00" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="500" height="306"></embed></object></center><br /><br />',
        '<br /><br /><a href="\\1" target="_blank" ><h3>Enlarge Image</h3></a><a href="\\1" target="_blank" ><img src="\\1" style="border:none; background-color:transparent;" width="500" height="306"></a><br /><br />',
        '<a href="\\1" target="_blank" >\\2</a>',
        '<code>\\1</code>'
);

if($_COOKIE['userloggedin'] == ""){
    $replace['5'] ="<br /><br /><font color='red'>[ LINKS FOR REGISTERED USERS ONLY, <a href='login' class='cp'><strong><u>LOGIN</u></strong></a> OR <a href='register' class='cp'><strong><u>REGISTER</u></strong></a> TO VIEW ]</font><br /><br />";
}else{
    $replace['5'] = '<a href="\\1" target="_blank">\\2</a>';
}


$reg_exUrl = "/(http|https|ftp|ftps)\:\/\/[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,3}(\/\S*)?/";
preg_match_all($reg_exUrl, $string, $matches);
$usedPatterns = array();
foreach($matches[0] as $pattern){
    if(!array_key_exists($pattern, $usedPatterns)){
        $usedPatterns[$pattern]=true;
        $string = str_replace($pattern, '[link='.$pattern.']'.$pattern.'[/link]', $string);
    }
}

return preg_replace($search , $replace, $string);
$reg_exUrl = "/(http|https|ftp|ftps)\:\/\/[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,3}(\/\S*)?/";

}
?>

Thanks,

Judgey

Judgey92

Have i explained this clearly enough?

sneakyimp

You might want to think about putting the auto link replacement step first and make sure the pattern isn't preceded by a [link= or [img]

Judgey92

sneakyimp;10974553 wrote:
You might want to think about putting the auto link replacement step first and make sure the pattern isn't preceded by a [link= or [img]

Thank you for your reply but i don't know how to, please can you help me?

sneakyimp

I started to try and fix your code, but it has other problems. For example, you define $reg_exUrl twice.

Maybe you should remove the second definition of $reg_exUrl (which occurs after the function returns anyway) and change the first one to this:

$reg_exUrl = '/(?<!(\[link=)|(\[img\]))(http|https|ftp|ftps)\:\/\/[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,3}(\/\S*)?/i';

Note that I used single quotes.

Judgey92

sneakyimp;10974629 wrote:
I started to try and fix your code, but it has other problems. For example, you define $reg_exUrl twice.

Maybe you should remove the second definition of $reg_exUrl (which occurs after the function returns anyway) and change the first one to this:
$reg_exUrl = '/(?<!(\[link=)|(\[img\]))(http|https|ftp|ftps)\:\/\/[a-zA-Z0-9\-\.]+\.[a-zA-Z]{2,3}(\/\S*)?/i';
Note that I used single quotes.

That's excellent thank you but there is a slight problem, the images show up correctly, however, the url bb code in the forums is now coming up like this (without asterisk):

[*url=http://www.google.com]http://www.google.com[/url]

Exactly above when i try to use bb codes, if i dont and just enter link its fine.

Thanks for all you help again!

sneakyimp

Your code doesn't make any effort to parse [url] links.

Judgey92

sneakyimp;10974705 wrote:
Your code doesn't make any effort to parse links.

Lol, sorry long day. I still tried with the

[link=http://www.google.com]http://www.google.com[/link]

And i get (exactly as shown):

[URL="http://www.google.com"]http://www.google.com]http://www.google.com[/link]

BUT if i did not put a link to show the link it works fine e.g:

[link=http://www.google.com]Google[/link]

Looks like:

Google

Thanks soooooo much for your help.

Seriously appreciate you knowledge.

Daniel

sneakyimp

Could you create a sample text that you want to run through this function so that I can test it? Just attach it to this thread as a .txt file.