[RESOLVED] 1st time attempting dynamic array

[Square1]

Hi all:

I am attempting to write a dynamic array and I ready for some help! My goal is to call the SELECT statement and populate 3 columns using FOR. I am very far from my goal right now!!! Here is the code. If someone could clean it up so I see the proper format that would be perfect and appreciated. I have looked for some sample code for a dynamic array and couldn't find any. Again...thanks...

           <?php
            if (strlen($_Get("OB"))==00){ //THIS IS LINE 30
				$iOB = "Player, WishCount DESC";
				}
			else
				{
				$iOB = ($_Get("OB"))==0;
				}
			?>

		<td class="text-box" style="width:33%; height:34px; vertical-align:text-top; padding-left:10px;">


        <?php


		$myServer = "XX.XX.XX.XX.XX";
		$myUser = "XXXXXXXX";
		$myPass = "XXXXXX";
		$myDB = "XXXXXXXX";

		$dbhandle = mssql_connect($myServer, $myUser, $myPass)
			or die("Couldn't connect to SQL Server on $myServer");

		$selected = mssql_select_db($myDB, $dbhandle)
			or die("Couldn't open database $myDB");

		$sql0 = "SELECT COUNT (DISTINCT Player) AS Total FROM Wish";
		$result0 = mssql_query($sql0);
		$row0= mssql_fetch_array($result0);
		$counter0 = $row0['Total'];


		$sql1 = "SELECT Player, WishCount FROM Wish ORDER BY $iOB";
		$result1 = mssql_query($sql1);
		$row1= mssql_fetch_array($result1);
		$counter1 = $row1['Player'];
		$counter2 = $row1['Wishcount'];

		if (empty($counter1)) {
			echo 'No Players on WishList at this time';
			}
		else
			{


          for ($ia=0; $ia<=count($arrPlayers)-1; $ia++) {
		$iRCount++;

			?>

        	<? 
		echo $arrPlayers(0, ia()); 
			?>
		&nbsp;&nbsp;
			<? 
		echo $arrPlayers(1, ia()); 

		  }

			?>

        	<br />

        	<?php

			if ($iRCount = Int($iTotal/3)){
        		echo "</td><td class='text-box' style='width:33%; height:34px; vertical-align:text-top; padding-left:10px;'>";
			}
			if ($iRCount = Int($iTotal*2/3)){
        		echo "</td><td class='text-box' style='width:33%; height:34px; vertical-align:text-top; padding-left:10px;'>";
			}
			}
			 mssql_close($dbhandle);
        	?>

Error:

Notice: Undefined variable: _Get in C:\Web\MySite\wsl\wsl_wsl.php on line 30

Fatal error: Function name must be a string in C:\Web\MySite\wsl\wsl_wsl.php on line 30

[dagon]

it's

$_GET["OB"]

not

$_Get("OB")

[Square1]

dagon;10974794 wrote:

it's

$_GET["OB"]

not

$_Get("OB")

Thank you. Geeesh. I am coming out of ASP classic which is more forgiving!

This has led to a can of worms of more errors. Let me see how many I can sort on my own first.

[Square1]

OK, here it is with some corrections, bu still no cigar:

Error: Fatal error: Call to undefined function 0() in C:\Web\MySite

      <?php

		if (!isset($_GET['OB']))
		{
		$_GET['OB'] = "undefine";
		} 

		if (!isset($_GET['OB']))
		{
		$_GET['OB'] = "undefine";
		} 



        if (strlen($_GET['OB'])==00){
			$iOB = "Player, WishCount DESC";
			}
		else
			{
			$iOB = ($_GET['OB'])==0;
			}
		?>

		<td class="text-box" style="width:33%; height:34px; vertical-align:text-top; padding-left:10px;">


        <?php


		$myServer = "XXXXXXX";
		$myUser = "XXXXXXX";
		$myPass = "XXXXXXX";
		$myDB = "XXXXXX";

		$dbhandle = mssql_connect($myServer, $myUser, $myPass)
			or die("Couldn't connect to SQL Server on $myServer");

		$selected = mssql_select_db($myDB, $dbhandle)
			or die("Couldn't open database $myDB");

		$sql0 = "SELECT COUNT (DISTINCT Player) AS Total FROM Wish";
		$result0 = mssql_query($sql0);
		$row0= mssql_fetch_array($result0);
		$counter0 = $row0['Total'];


		$sql1 = "SELECT Player, WishCount FROM Wish ORDER BY $iOB";
		$result1 = mssql_query($sql1);
		$row1= mssql_fetch_array($result1);

		if (!isset($row2['Wishcount']))
		{
		$row2['Wishcount'] = "undefine";
		} 	

		$counter1 = $row1['Player'];
		$counter2 = $row2['Wishcount'];



		if (empty($counter1)) {
			echo 'No Players on WishList at this time';
			}
		else
			{


		if (!isset($arrPlayers))
		{
		$arrPlayers = "0";
		}

		if (!isset($iRCount))
		{
		$iRCount = "0";
		}	

          for ($ia=0; $ia<=count($arrPlayers)-1; $ia++) {
		$iRCount++;

			?>

        	<?		

		echo $arrPlayers(0, ia());//LINE 113
			?>
		&nbsp;&nbsp;
			<? 
		echo $arrPlayers(1, ia()); 

		  }

			?>

        	<br />

        	<?php

			if ($iRCount = Int($iTotal/3)){
        		echo "</td><td class='text-box' style='width:33%; height:34px; vertical-align:text-top; padding-left:10px;'>";
			}
			if ($iRCount = Int($iTotal*2/3)){
        		echo "</td><td class='text-box' style='width:33%; height:34px; vertical-align:text-top; padding-left:10px;'>";
			}
			}
			 mssql_close($dbhandle);
        	?>

[dagon]

what line is the error on?

and that do you expect this to do

$iOB = ($_GET['OB'])==0;

and please use the php rather than code tags around your post

[Square1]

dagon;10974802 wrote:

what line is the error on?

and that do you expect this to do

$iOB = ($_GET['OB'])==0;

and please use the php rather than code tags around your post

Thank you. This line has been corrected.

[Square1]

Thank you for your patience with me dagon. I fell like an old dog trying to learn a new trick!

Error: Fatal error: Call to undefined function () in C:\Web\MySite\wsl\wsl_wsl.php on line 117

         <?php

		if (!isset($_GET['OB']))
		{
		$_GET['OB'] = "undefine";
		} 

		if (!isset($_GET['OB']))
		{
		$_GET['OB'] = "undefine";
		} 

		if (!isset($iOB))
		{
		$iOB = "";
		} 			


        if (strlen($_GET['OB'])==0){
			$iOB = "Order by Player, WishCount DESC";
			}
		?>

		<td class="text-box" style="width:33%; height:34px; vertical-align:text-top; padding-left:10px;">


        <?php


		$myServer = "xxxxxxxx";
		$myUser = "xxxxxx";
		$myPass = "xxxx";
		$myDB = "xxxxx";

		$dbhandle = mssql_connect($myServer, $myUser, $myPass)
			or die("Couldn't connect to SQL Server on $myServer");

		$selected = mssql_select_db($myDB, $dbhandle)
			or die("Couldn't open database $myDB");

		$sql0 = "SELECT COUNT (DISTINCT Player) AS Total FROM Wish";
		$result0 = mssql_query($sql0);
		$row0= mssql_fetch_array($result0);
		$counter0 = $row0['Total'];


		$sql1 = "SELECT Player, WishCount FROM Wish $iOB";
		$result1 = mssql_query($sql1);
		$row1= mssql_fetch_array($result1);

		if (!isset($row2['Wishcount']))
		{
		$row2['Wishcount'] = "undefine";
		} 	

		$counter1 = $row1['Player'];
		$counter2 = $row2['Wishcount'];



		if (empty($counter1)) {
			echo 'No Players on WishList at this time';
			}
		else
			{


		if (!isset($arrPlayers))
		{
		$arrPlayers = "";
		}

		if (!isset($iRCount))
		{
		$iRCount = "";
		}	

          for ($ia=0; $ia<=count($arrPlayers)-1; $ia++) {
		$iRCount++;

			?>

        	<?		

		echo $arrPlayers(0, ia()); //LINE 117
			?>
		&nbsp;&nbsp;
			<? 
		echo $arrPlayers(1, ia()); 

		  }

			?>

        	<br />

        	<?php

			if ($iRCount = Int($iTotal/3)){
        		echo "</td><td class='text-box' style='width:33%; height:34px; vertical-align:text-top; padding-left:10px;'>";
			}
			if ($iRCount = Int($iTotal*2/3)){
        		echo "</td><td class='text-box' style='width:33%; height:34px; vertical-align:text-top; padding-left:10px;'>";
			}
			}
			 mssql_close($dbhandle);
        	?>
        	</td>
        </tr>
      </table>

[bradgrafelman]

Where is the function ia() ever defined? Also, why do you have a lot of opening and closing tags around that line?

Lastly, make sure you always use the full '<?php' opening tag and never use the '<?' (or '<?=(expression)?>') opening tags.

[Square1]

I am going to simplify this. My first goal is just to get a dynamic array working. Here is the error for this:

Fatal error: Call to undefined function Charlie Hough() in C:\Web\MyWebsite\wsl\test.php on line 46

"Charlie Hough" being on of the records in my table:

            <?php


		$sql = "SELECT Player FROM WishList";
		$result = mssql_query($sql);
		$row = mssql_fetch_array($result);
		$arrPlayers = $row['Player'];



		if (empty($arrPlayers)) {
			echo 'No Players on WishList at this time';
			}

          for ($ia=0; $ia<=count($arrPlayers)-1; $ia++) {
			  echo $arrPlayers(0, $ia());//LINE 46
		  }

		?>

[bradgrafelman]

What is the intended purpose of this line:

echo $arrPlayers(0, ia());//LINE 46 

?

[Square1]

I want to write out all the records in the "Player" field.

[bradgrafelman]

I'm not sure where you found syntax like that, but that one line has several problems with it.

There's no point in critiquing it, however, because there are a lot bigger problems than that. For example, you only retrieve a single row - $row. You then create a variable called $arrPlayers that contains the value of one of the columns in that row. Your for() loop then acts as if $arrPlayers is an array, which it clearly is not.

Look at the PHP manual page for [man]mssql_fetch_array/man. The "fetch" DB functions retrieve one row at a time, so they are most often called in a loop (e.g. a while loop, as shown in the PHP manual) to retrieve all rows in the result set.

[Square1]

Well, I think I am making a little progress, but still far from"getting it". The following code does not return an error, but it just keep repeating the ARRAY:

			$query = mssql_query('SELECT Player FROM WishList');

		if (!mssql_num_rows($query)) {
		echo 'No records found';
		} else {

		while ($row = mssql_fetch_array($query, MSSQL_NUM)) {

		echo $row;

    }
}

mssql_free_result($query);

[bradgrafelman]

As the function name suggests, [man]mssql_fetch_array/man returns an array, and you can't directly echo/print an array. Use [man]print_r/man on an array if you want to see how it is structured.

Also note that associative arrays are used more often than numerical arrays when retrieving SQL results, since $row['Player'] is a lot more descriptive than $row[0].

[Square1]

GOT IT!!!!! Thank you so much for your patience!!!! Now, is this the "best way" to do this, meaning most efficient with resources? Also, would mssql_free_result ALWAYS be used after an array?

$query = mssql_query('SELECT Player FROM WishList');



		if (!mssql_num_rows($query)) {
		echo 'No records found';
		} else {

		while ($row = mssql_fetch_array($query)) {


			printf($row['Player']);

    }
}

mssql_free_result($query);

[bradgrafelman]

Square1 wrote:

Now, is this the "best way" to do this, meaning most efficient with resources?

Well... what you have is just about the most basic script possible that retrieves data from a SQL table, so I would hazard a guess and say "yes" simply because of the lack of complexity.

Square1 wrote:

Also, would mssql_free_result ALWAYS be used after an array?

Not sure what you're asking here. What do you mean "after an array" ?