[RESOLVED] PHP loop advice required

ee12csvt

I have a loop to display a list of names seperated by a comma and a full stop at the end.

<?php $acknow = array(); 
 do {
$acknow[] = $row_rsMedia['con_Acknow'];
} while ($row_rsMedia = mysql_fetch_assoc($rsMedia));
echo implode(",&nbsp;&nbsp;", $acknow). "."; ?>

I now want to add a link to the name as I have created a page where further information can be found

I have attempted to place an echo before and after this statement

$acknow[] = $row_rsMedia['con_Acknow'];

but have not had any success.

Each link will also use rsMedia to identify the link, using 'con_ID'

Any advice would be appreciated

johanafm

First off, you have a problem with your loop structure

# do-while is run once before while condition is checked
do
{
	# so $row_rsMedia is not defined here (unless you place a call to mysql_fetch_assoc
	# BEFORE the loop)
	$acknow[] = $row_rsMedia['con_Acknow'];
} while ($row_rsMedia = mysql_fetch_assoc($rsMedia));

But a better solution is to run a while loop, for which the while condition is evaluated before the loop is run even once

while ($row_rsMedia = mysql_fetch_assoc($rsMedia))
{
	$acknow[] = $row_rsMedia['con_Acknow'];
}

Now, let's say the call to implode creates the string "1, 2, 3", and for this to be a link you need <a href="...">1, 2, 3.</a>. So, you either need to include the link stuff "<a href...>" and </a> in the same echo statement, or in separate echo statements just before and just after the echo of "1, 2, 3."

echo '<a href="http://example.com">'.implode(",&nbsp;&nbsp;", $acknow). ".</a>";

ee12csvt

Johanafm,

Thanks for the advice.

How could I do this

<a href = "http://link.php?id=1>John Doe</a>, <a href = "http://link.php?id=2>James Doe</a>, <a href = "http://link.php?id=3>David Banner</a>, <a href = "http://link.php?id=4>Jemima Puddleduck</a>.

djjjozsi

inside the while cycle build the output urls as strings.

while(...)
{
$out[]=sprintf( '<a href="%d"> %s </a>'   , $row["id"] , $row["name"]) ;
}

then echo the content with the implode()

these codes and field names are schematic only, exept the sprintf() example.

ee12csvt

djjjozsi;10974846 wrote:
inside the while cycle build the output urls as strings.
while(...)
{
$out[]=sprintf( '<a href="%d"> %s </a>'   , $row["id"] , $row["name"]) ;
}
then echo the content with the implode()

these codes and field names are schematic only, exept the sprintf() example.

Thank you for this, I have looked at your suggestions and have got it working 🙂