Is there a better way to extract this data ?

[habbardone]

Hi,

I am running a query and extracting data depending upon a variable, the language.

The language is passed in the $lang variable.

Then, I want to collect its contents.

Here is my script.

$hits = 20;
$sql = "SELECT $lang, cat,eng FROM multilang WHERE $lang IS NOT NULL AND cat = '$cat' AND confirm = 'n' ORDER BY cat LIMIT 20";
$result = mysql_query($sql) or die("could not FIND multilang categories.".mysql_error()."\r\n");
while($row = mysql_fetch_assoc($result)){

extract($row);

if (isset($span)){
   if (len($span) > 0){
     $word=$span;
	 }
  } 
if (isset($fren)){
   if (len($fren) > 0){
     $word=$fren;
	 }
  } 
if (isset($port)){
   if (len($port) > 0){
     $word=$port;
	 }
  } 
if (isset($ital)){
   if (len($ital) > 0){
     $word=$ital;
	 }
  } 
if (isset($turk)){
   if (len($turk) > 0){
     $word=$turk;
	 }
  } 

I think that there must be a better way to get the contents of the $row, but as I doın't know what the $lang will be I have just gone through the available ones.

Problem is if I add "greek" then I have to update this script.

Is there a better way to do this ?

Thanks

[planetsim]

Are you saying you have a new column for each language in that table ? Seems rather poor design if thats the case. Surely having a table for languages and another table with what I gather is the word for a category for that language in another would be a better way of doing it as you won't need to know what language is being used. Just the language exists and the word/category exists.

[habbardone]

Its OK I sorted it 🙂