[RESOLVED] MySQL multiple UPDATE problem

RichieMTC

Friends,

Firstly, sorry if my english is not good, its not my "home language".

I have problem with my multiple update script. Here is my code:

<?php
$riadok = $_POST['id'];
$files = $_POST['comment'];
$N = count($files);


for($i=0; $i < $N; $i++)
  {

$editid = $riadok[$i];

$sql = "UPDATE
            upload
          SET
            comment = '$files[$i]' 
          WHERE
            id = '$editid'";

  echo $editid;
  echo $files[$i];
  echo $N;

 }
?>

I add the ECHO in bottom for check if the values are correct.
$N; gives me a correct number of required cycles
$files[$i]; gives me a correct value written down on TEXTAREA and POST from previous page.
$editid; gives me a correct ID from MySQL table row POST from previous page.

Anyway all ECHOs looks good for UPDATE, but script do not work. Im trying to fix it, but it looks like, Im on end of my possibilities. Ofcause I can gives you all 2 pages works before this one if necessary.

In another page I use similar cycle to this one but with SQL DELETE and its work. Can anybody help me?

Lots of thanks

RichieMTC

Res

Echo out the $sql instead of just the vars you are using to build it, I think it should become apparent then.

Basically you can't pass an array value as part of a string like you are, you either have to concatenate it, or surround it in brackets.

$sql = "UPDATE
            upload
          SET
            comment = '".$files[$i]."'
          WHERE
            id = '$editid'"; 
//or
$sql = "UPDATE
            upload
          SET
            comment = '{$files[$i]}'
          WHERE
            id = '$editid'";

sneakyimp

Yes, echo the SQL rather than the various pieces you are feeding into it. I think Res is right about your problem.

RichieMTC

Hi guys. Many thanks for your reply. I been try both and ofcause remove the EHOs form the bottom:

comment = '".$files[$i]."' and
comment = '{$files[$i]}' but

it was does not work same like mine one. Im really going to by mad from this code ... Its first time I try to do UPDATE multiple, but Im going to by afraid, I will never fix it.

Any ideas?

RichieMTC

johanafm

Well, what does your complete SQL queries look like (echo $sql), rather than echo $N etc.
How do you run your queries, PDO, mysqli, mysql? Either way, do you test your query execution for errors? And what error information (logged or displayed) do you get when the query fails?

But no, his syntax for string embedded array elements seems fine

$a = array('a', 'b');

echo '<h3>No difference between these 2 (integer keys)</h3>';
for ($i = 0; $i < count($a); ++$i)
{
	echo "bracket style: {$a[$i]}<br/>";
	echo "direct style: $a[$i]<br/><br/>";
}


echo '<h3>Syntactical difference between these two ({} and ['key'], or just [key]</h3>';
$a = array('a' => 'a', 'b' => 'b');
echo "bracket style: {$a['a']}<br/>";
echo "direct style: $a[a]<br/><br/>";

RichieMTC

I have a MySQL table where are informations about uploaded photos. In this code I try to UPDATE one or more rows where column is named COMMENT. Its mean, that I can open one or more photos from my album on TEXTAREA, write or rewrite comment for choosed photo or photos and UPDATE it on MySQL table. The transfer between choose page and update page is by checkbox on FORM and POST.

I made same script for DELETE it. Same choosing by checkbox, post to DELETE page and same cycle for more file delete. Its work OK. Just this UPDATE boring me.

I can write the previous page code here too, if it can help ...

Thanks to all for hepling me

RichieMTC

Friends, finally I fix it. I had just a BUG ...
All values was OK, cycle was OK. Just my mistake was on SQL command. The wrong one:

$sql = "UPDATE upload SET comment = '$files[$i]' WHERE id = '$editid'";

And ofcause the works one:

$sql = @mysql_query("UPDATE upload SET comment = '$files[$i]' WHERE id = '$editid'");

Please find, I forgot @ before command write down. Im so "junior" on PHP and Im making juniors mistakes.

My thanks for all friend here trying to help me 🙂

RichieMTC

bradgrafelman

Do you know what the '@' character does in front of the function call to mysql_query()?

In my personal opinion, this error suppressor operator should almost never be used since there is no sensible justification for it.