Help convert this IF statement to a switch

the3rdhero

Not really clued up on switches, so any help converting this would be appreciated!

<?php

session_start();
require("includes/connect.php");

$post_username = $_POST['username'];
$post_password = $_POST['password'];

if($post_username && $post_password)
{
	if(strlen($post_username)>25 || strlen($post_password)>25)
	{
		die("Username or password is too long!");
	}
	else
		{
			//convert password to md5

		$post_password = md5($post_password);

		//query the database
		$login = sprintf("SELECT * FROM users WHERE username='%s' AND password='%s'", mysql_real_escape_string($post_username), mysql_real_escape_string($post_password));

		$rowcount = mysql_num_rows(mysql_query($login));

		$fieldarray = mysql_fetch_assoc(mysql_query($login));

		$id = $fieldarray['id'];

		if($rowcount == 1)
		{
			$_SESSION['user']=$post_username;
			$_SESSION['id']=$id;
			echo $_SESSION['user'].", you have been logged in! <a href='index.php'>Back to main page</a>";
		}
		else
		{
			die("Incorrect username or password!");
		}
	}
}
else
	die("Username and password required!");

include('includes/analytics.php');
?>

Thank you 🙂

bradgrafelman

If you aren't "clued up on switches," then why are you trying to use them?

EDIT: Also note that you say "this" and then give us a big blob of code. Which specific if/else/etc. branch were you talking about?

the3rdhero

bradgrafelman;10975923 wrote:
If you aren't "clued up on switches," then why are you trying to use them?

EDIT: Also note that you say "this" and then give us a big blob of code. Which specific if/else/etc. branch were you talking about?

All of it.

Basically, when I have the login form in my header file, and have the action='login.php' as a part of the form, whenever I try submit anything else on my site, it goes to login.php even though the action is something else within the script. I thought have a switch might prevent it as I cannot find another solution.

bradgrafelman

th3rdhero wrote:
All of it.

Doesn't make any sense.

the3rdhero wrote:
I thought have a switch might prevent it as I cannot find another solution.

There is nothing you can do with a switch statement that you can't do with if/elseif/else statements.

the3rdhero

Here's the site I'm building: http://www.xodiac.net/

If you go to Upload in the top right hand corner and select an image to upload, you will see what I'm talking about, it goes to login.php and says username and password required, however it shouldn't do that (and doesn't do that if i remove the header, but then I lose the logo etc.)

JVassie

the3rdhero;10975924 wrote:
All of it.

Basically, when I have the login form in my header file, and have the action='login.php' as a part of the form, whenever I try submit anything else on my site, it goes to login.php even though the action is something else within the script. I thought have a switch might prevent it as I cannot find another solution.

Are you sure you closed the form in the header file? That could explain the odd behaviour if you didn't.

The code you posted doesn't seem particularly relevant as it doesn't have any/either of the form tags, and I assume it isn't the header file?

the3rdhero

Nay that is login.php

Here is the header:

    <?php session_start(); ?>
    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
    <html xmlns="http://www.w3.org/1999/xhtml">
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
    <title>Share what you see</title>
    </head>

<body bgcolor='#0a1d2c' text='#000000' link='#33cc00' alink='#33cc00' vlink='#33cc00'>

<table align='center' width='60%' bgcolor='#FFFFFF' style='border-color:#25698e;border-style:solid;border-width:3px' border=0>
  <tr>
      <td>
        <form action='login.php' method='POST'>
        <table width='100%'>
        	<tr>
                    <td width='50%'>
                    <a href='http://www.xodiac.net/'><img src='content/images/logo.png' border='0'/></a>
                    </td>
                    <td>

                    <?php

                                        if(isset($_SESSION['user']))
                                        {
                                                echo "<font size='2' face='arial'><div align='right'><a href='upload.php'>Upload</a> | <a href='logout.php'>Logout</a></div></font>";
                                        }
                                        else
                                        {
                                        echo "
                                                <table align='right'>
                               						 <tr>
                               							 <td>
                               								<font size='2' face='arial'>Username: </font>                              
                               							</td>
                               							<td>
                              								<form action='login.php'><input type='text' name='username' size='16' maxlength='25' />
                         							    </td>
                                						<td>
                               								<font size='2' face='arial'>Password: </font>                              
                               							</td>
							   							<td>
                               							<input type='password' name='password' size='16' maglegnth='25' />
                                                        </td>
                                                        <td>
                                                        <input type='submit' value='Login'/></form>
                                                        <font size='2' face='arial'><a href='register.php'>Register</a></font>
                               							</td>
                           							</tr>
                   								</table>";
                                        }
                                        ?>

                    </td>
            </tr>
        </table>
       </form>           
     </td>
  </tr>
</table>
<p>
<table align='center' width='60%' bgcolor='#FFFFFF' style='border-color:#25698e;border-style:solid;border-width:3px' border=0>
  <tr>
      <td align='center'>