Rows not being updated with if() statement

[bch95]

I have a script to update certain rows that contain certain data in them.

Here is the code:

if ($_POST['newstype'] == "1") {
      $query = mysql_query("SELECT * from `news` WHERE type='1'");
      if (mysql_num_rows($query) == 1) {
          mysql_query("UPDATE `news` SET type = '2' WHERE type = '1' ORDER BY `news`.`dtime` ASC LIMIT 1") or die(mysql_error());
      } else {
          echo "did not edit main news";
      }
  }
  elseif ($_POST['newstype'] == "2") {
        $query = mysql_query("SELECT * from `news` WHERE type='2'");
      if (mysql_num_rows($query) == 3) {
          mysql_query("UPDATE `news` SET type = '3' WHERE type= '2' ORDER BY `news`.`dtime` ASC LIMIT 1") or die(mysql_error());
      } else {
          echo "did not edit recent news";
      }
  }
  elseif ($_POST['newstype'] == "3") {
        $query = mysql_query("SELECT * from `news` WHERE type='3'");
      if (mysql_num_rows($query) == 3) {
          mysql_query("UPDATE `news` SET type = '4' WHERE type= '3' ORDER BY `news`.`dtime` ASC LIMIT 1") or die(mysql_error());
      } else {
          echo "did not edit old news";
      }
  }
  else
  {
  echo "didnt update anything!";
  }    

Here is my database structure.
Why is it not updating it and always echoing Did not edit main/recent/old news.

[cretaceous]

probably because you are counting the rows returned with:

 if (mysql_num_rows($query) == 1) { 

so that will only be true if 1 - and only 1- row is returned

I'm guessing you want to do this

 if (mysql_num_rows($query)) { 

which will be true if it finds any rows - they will then all be updated

I don't think you need the select either - you could do the update straight off, as if there are no rows found it won't update any..

[bch95]

The thing is, I am trying to see if the rows im searching have the value 1 in it.

Here is a pic:

Again please go over my code, im not trying to edit EVERY single row, just the oldest one. Sir before you post read over my code and understand it.

[cretaceous]

sorry dude you need to read my response and understand that first!

you search to see if you have " type='3'"
you then check to see if THREE results are returned
if (mysql_num_rows($query) == 3)

mysql_num_rows shows you the number of rows returned..

if you are tring to edit the oldest row there are better ways - date each entry at the point it is inserted, then order by date , limit 1

[bch95]

Okay, so exactly how would the code look like?

[cretaceous]

ok - what is it you are trying to do:
why can't you list articles in date order?
then first article is main, next 4 are secondary and remainder are 'old'

maybe you should be doing as I suggested earlier
if (mysql_num_rows($query)) {

but if we don't know what you are trying to do and you have an unusual requirement, it is difficult to suggest solutions