An Upload Form and Script

PPowerHouseK

Hello,

I need a simple upload form, that allows a user to upload a file. I hate tried to use two different methods, but to no avail. The form is the same for both attempts, but the php script itself was different. Both versions throw errors upon each upload attempt.
Form:

Select an avatar to upload. <br><br><br><br>
<form action="uploadav.php" method="post" enctype="multipart/form-date">
		<input type="file" name="file" size="50"><br>
		<input type="submit" value="Upload Avatar">
		</form></p><br><br>

Script (Attempt 1):

if($file_name != "")
	{
		mkdir("Avatars/".$username);
		copy("$file", "Avatars/".$username."/" . $file_name) or die ("Could not copy file"); 
	}
else
	{
	die("No file specified");
	}

Error:

Notice: Undefined variable: file_name in C:\xampp\htdocs\Pkshost0\uploadav.php on line 19

Script (Attempt 2):

if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
&& ($_FILES["file"]["size"] < 20000))
  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
    }
  else
    {
    echo "Upload: " . $_FILES["file"]["name"] . "<br />";
    echo "Type: " . $_FILES["file"]["type"] . "<br />";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

if (file_exists("upload/" . $_FILES["file"]["name"]))
  {
  echo $_FILES["file"]["name"] . " already exists. ";
  }
else
  {
  move_uploaded_file($_FILES["file"]["tmp_name"],
  "upload/" . $_FILES["file"]["name"]);
  echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
  }
}
  }
else
  {
  echo "Invalid file";
  }

Error:

Notice: Undefined index: file in C:\xampp\htdocs\Pkshost0\uploadav.php on line 29

Any help on making this work correctly would be greatly appreciated. Thanks in advance.

vividona

use isset() to tell that the value set or not, otherwise, (Undefined index warning message) will be there . So you have to put submit line before you code like this

if(isset($_POST['submit'])){
	if ((($_FILES["file"]["type"] == "image/gif") 
	|| ($_FILES["file"]["type"] == "image/jpeg") 
	|| ($_FILES["file"]["type"] == "image/pjpeg")) 
	&& ($_FILES["file"]["size"] < 20000)) 
	  { 
	  if ($_FILES["file"]["error"] > 0) 
		{ 
		echo "Return Code: " . $_FILES["file"]["error"] . "<br />"; 
		} 
	  else 
		{ 
		echo "Upload: " . $_FILES["file"]["name"] . "<br />"; 
		echo "Type: " . $_FILES["file"]["type"] . "<br />"; 
		echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />"; 
		echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />"; 

	if (file_exists("upload/" . $_FILES["file"]["name"])) 
	  { 
	  echo $_FILES["file"]["name"] . " already exists. "; 
	  } 
	else 
	  { 
	  move_uploaded_file($_FILES["file"]["tmp_name"], 
	  "upload/" . $_FILES["file"]["name"]); 
	  echo "Stored in: " . "upload/" . $_FILES["file"]["name"]; 
	  } 
	} 
  } 
else 
  { 
  echo "Invalid file"; 
  }
}else{
	//put your form here
}

bradgrafelman

The 'enctype' attribute on your HTML form is incorrect (a typo, perhaps?).

PPowerHouseK

Alright so I edited my code to look like this, but I think I may have misunderstood vividona's instructions. I now have a form on two pages instead of one, does that make sense? It sure doesn't to me, but here is what I have:

upav.php (the file selection page)

<html>
<head>
<Title>Avatar Selection</Title>
</head>
<body>
<center>
Select an avatar to upload. <br><br><br><br>
<form action="uploadav.php" method="post" enctype="multipart/form-date">
		<input type="file" name="file" size="50"><br>
		<input type="submit" value="Upload Avatar">
</form></p><br><br>
</body>
</html>

uploadav.php ( the processing script)

if(isset($_POST['submit'])){
    if ((($_FILES["file"]["type"] == "image/gif")
    || ($_FILES["file"]["type"] == "image/jpeg")
    || ($_FILES["file"]["type"] == "image/pjpeg"))
    && ($_FILES["file"]["size"] < 20000))
      {
      if ($_FILES["file"]["error"] > 0)
        {
        echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
        }
      else
        {
        echo "Upload: " . $_FILES["file"]["name"] . "<br />";
        echo "Type: " . $_FILES["file"]["type"] . "<br />";
        echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
        echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

    if (file_exists("upload/" . $_FILES["file"]["name"]))
      {
      echo $_FILES["file"]["name"] . " already exists. ";
      }
    else
      {
      move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $_FILES["file"]["name"]);
      echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
      }
    }
  }
else
  {
  echo "Invalid file";
  }
}else{
    echo"Select an avatar to upload. <br><br><br><br>,
<form action="uploadav.php" method="files" enctype="multipart/form-date">
		<input type="file" name="file" size="50"><br>
		<input type="submit" value="Upload Avatar">
</form></p><br><br>";
} 

?>

<html>

Error:

Parse error: syntax error, unexpected T_STRING, expecting ',' or ';' in C:\xampp\htdocs\Pkshost0\uploadav.php on line 65

As far at that enctype="multipart/form-date" , I am using a book to help me learn php, "PHP In Easy Steps" and it seems that a lot of it's syntax is outdated 🙁 . Please let me know the proper syntax so I can know the right way to do it.

bradgrafelman

As for the parse error, you've got unescaped quotes in the HTML code inside the 'else' branch. If you use double quotes as your string delimiter, you must escape any literal double quotes you want to appear inside that string by placing a backslash before the quote. See the manual page for a [man]string[/man] for more info/examples.

As for the form encoding type, it should be form-data, not form-date. See the PHP manual for more info/example: [man]features.file-upload.post-method[/man].

PPowerHouseK

Alright I changed the form-date to form-data, that was my typo. Also I have looked at the string tutorial page and have tried to edit my code, I just cant seem to get it to work. How should this look? It seems like no matter what I add or remove it still throws that error, and it hasn't even got to the upload function which was the main purpose of this.

bradgrafelman

What have you tried? As I said, anytime you want a literal double quote to appear inside the string you simply must place a backslash before it since you used double quotes as the string delimiter.

PPowerHouseK

Alright here is what I tried in the uploader script

if(isset($_POST['submit'])){
    if ((($_FILES["file"]["type"] == "image/gif")
    || ($_FILES["file"]["type"] == "image/jpeg")
    || ($_FILES["file"]["type"] == "image/pjpeg"))
    && ($_FILES["file"]["size"] < 20000))
      {
      if ($_FILES["file"]["error"] > 0)
        {
        echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
        }
      else
        {
        echo "Upload: " . $_FILES["file"]["name"] . "<br />";
        echo "Type: " . $_FILES["file"]["type"] . "<br />";
        echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
        echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

    if (file_exists("upload/" . $_FILES["file"]["name"]))
      {
      echo $_FILES["file"]["name"] . " already exists. ";
      }
    else
      {
      move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $_FILES["file"]["name"]);
      echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
      }
    }
  }
else
  {
  echo "Invalid file";
  }
}else
	{
	echo"this is not working";
    echo"Select an avatar to upload. <br><br><br><br>";
	echo"<form action=\"uploadav.php\" method=\"files\" enctype=\"multipart/form-data\">";
	echo"<input type=\"file\" name=\"file\" size=\"50\"> <br>";
	echo"<input type=\"submit\" value=\"Upload Avatar\">";
	echo"</form></p><br><br>";
	}

This doesn't display any errors. It just goes in to a loop, The first form now sends me to the second form (i had no idea i needed two), I select a file to upload again , click okay, it sends me to right back to the second form over and over.

At this point I would just like to be able to upload anything, I don't really care about the file type and size restrictions. I just need it to function.

PPowerHouseK

Also I was wondering why my first attempt would work fine in chrome and not in any other browser, such as IE or FF. That to me is strange, I think that was my closest attempt.

vividona

You did not write submit name. You should add name='submit' to the form

the code will be like this

<?php
if(isset($_POST['submit'])){ 
    if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
&& ($_FILES["file"]["size"] < 200000))
  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
    }
  else
    {
    echo "Upload: " . $_FILES["file"]["name"] . "<br />";
    echo "Type: " . $_FILES["file"]["type"] . "<br />";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

if (file_exists("upload/" . $_FILES["file"]["name"]))
  {
  echo $_FILES["file"]["name"] . " already exists. ";
  }
else
  {
  move_uploaded_file($_FILES["file"]["tmp_name"],
  "upload/" . $_FILES["file"]["name"]);
  echo "Stored in: " . "upload/" . $_FILES["file"]["name"];
  }
}
  }
else
  {
  echo "Invalid file";
  }
	}
      else{ 
    echo"<p>this is not working"; 
    echo"Select an avatar to upload. <br><br><br><br>"; 
    echo"<form action='test.php' method='post' enctype='multipart/form-data'>"; 
    echo"<input type='file' name='file' size='50'> <br>"; 
    echo"<input type='submit' name='submit' value='Upload Avatar'>"; 
    echo"</form></p><br><br>"; 
    }
?>

if you need your form to be in another page. You should include the file.

if(isset($_POST['submit'])){

//code here
}
else{
include('upload_form.php');
}