Error on browser: “The page isn't redirecting properly”

siabanie

Hi guys,

Can anyone tell me what is the caused if I got an error on the browser saying: “The page isn't redirecting properly”

I tired to put a condition in a separate file to avoid a user who isnt log in unable to view any pages before logging in. But every time I go to my login page this error: “The page isn't redirecting properly” shown.

Any help please?

Edit: I try to create a "Remember me" checked box using session and cookie. If anyone could help would be appreciated.

Thanks..

bradgrafelman

Sounds like you've got a page redirecting to a second page, yet the second page redirects back to the first page. Either that, or a page is redirecting back to itself.

Can you show us the relevant redirect code from both pages?

siabanie

Here are the code some of them are just a short version of it..Hope it gives you an idea..

Let me know what I did wrong please.. thanks.

login.php file

<?php
	require 'includes/application_top.php';


$error_msg = "";
if (!empty($_POST)) {


if(!empty($_POST['username']) && (!empty($_POST['password']))){

	$_POST['password'] = md5($_POST['password']);

	$query = "SELECT `username`, `admin` FROM `users` WHERE `username` = '".$_POST['username']."' AND `password` = '".
	$_POST['password']."'";


	$result = mysql_query($query);

	$num_rows = mysql_num_rows($result);

	if ($num_rows == 1) {
		$row = mysql_fetch_array($result);

		$_SESSION['username'] = $_POST['username'];
		$_SESSION['authuser'] =0;
		// Register the session
		//$_SESSION['username'] = $row['username'];

		if ( isset($_POST['rememberme']) && $_POST['rememberme'] == "on" ) {
			setcookie ($cookie_name, 'username=' . $_POST['username'] .'password='.$_POST['password'], time() + 
			$cookie_time);
		}//elseif ($rememberme == "")
			//	$_SESSION['username'] = $row['username'];

		if ( $row['admin'] == 1 ) {
			$_SESSION['authuser'] =1;
		}

		header ("Location: index.php");
	} else {
		$error_msg = "Invalid username/password combination!";
	} 

}
else {
	$error_msg = "Please enter your username and password to view this page!";
}
}
?>

The HTML FORM
Cut down version of HTML form for login page:

<html>
..
..
<form method="post" action="<?php echo $_SERVER['PHP_SELF'];?>">
 <br />
    <table width="200" border="0" cellpadding="5">
		<tr >
			<th>Username</th>
			<td><input type="text" name="username" /></td>
		</tr>

	<tr>
    	<th>Password</th>
  		<td><input type="password" name="password" /></td>
	</tr>

	<tr>
		<td colspan="2">
		<label>&nbsp;</label><input type="checkbox" name="rememberme" <?php if ( !empty($_POST['rememberme']) ) echo 'checked'; ?> />Remember Me<br />
		</td>
	</tr>


	<tr >

		<th colspan="2"><input type="submit" name="Submit" value="Login" />

		<input type="reset" name="reset" value="Reset" />
	  </th>
	</tr>
</table>
</form>
..
</html>

application_top.php

<?php
        require 'connection.php';
        require 'global.php';

    $cookie_name = 'siteAuth';
    $cookie_time = (3600 * 24 * 30); // 30 days
?>

connection.php

//Here is connection to DB
session_start();

global.php


 if (!isset($_SESSION['authuser']) || isset ($_COOKIE['username'])){
                 header ("location: login.php");
            exit();
        }

johanafm

As NogDog said, a page redirects back to itself causing an endless loop

login.php is requested
application_top.php is required
global.php is required
user is not yet logged in, so login.php is required. go to 1.

siabanie

johanafm;10976896 wrote:
As NogDog said, a page redirects back to itself causing an endless loop

login.php is requested

application_top.php is required

global.php is required

user is not yet logged in, so login.php is required. go to 1.

Yes now I noticed thanks..

I have correct the file by putting:

login.php

require 'includes/connection.php';
require 'includes/cookie.php';
...
...
all the code as posted back on #3
..

application_top.php

<?php
       require 'connection.php';
       require 'global.php';
       require 'cookie.php'
?>

cookie.php

<?php
      $cookie_name = 'siteAuth';
     $cookie_time = (3600 * 24 * 30); // 30 days
?>

connection.php

//Here is connection to DB
session_start();

global.php

if (!isset($_SESSION['authuser']) || isset ($_COOKIE['username'])){
            header ("location: login.php");
            exit();
        }

Now the problem is: when I trying to log in with a correct username and password. The login page did not redirect to the index page. When I clicked "Login" nothing happen not even an error....

Any ideas why?

johanafm

The simlpest way in my opinion is to

1. login.html (no php needed), which posts to
2. index.php which requires
3. login_handling.php which
  a. checks if user just logged in (form posted?) - tries to log in if so
  b. else checks if user just logged out (get request?) - logs out if so
  c. else checks if user should be logged out due to inactivity

  d. finally checks if user is logged in (after the above has been tried). user not logged in
     redirect to login.html; exit;
     exit is really really important.

And since your login handling requires database access, you could require a db handler.php before your login handler if it's needed, but nothing else. You do not want to risk producing side effects if the user shouldn't have access for some reason.

siabanie

Hi johanafm,

Thanks for the inputs - I have fixed the “The page isn't redirecting properly”.

Now the "Remember me" checked box working fine in my localhost machine I can see the COOKIE in the option setting (Firefox).

But now the problem is: When I run the script in my test server; and do exactly the same thing..the COOKIE did not seem know. When I logged in as an admin and checked the box. And closed all the browser.

Then, open the browser (Firefox)and go to the index page (landing page) then it redirect me to the login page instead. I looked the at COOKIE setting in my Firefox and I can it is stored there.

Any ideas what wrong?