[RESOLVED] UGH!! DB being stupid...

Osyrys14

I'm not new to programming, but this is driving me nuts, I know I'm missing a basic something somewhere...

I have a simple form sent to this php script to process...

$name = $_POST['fname'];
$age = $_POST['lname'];
$gender = $_POST['phon'];
$country = $_POST['comment'];

$host=”mydbserver”;
$user_name=”myusername”;
$pwd=”mypassword”;
$database_name=”mydb”;
$db=mysql_connect($host, $user_name, $pwd);
if (mysql_error() > “”) print mysql_error() . “<br>”;
mysql_select_db($database_name, $db);
if (mysql_error() > “”) print mysql_error() . “<br>”;

$query = “insert into mytest (fname, lname, phon, comments) values (.$name.,.$age.,.$gender.,.$country.)”;

$qresult = mysql_query($query);

You can see what happens live at http://lema.holisticschool.com/testing/form.html, you fill in the form, and click register, and it takes you to a blank screen, which would be all fine and dandy if it wrote to the database like it's supposed to... No error messages (made it past the login errors and everything else) now just get nothing... Not even a write to the DB... Any help would be amazing! Thanks in advance!

Osyrys

johanafm

mysql_query returns false on failure, so

$qresult = mysql_query($query); 
if (!$qresult)
{
	error_log(mysql_errno() .': ' . mysql_error());
}

And considering that you aren't ending your string literal anywhere, the dots aren't concatenation operators, they're just full stop characters, which means the query contains . every here and there.

Also, you are using unsafe data without taking any precautions. You have to escape post data strings with mysql_real_escape_string, cast other post data to int, float etc.

jgetner

i would upgrade your code from mysql to mysqli as it is a more secure and better overall db mechanism for handling your db elegantly.

next use mysqli_connect_error() as this is what it is there for.

bradgrafelman

I think everyone's missing one important part:

Osyrys14 wrote:
it takes you to a blank screen

That's because you either a) aren't checking your PHP error log, or b) don't have your PHP error log properly setup. Enable display_errors and set error_reporting to E_ALL and you'll find that you've got a parse error in the code you posted.

Curly quotes (e.g. “&#8221😉 are not the same character as normal quotes ("") and thus will cause parse errors when used as such.

jgetner

brads correct and your also missing curly brackets after your if statments if(condition){do something;}

bradgrafelman

jgetner;10977675 wrote:
your also missing curly brackets after your if statments if(condition){do something;}

True, but that's not an error of any sort (in fact I often do it myself).

jgetner

really i have actually never attempted it as i figured it was more like c where you have to or it will throw a fit

bradgrafelman

Neither PHP nor C require braces around if() statements.

jgetner

well i think i really bought into that whole curly brackets thing.
guess it was always in my head....

Osyrys14

Thanks for all the suggestions, I did get it worked out. Simple fact of making sure you're using the correct style with the server you're on. Thanks everyone!!