[RESOLVED] Warning: mysql_num_rows(): supplied argument is not a valid MySQL

tobymac

I am so close to finishing this (*****). when i click the activation email this warning shows up on my activation page. i am unsure what this is for an how i can fix this.

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/renovati/public_html/hcrindienetwork/msd/activation.php on line 22

<html>
<body>
<h2>ACTIVATION RESULTS</h2> 
<? 
/* 
Created By Adam Khoury @ www.flashbuilding.com 
-----------------------June 19, 2008-----------------------
*/
//Connect to the database through our include 
include_once "connect_to_mysql.php";
// Get the member id from the URL variable
$id = $_REQUEST['id'];
$id = ereg_replace("[^0-9]", "", $id); // filter everything but numbers for security
if (!$id) {
	echo "Missing Data to Run";
	exit();	
}
// Update the database field named 'email_activated' to 1
$sql = mysql_query("UPDATE members SET emailactivated='1' WHERE id='$id'"); 
// Check the database to see if all is right now 
$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id='$id' AND emailactivated='1'"); 
$doublecheck = mysql_num_rows($sql_doublecheck); 
if($doublecheck == 0){ 
// Print message to the browser saying we could not activate them
print "<br /><br /><div align=\"center\"><h3><strong><font color=red>Your account could not be activated!</font></strong><h3><br /></div>"; 
} elseif ($doublecheck > 0) {
// Print a success message to the browser cuz all is good 
// And supply the user with a link to your log in page, please alter that link line 
print "<br /><br /><h3><font color=\"#0066CC\"><strong>Your account has been activated!<br /><br />
</strong></font><a href=\"http://www.hcrindienetwork.com\">Click Here</a> to log in now.</h3>"; 
} 
?>
</body>
</html>

jgetner

this code here is not valid

$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id='$id' AND emailactivated='1'");
$doublecheck = mysql_num_rows($sql_doublecheck);

should have something like

$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id='$id' AND emailactivated='1'");
$results = mysql_fetch_array($sql_doublecheck , MYSQL_BOTH);
$doublecheck = mysql_num_rows($results);

also ereg functions are depreciated as of php 5.3

tobymac

this code here is not valid

now i get this when i click the activation link in the email

Parse error: syntax error, unexpected '}' in /home/renovati/public_html/hcrindienetwork/msd/activation.php on line 26

jgetner

can you post the updated code?

tobymac

<html>
<body>
<h2>ACTIVATION RESULTS</h2> 
<? 
/* 
Created By Adam Khoury @ www.flashbuilding.com 
-----------------------June 19, 2008-----------------------
*/
//Connect to the database through our include 
include_once "connect_to_mysql.php";
// Get the member id from the URL variable
$id = $_REQUEST['id'];
$id = ereg_replace("[^0-9]", "", $id); // filter everything but numbers for security
if (!$id) {
	echo "Missing Data to Run";
	exit();	
}
// Update the database field named 'email_activated' to 1
$sql = mysql_query("UPDATE members SET emailactivated='1' WHERE id='$id'"); 
// Check the database to see if all is right now 
$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id='$id' AND emailactivated='1'");
$results = mysql_fetch_array($sql_doublecheck , MYSQL_BOTH);
$doublecheck = mysql_num_rows($results);  

// Print message to the browser saying we could not activate them
print "<br /><br /><div align=\"center\"><h3><strong><font color=red>Your account could not be activated!</font></strong><h3><br /></div>"; 
} elseif ($doublecheck > 0) {
// Print a success message to the browser cuz all is good 
// And supply the user with a link to your log in page, please alter that link line 
print "<br /><br /><h3><font color=\"#0066CC\"><strong>Your account has been activated!<br /><br />
</strong></font><a href=\"http://www.somewebsite.com/login.php\">Click Here</a> to log in now.</h3>"; 
} 
?>
</body>
</html>[code=php]

jgetner

you have an extra { right before your elseif that does not pertain to anything in your code my IDE threw a fit about it instantly.

$doublecheck = mysql_num_rows($results);

print "<br /><br /><div align=\"center\"><h3><strong><font color=red>Your account could not be activated!</font></strong><h3><br /></div>";

elseif ($doublecheck > 0) {

tobymac

Okay fixed it!

Now i am getting this 🙁

Parse error: syntax error, unexpected T_ELSEIF in /home/renovati/public_html/hcrindienetwork/msd/activation.php on line 27

<html>
<body>
<h2>ACTIVATION RESULTS</h2> 
<? 
/* 
Created By Adam Khoury @ www.flashbuilding.com 
-----------------------June 19, 2008-----------------------
*/
//Connect to the database through our include 
include_once "connect_to_mysql.php";
// Get the member id from the URL variable
$id = $_REQUEST['id'];
$id = ereg_replace("[^0-9]", "", $id); // filter everything but numbers for security
if (!$id) {
	echo "Missing Data to Run";
	exit();	
}
// Update the database field named 'email_activated' to 1
$sql = mysql_query("UPDATE members SET emailactivated='1' WHERE id='$id'"); 
// Check the database to see if all is right now 
$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id='$id' AND emailactivated='1'");
$results = mysql_fetch_array($sql_doublecheck , MYSQL_BOTH);
$doublecheck = mysql_num_rows($results);  

// Print message to the browser saying we could not activate them
print "<br /><br /><div align=\"center\"><h3><strong><font color=red>Your account could not be activated!</font></strong><h3><br /></div>"; 
elseif ($doublecheck > 0) {
// Print a success message to the browser cuz all is good 
// And supply the user with a link to your log in page, please alter that link line 
print "<br /><br /><h3><font color=\"#0066CC\"><strong>Your account has been activated!<br /><br />
</strong></font><a href=\"http://www.somewebsite.com/login.php\">Click Here</a> to log in now.</h3>"; 
} 
?>
</body>
</html>

jgetner

you need to change your elseif to if and then validate that $doublecheck exists and then check its count .

tobymac

you need to change your elseif to if and then validate that $doublecheck exists and then check its count .

okay i changed the elseif to if, how exactly do i validate that $doublecheck exists and check its count? i dont understand

jgetner

if(isset($doublecheck) && $doublecheck > 0)
{
      // code here...
}

tobymac

<html>
<body>
<h2>ACTIVATION RESULTS</h2> 
<? 
/* 
Created By Adam Khoury @ www.flashbuilding.com 
-----------------------June 19, 2008-----------------------
*/
//Connect to the database through our include 
include_once "connect_to_mysql.php";
// Get the member id from the URL variable
$id = $_REQUEST['id'];
$id = ereg_replace("[^0-9]", "", $id); // filter everything but numbers for security
if (!$id) {
	echo "Missing Data to Run";
	exit();	
}
// Update the database field named 'email_activated' to 1
$sql = mysql_query("UPDATE members SET emailactivated='1' WHERE id='$id'"); 
// Check the database to see if all is right now 
$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id='$id' AND emailactivated='1'");
$results = mysql_fetch_array($sql_doublecheck , MYSQL_BOTH);
$doublecheck = mysql_num_rows($results);  

// Print message to the browser saying we could not activate them
print "<br /><br /><div align=\"center\"><h3><strong><font color=red>Your account could not be activated!</font></strong><h3><br /></div>"; 
if(isset($doublecheck) && $doublecheck > 0)
{
// Print a success message to the browser cuz all is good 
// And supply the user with a link to your log in page, please alter that link line 
print "<br /><br /><h3><font color=\"#0066CC\"><strong>Your account has been activated!<br /><br />
</strong></font><a href=\"http://www.somewebsite.com/login.php\">Click Here</a> to log in now.</h3>"; 
} 
?>
</body>
</html>

ACTIVATION RESULTS

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/renovati/public_html/hcrindienetwork/msd/activation.php on line 22

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/renovati/public_html/hcrindienetwork/msd/activation.php on line 23

jgetner

your sql formatting is wrong you need to ether double quote or escape the string.

try this

$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id=".$id." AND emailactivated='1'");

tobymac

I am still getting this 🙁

ACTIVATION RESULTS

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/renovati/public_html/hcrindienetwork/msd/activation.php on line 22

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/renovati/public_html/hcrindienetwork/msd/activation.php on line 23

[PHP<html>
<body>
<h2>ACTIVATION RESULTS</h2>
<?
/
Created By Adam Khoury @ www.flashbuilding.com
-----------------------June 19, 2008-----------------------
/
//Connect to the database through our include
include_once "connect_to_mysql.php";
// Get the member id from the URL variable
$id = $_REQUEST['id'];
$id = ereg_replace("[^0-9]", "", $id); // filter everything but numbers for security
if (!$id) {
echo "Missing Data to Run";
exit();
}
// Update the database field named 'email_activated' to 1
$sql = mysql_query("UPDATE members SET emailactivated='1' WHERE id='$id'");
// Check the database to see if all is right now
$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id=".$id." AND emailactivated='1'");
$results = mysql_fetch_array($sql_doublecheck , MYSQL_BOTH);
$doublecheck = mysql_num_rows($results);

// Print message to the browser saying we could not activate them
print "<br /><br /><div align=\"center\"><h3><strong><font color=red>Your account could not be activated!</font></strong><h3><br /></div>";
if(isset($doublecheck) && $doublecheck > 0)
{
// Print a success message to the browser cuz all is good
// And supply the user with a link to your log in page, please alter that link line
print "<br /><br /><h3><font color=\"#0066CC\"><strong>Your account has been activated!<br /><br />
</strong></font><a href=\"http://www.somewebsite.com/login.php\">Click Here</a> to log in now.</h3>";
}
?>
</body>
</html>[/code]

tobymac

<html>
<body>
<h2>ACTIVATION RESULTS</h2>
<?
/*
Created By Adam Khoury @ www.flashbuilding.com
-----------------------June 19, 2008-----------------------
*/
//Connect to the database through our include
include_once "connect_to_mysql.php";
// Get the member id from the URL variable
$id = $_REQUEST['id'];
$id = ereg_replace("[^0-9]", "", $id); // filter everything but numbers for security
if (!$id) {
echo "Missing Data to Run";
exit();
}
// Update the database field named 'email_activated' to 1
$sql = mysql_query("UPDATE members SET emailactivated='1' WHERE id='$id'");
// Check the database to see if all is right now
$sql_doublecheck = mysql_query("SELECT * FROM members WHERE id=".$id." AND emailactivated='1'");
$results = mysql_fetch_array($sql_doublecheck , MYSQL_BOTH);
$doublecheck = mysql_num_rows($results);
// Print message to the browser saying we could not activate them
print "<br /><br /><div align=\"center\"><h3><strong><font color=red>Your account could not be activated!</font></strong><h3><br /></div>";
if(isset($doublecheck) && $doublecheck > 0)
{
// Print a success message to the browser cuz all is good
// And supply the user with a link to your log in page, please alter that link line
print "<br /><br /><h3><font color=\"#0066CC\"><strong>Your account has been activated!<br /><br />
</strong></font><a href=\"http://www.somewebsite.com/login.php\">Click Here</a> to log in now.</h3>";
}
?>
</body>
</html>