new at php. i got T_STRING error

hwoarang69

need help here plz. i got this error

Parse error: syntax error, unexpected T_STRING in C:\xampp\htdocs\phpSTUFF\WEB\picture.php on line 21

how can i fix this?


<html>
<body>
<form action="picture.php" method ="post" enctype="multipart/form-data">
File:
<input type="file" name = "image">
<input type="submit" value="Upload">
</form>

<?php
  //connect to database
  mysql_connect("localhost", "root", "") or die(mysql_error());
  mysql_select_db("uploadsitestorepic") or die("mysql_error()");

  //file properties
  $file = $_FILES['image']['tmp_name'];

  if(!isset($file))
       echo "Please select an image.";
  else
  {
      $image addslashes(file_get_contents($_FILES['image']['tmp_name']));
       $image_name addslashes($_FILES['image']['name']);
       $image_size getimagesize($_FILES['image']['tmp_name']));


   if($image_size == FALSE)
        echo "Thats's not an image!";
   else
   {
    if(!$insert = mysql_query("INSERT INTO store VALUES('', '$image_name',$image)"))
      echo "Problem uploading image!";
    else
    {
      $lastid = mysql_insert_id();
      echo "Image uploaded.<p/>IMAGE";
    }
   }
  }
?>
</body>
</html>

hwoarang69

... this is not part of the code

hwoarang69

ops.. color=red] /color this isnt part of the code :S

bradgrafelman

This section of code:

      $image addslashes(file_get_contents($_FILES['image']['tmp_name'])); 
       $image_name addslashes($_FILES['image']['name']); 
       $image_size getimagesize($_FILES['image']['tmp_name']));

follows the pattern of a variable, a space, and a function name, which doesn't make any sense. Perhaps you're missing some operators (such as assignment operators) in there?

EDIT: Also note that [man]addslashes/man should not be used to prepare data for a MySQL query. Instead, you should use a more DB-specific function such as [man]mysql_real_escape_string/man (for string data).

hwoarang69

i right forgot the = sign. thanks alot

also i got another error. any idea?

Notice: Undefined index: image in C:\xampp\htdocs\phpSTUFF\WEB\picture.php on line 15

//file properties 
  $file = $_FILES['image']['tmp_name'];

bradgrafelman

Rather than addressing the problem in the above code (which should be obvious after reading the error message), you've got a fundamental/conceptual problem that encompasses that error:

  //file properties 
  $file = $_FILES['image']['tmp_name']; 

  if(!isset($file))

You might as well say if(true) there, because $file is guaranteed to be set every time that if() statement is executed since you defined it on the line right above it. In addition, the line above the if() statement is attempting to access external data without first checking to see that it exists (e.g. using [man]isset/man.

Notice how everything is backwards? Use [man]isset/man to directly test external data - don't attempt to assign that external data to a local variable and then check if that local variable is defined (because you might as well be checking to see if 1 + 1 is equal to 2).

hwoarang69

sorry iam just started php like 2 weeks ago. can u explain lil more? i really dont understand how i can fix this.

thanks