[RESOLVED] update fails to work

[lerro]

I have a form that takes an array of IDs and POSTS them when a button is clicked.

I have printed the array using print_r, and i can see that values are actually being passed

Array ( [staff_id] => Array ( [0] => 18 ) [Submit] => Inactivate ) 

In the above instance, I have clicked one check box so only one record ID is added to the array.

Then i have this function in a class that should update the database and change status of the record

function inactivate_staff($inputArray) {

	if(isset($inputArray['Submit'])){

		foreach($inputArray['staff_id'] as $row){
			$this->staff_id = $row['staff_id'];


			$sql = "UPDATE staff SET status='0' WHERE staff_id='$this->staff_id'";

			$result[] = mysql_query($sql) or die(mysql_error());				
		}		
		return $result;	
	}


}

But when I check the database, no Update is done, yet similar parts work elsewhere in the application.

When i check the returned result using print_r, the array is as follows

Array ( [0] => 1 ) 

This means it acknowledges the mysql_query has run successfully. Why is it then that no update is done to the database?

[bradgrafelman]

The UPDATE query is matching no rows, because of this:

$this->staff_id = $row['staff_id'];

$row is not an array. Use [man]var_dump/man or [man]print_r/man if you don't understand how the [man]foreach/man works.

[jeepin81]

as bradgrafelman said, $row is not an array:

$this->staff_id = $row;

should be what you're looking for.

j

[lerro]

Thanks, that solves it.

However i'm surprised that it was able to work for this similar function which updates the record for another item

	function inactivate_property_type($inputArray) {

	if(isset($inputArray['Submit'])){

		foreach($inputArray['property_type_id'] as $row){
			$this->property_type_id = $row['property_type_id'];

			// Status is set to "0" which symbolises record is inactive
			$sql = "UPDATE property_type SET status='0' WHERE property_type_id='$this->property_type_id'";

			$result[] = mysql_query($sql) or die(mysql_error());				
		}		
		return $result;	
	}


}

Why does this then update the database too if $row is not read that way, as i thought by specifying $row['property_type_id'] in the foreach, then the particular value is accessed, since this works in the html page when data is fetched from a database, placed in an array and one wants to output a given value into a form value element like this

echo '<input name="staff_id" type="text"   value="'.$out['staff_id'].'" />' ;	 

[bradgrafelman]

lerro wrote:

Why does this then update the database too if $row is not read that way

There's no way of knowing since you haven't shown us what $inputArray['property_type_id'] looks like. However, code like this:

foreach($inputArray['property_type_id'] as $row){ 
                $this->property_type_id = $row['property_type_id'];

Will only work for an array structure like:

Array
(
    [property_type_id] => Array
        (
            [0] => Array
                (
                    [property_type_id] => 1
                )

        [1] => Array
            (
                [property_type_id] => 2
            )

        [2] => Array
            (
                [property_type_id] => 3
            )

    )

)

which just seems redundant.

[lerro]

Okay, i now seem to get the difference.

The inputArray is this

echo '<input type="checkbox" name="staff_id[]" value="'.$row['staff_id'].'" />';

That is the field on the form for each record. When the submit button is clicked, all elements with name="staff_id[]" that are checked are stored in that array to be acted on by the function using foreach

The form itself having been produced initially using an array that was return from a Database query

     foreach($staff as $row)

[bradgrafelman]

I didn't see a question in your last post, so.. does that mean you've resolved the issue? Or did I miss something?

[lerro]

You had said there was no inputArray

There's no way of knowing since you haven't shown us what $inputArray['property_type_id'] looks like

so in the last post, i showed how the data originates from the form before getting to the function in the hope that it would clarify and maybe enable you figure out why i was getting success for one and a fail for the other since the second one was also identical in structure

			  echo '<input type="checkbox" name="property_type_id[]" value="'.$row['property_type_id'].'" />'; 

[bradgrafelman]

Since they have the same structure, you have the same problem with the foreach() loop for property_type_id as well; $row['property_type_id'] doesn't exist because $row is not an array.

[lerro]

Thanks