[RESOLVED] Nothing happens - AT ALL!!

[lisaNewbie]

Really desperate need of experienced folks on this one!!

I built a form in which the client wants every field required and the data sent via email. This is what I have: warning, it is a lot!!

<?php

//requires
require_once('validation.php');

//set master email
define('EMAIL', '[e-mail]');

//report errors
ini_set('display_errors', 'On');
error_reporting(E_ALL);

if(@$_POST['submitted'])
{
	//create vars for easier use
	//$_REQUEST contains BOTH $_GET and $_POST
	$owners 	= 		$_POST['owners'];
	$parcel 	= 		$_POST['parcel'];
	$address 	= 		$_POST['address'];
	$city 		= 		$_POST['city'];
	$state 		= 		$_POST['state'];
	$zip 		= 		$_POST['zip'];
	$county 	= 		$_POST['county'];
	$code 		= 		$_POST['code'];
	$txYear 	= 		$_POST['txYear'];
	$reTaxes 	= 		$_POST['reTaxes'];
	$sellPrice 	= 		$_POST['sellPrice'];
	$sellDate 	= 		$_POST['sellDate'];
	$sqFt 		= 		$_POST['sqFt'];
	$age 		= 		$_POST['age'];
	$bdrm 		= 		$_POST['bdrm'];
	$baths 		= 		$_POST['baths'];
	$bsmnt 		= 		$_POST['bsmnt'];
	$garage 	= 		$_POST['garage'];
	$stories 	= 		$_POST['stories'];
	$style 		= 		$_POST['style'];
	$other 		= 		$_POST['other'];
	$use 		= 		$_POST['use'];
	$verify 	= 		$_POST['verify'];
	$submit		= 		$_POST['submit'];

//Validate user input. Create error array to store errors

$error_msg =  array();

$valid = verifyAlpha($owners);

if(!$valid)
{
	$error_msg[] = 'invalid name.';
	$user_error = '<span class="error">Please provide a valid owner name.</span>';
}

$valid = verifyAlphaNum($parcel);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$user_error = '<span class="error">Please provide a the parcel number.</span>';
}

 $valid = verifyAlphaNum($address);

if(!$valid)
{
	$error_msg[] = 'invalid address.';
	$email_error = '<span class="error">Please provide the address of the parcel.</span>';
}

$valid = verifyAlpha($city);

if(!$valid)
{
	$error_msg[] = 'invalid city.';
	$email_error = '<span class="error">Please provide the city.</span>';
}

 $valid = verifyAlpha($state);

if(!$valid)
{
	$error_msg[] = 'invalid state.';
	$email_error = '<span class="error">Please provide the state.</span>';
}

 $valid = verifyNum($zip);

if(!$valid)
{
	$error_msg[] = 'invalid zip code.';
	$email_error = '<span class="error">Please provide a valid zip code.</span>';
}

 $valid = verifyAlpha($county);

if(!$valid)
{
	$error_msg[] = 'invalid county.';
	$email_error = '<span class="error">Please provide the county name.</span>';
}

 $valid = verifyAlphaNum($code);

if(!$valid)
{
	$error_msg[] = 'invalid code.';
	$email_error = '<span class="error">Please provide the parcel code.</span>';
}

 $valid = verifyNum($txYear);

if(!$valid)
{
	$error_msg[] = 'invalid txYear.';
	$email_error = '<span class="error">Please provide the tax year.</span>';
}


 $valid = verifyNum($reTaxes);

if(!$valid)
{
	$error_msg[] = 'invalid RE Taxes.';
	$email_error = '<span class="error">Please provide the RE tax amount.</span>';
}

 $valid = verifyNum($sellPrice);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$email_error = '<span class="error">Please provide the sale amount.</span>';
}

 $valid = verifyAlphaNum($sellDate);

if(!$valid)
{
	$error_msg[] = 'invalid date.';
	$email_error = '<span class="error">Please provide the date on the contract.</span>';
}

 $valid = verifyNum($sqFt);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$email_error = '<span class="error">Please provide the square footage of the building.</span>';
}

 $valid = verifyNum($age);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$email_error = '<span class="error">Please provide the age.</span>';
}

 $valid = verifyNum($bdrm);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$email_error = '<span class="error">Please provide the number of bedrooms.</span>';
}

 $valid = verifyNum($baths);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$email_error = '<span class="error">Please provide the number of baths.</span>';
}

 $valid = verifyNum($garage);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$email_error = '<span class="error">Please provide the garage square footage.</span>';
}

 $valid = verifyNum($stories);

if(!$valid)
{
	$error_msg[] = 'invalid number.';
	$email_error = '<span class="error">Please provide the number of stories.</span>';
}

 $valid = verifyAlpha($style);

if(!$valid)
{
	$error_msg[] = 'invalid entry.';
	$email_error = '<span class="error">Please provide the style type of the house.</span>';
}

 $valid = verifyAlphaNum($other);

if(!$valid)
{
	$error_msg[] = 'invalid entry.';
	$email_error = '<span class="error">Please provide any additional information.</span>';
}

 $valid = verifyAlphaNum($use);

if(!$valid)
{
	$error_msg[] = 'invalid entry.';
	$email_error = '<span class="error">Please provide the useage of the property.</span>';
}

 /*$valid = verifyCheck($verify);

if(!$valid)
{
	$error_msg[] = 'invalid entry';
	$email_error = '<span class="error">Please check the box to send form.</span>';
}*/

//if any errors, don't send email - else send email
if(count($error_msg) === 0)
{
	//prepare for sending email
	$destination = EMAIL;
	$subject = 'Pre-Determination Analysis Form';
	$body = "From: $owners\n Parcel: $parcel\n Address: $address \n City: $city \n State: $state \n Zip: $zip \n County: $county \n Code: $code \n Tax Year: $txYear \n RE Taxes$reTaxes \n Selling Contract Price: $sellPrice \n Selling Contract Date: $sellDate \n Total Sq Ft (Gross Livable): $sqFt \n Age: $age \n No. of Bedrooms: $bdrm \n No. of Baths: $baths \n Basement Sq. Ft. (Finished): $bsmnt \n Garage Sq. Ft. (Finished): $garage \n No. Stories: $stories \n Style: $style \n Other: $other Use: \n $use";

	if(mail($destination, $subject, $body))
	{
		echo 'Your message has been sent. Below is the info you provided:';

		//test to see if form data is recieved.
		echo '<h1>Thanks for providing feedback</h1>';
		echo '<ul>';
		echo '<li>' . $_POST['owner'] . '</li>';
		echo '<li>' . $_POST['city'] . '</li>';
		echo '<li>' . $_POST['state'] . '</li>';
		echo '</ul>';
	}
	else
	{
		echo 'There was an error. Your message has NOT been sent.';
	}
}//if count end

} //ends if submitted
?>

i am using MAMP to work it out. If i leave every field blank & hit submit, it does nothing. When I enter data, hit submit nothing happens. When I enter the wrong data types as defined in the validation, I get nothing. I think you get the point.

The worst part is, I think it is something really 'stoopit! 😉

Here's the link:
http://ptr.hollielizabethdesign.com/preDetermine.html

The page the form appears in, is not the page that actually contains the form. The form is placed into a different page using iframe, which is the URL above. This came from the client so I did not change it.

I cannot tell you how much I appreciate the help. If you can suggest ways to solve this on my own next time, that wold also be a tremendous service!!

Have a good one!!

Lisa

[bradgrafelman]

lisaNewbie wrote:

If i leave every field blank & hit submit, it does nothing. When I enter data, hit submit nothing happens. When I enter the wrong data types as defined in the validation, I get nothing.

Isn't all of that expected? The code you've shown will only do something if a) the form has been submitted, and b) there are no errors.

[lisaNewbie]

but by hitting submit with empty fields, it should report errors and I am not receiving anything in my email. did i leave something out?

Thanks for the quick response!

Lisa 😕

[NogDog]

Maybe your verify*() functions don't return false for an empty value?

[bradgrafelman]

lisaNewbie;10979878 wrote:

it should report errors

Oh? Which line outputs the error information?

As far as I can see, you only execute code if there are no errors. That's it. There's no 'else' statement that outputs any errors that did occur.

[lisaNewbie]

bradgrafelman;10979880 wrote:

Oh? Which line outputs the error information?

As far as I can see, you only execute code if there are no errors. That's it. There's no 'else' statement that outputs any errors that did occur.

But doesn't this statement cover that?

1. $valid = verifyAlphaNum($user );

2. if (!$valid)
   		{
   			$error_msg['user_error'] = '<span class="error">Please provide a user name.</span>';	
   		}

how i read it is:
1. validate using verifyAlphNum for $user
2. if not valid, send error message 'Please provide a user name.'

I didn't think this kind of statement needed an 'else'.

wow. I am really off base here, eh? do you guys have a suggestion for a better way to so this?

thanks again. I am beginning to get discouraged. Think I need to get back to it tomorrow.

thanks, again!

[bradgrafelman]

lisaNewbie wrote:

2. if not valid, send error message 'Please provide a user name.'

But where is the 'send' part? The only thing this line does:

$error_msg['user_error'] = '<span class="error">Please provide a user name.</span>';

is store some data in a variable. It's no different than writing:

$foo = 'bar';

You're just storing data in a variable - you aren't doing anything else with it.

The processing of the data towards the end is wrapped in an if() statement:

if(count($error_msg) === 0) 

So if there are no errors, great, do the processing, send the e-mail, whatever.

But that's it. There's no 'else' statement for that if() block that handles the condition where there are messages stored in the $error_msg variable indicating errors occurred.

[lisaNewbie]

Thank you guys! I was only doing half the job! But now running into something else:

The new error:

Notice: Undefined index: verify in /Applications/MAMP/htdocs/PTR_FoxyCart_5-5/analysisForm.php on line 39

Here's where my code is now:

<?php

//requires
require_once('validation.php');

//set master email
define('EMAIL', '[e-mail]');

//report errors
ini_set('display_errors', 'On');
error_reporting(E_ALL);

if(@$_POST['submitted'])
{
	//create vars for easier use
	//$_REQUEST contains BOTH $_GET and $_POST
	$owners 	= 		$_POST['owners'];
	$parcel 	= 		$_POST['parcel'];
	$address 	= 		$_POST['address'];
	$city 		= 		$_POST['city'];
	$state 		= 		$_POST['state'];
	$zip 		= 		$_POST['zip'];
	$county 	= 		$_POST['county'];
	$code 		= 		$_POST['code'];
	$txYear 	= 		$_POST['txYear'];
	$reTaxes 	= 		$_POST['reTaxes'];
	$sellPrice 	= 		$_POST['sellPrice'];
	$sellDate 	= 		$_POST['sellDate'];
	$sqFt 		= 		$_POST['sqFt'];
	$age 		= 		$_POST['age'];
	$bdrm 		= 		$_POST['bdrm'];
	$baths 		= 		$_POST['baths'];
	$bsmnt 		= 		$_POST['bsmnt'];
	$garage 	= 		$_POST['garage'];
	$stories 	= 		$_POST['stories'];
	$style 		= 		$_POST['style'];
	$other 		= 		$_POST['other'];
	$use 		= 		$_POST['use'];
	$verify 	= 		$_POST['verify'];
	$submitted	= 		$_POST['submitted'];

//Validate user input. Create error array to store errors

$error_msg =  array();

$valid = verifyAlpha($owners);

if(!$valid)
{
	$error_msg['owners_error'] = '<span class="error">Please enter owner name.</span>';
}

$valid = verifyAlphaNum($parcel);

if(!$valid)
{
	$error_msg['parcel_error'] = '<span class="error">Please enter the parcel number.</span>';
}

 $valid = verifyAlphaNum($address);

if(!$valid)
{
	$error_msg['address_error'] = '<span class="error">Please enter address.</span>';
}

$valid = verifyAlpha($city);

if(!$valid)
{
	$error_msg['city_error'] = '<span class="error">Please enter city.</span>';
}

 $valid = verifyAlpha($state);

if(!$valid)
{
	$error_msg['state_error'] = '<span class="error">Please enter state.</span>';
}

 $valid = verifyNum($zip);

if(!$valid)
{
	$error_msg['zip_error'] = '<span class="error">Please enter zip code.</span>';
}

 $valid = verifyAlpha($county);

if(!$valid)
{
	$error_msg['county_error'] = '<span class="error">Please enter county name.</span>';
}

 $valid = verifyAlphaNum($code);

if(!$valid)
{
	$error_msg['code_error'] = '<span class="error">Please enter code.</span>';
}

 $valid = verifyNum($txYear);

if(!$valid)
{
	$error_msg['txYear_error'] = '<span class="error">Please enter tax year.</span>';
}


 $valid = verifyNum($reTaxes);

if(!$valid)
{
	$error_msg['reTaxes_error'] = '<span class="error">Please enter RE taxes.</span>';
}

 $valid = verifyAlphaNum($sellPrice);

if(!$valid)
{
	$error_msg['sellPrice_error'] = '<span class="error">Please enter sale amount.</span>';
}

 $valid = verifyAlphaNum($sellDate);

if(!$valid)
{
	$error_msg['sellDate_error'] = '<span class="error">Please enter contract date.</span>';
}

 $valid = verifyNum($sqFt);

if(!$valid)
{
	$error_msg['sqFt_error'] = '<span class="error">Please enter square footage.</span>';
}

 $valid = verifyNum($age);

if(!$valid)
{
	$error_msg['age_error'] = '<span class="error">Please enter age.</span>';
}

 $valid = verifyNum($bdrm);

if(!$valid)
{
	$error_msg['bdrm_error'] = '<span class="error">Please enter number of bedrooms.</span>';
}

 $valid = verifyAlphaNum($baths);

if(!$valid)
{
	$error_msg['baths_error'] = '<span class="error">Please enter number of baths.</span>';
}

 $valid = verifyAlphaNum($bsmnt);

if(!$valid)
{
	$error_msg['bsmnt_error'] = '<span class="error">Please enter basement square footage.</span>';
}


 $valid = verifyNum($garage);

if(!$valid)
{
	$error_msg['garage_error'] = '<span class="error">Please enter garage square footage.</span>';
}

 $valid = verifyNum($stories);

if(!$valid)
{
	$error_msg['stories_error'] = '<span class="error">Please enter number of stories.</span>';
}

 $valid = verifyAlpha($style);

if(!$valid)
{
	$error_msg['style_error'] = '<span class="error">Please enter style.</span>';
}

 $valid = verifyAlphaNum($other);

if(!$valid)
{
	$error_msg['other_error'] = '<span class="error">Please enter additional information.</span>';
}

 $valid = verifyAlphaNum($use);

if(!$valid)
{
	$error_msg['use_error'] = '<span class="error">Please enter property usage.</span>';
}

$valid = $verify=='1';

if($valid!='1')
{
	$error_msg['verify_error'] = '<span class="error">Please check box to submit.</span>';	
}

//if any errors, don't send email - else send email
if(count($error_msg) === 0)
{
	//prepare for sending email
	$destination = '[e-mail]';
	$subject = 'Pre-Determination Analysis Form';
	$body = "From: $owners\n Parcel: $parcel\n Address: $address \n City: $city \n State: $state \n Zip: $zip \n County: $county \n Code: $code \n Tax Year: $txYear \n RE Taxes$reTaxes \n Selling Contract Price: $sellPrice \n Selling Contract Date: $sellDate \n Total Sq Ft (Gross Livable): $sqFt \n Age: $age \n No. of Bedrooms: $bdrm \n No. of Baths: $baths \n Basement Sq. Ft. (Finished): $bsmnt \n Garage Sq. Ft. (Finished): $garage \n No. Stories: $stories \n Style: $style \n Other: $other Use: \n $use";


	if(mail($destination, $subject, $body))  //if mail works
	{
		echo "Thank you for submitting your Pre-determination Analysis!";
	}

	else
	{
		echo "Please return to form to fix any errors that may have been made.";
	}
}//if count end

} //ends
?>

and in the form:

<input type="checkbox" name="verify" class="check" value="" /> 
   <label for="verify" class="italic verifie">I verify that I am the authorizing agent for this property.</label><?php echo @$error_msg['verify_error']; ?>

All of this is in analysisForm.php referred to in the error.The $verify is defined at the top of the PHP and it is named 'verify' in the form. Suggestions?

http://ptr.hollielizabethdesign.com/preDetermine.html

Thanks again!

[bradgrafelman]

As the error message suggests, $_POST['verify'] doesn't exist. Note that unchecked checkboxes are not included in a form submission. In general, you shouldn't attempt to access external data without first verifying that it exists (e.g. via [man]isset/man or [man]empty/man).

For example, I might define the variable $verify in this way:

$verify = !empty($_POST['verify']);

That way, $verify will be boolean TRUE or FALSE (depending upon whether or not the checkbox was checked or left unchecked, respectively). Note you can also use the ternary operator instead:

$verify = isset($_POST['verify']) ? $_POST['verify'] : NULL;

[lisaNewbie]

you know, i didn't even think of that! of course its empty!! wow, how simple! thank you so much!! got that all working now. thank you!!